From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8DCFDC5AD49 for ; Fri, 6 Jun 2025 15:01:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C15906B0089; Fri, 6 Jun 2025 11:01:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BC6EC6B008C; Fri, 6 Jun 2025 11:01:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ADD256B0092; Fri, 6 Jun 2025 11:01:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 8D1DD6B0089 for ; Fri, 6 Jun 2025 11:01:36 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 16D45C0540 for ; Fri, 6 Jun 2025 15:01:36 +0000 (UTC) X-FDA: 83525289792.15.D42B551 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) by imf15.hostedemail.com (Postfix) with ESMTP id E5122A0022 for ; Fri, 6 Jun 2025 15:01:33 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=a5hfjRCm; spf=pass (imf15.hostedemail.com: domain of usamaarif642@gmail.com designates 209.85.128.42 as permitted sender) smtp.mailfrom=usamaarif642@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749222094; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XhE/4kgP6Fj+Sk1yGpIDfKiYEXxDvnVhFRdNE9ODL7c=; b=HgmakFIKKq3Rt5jyqf2EZkg9oJoMceCwVZATZqlfO0CKL+XpofoMAPtYhX8d9gVgCGZd3T 3Nqxs2+fvTyi9zEDoCOXGD/nZaCmaFB4JhBsj6jnhcfE0qM5ekEB5VjqOq26eQx1GiWQLn 411/uhcZBxNXSx74rvkVLByoSVMXtSY= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=a5hfjRCm; spf=pass (imf15.hostedemail.com: domain of usamaarif642@gmail.com designates 209.85.128.42 as permitted sender) smtp.mailfrom=usamaarif642@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749222094; a=rsa-sha256; cv=none; b=ue9An3hZGL7Ppvithn4C4bBUwp5Yg41163+IeJm1xi8aH99lzS8YlcKwn4uOPDAwIhb9ld 8roWLMo4/dkgJ8UJcQGHOlRqLT9YNxzcFo/SB2AVkHZqAL6ZwODXP1uP7GHUxgu/uqtPuO HQ+e3aCg4RkGokFofjIlE+28vtqQZuI= Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-43edecbfb94so25484695e9.1 for ; Fri, 06 Jun 2025 08:01:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1749222092; x=1749826892; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=XhE/4kgP6Fj+Sk1yGpIDfKiYEXxDvnVhFRdNE9ODL7c=; b=a5hfjRCmGsbTayThlM2vxd71ABPPpjwmBedNUUvRNEWNAGYkTn3vr33CXqAb946eAH 7VWuhuGXrckzIeU5hL8TQT+qbGt54AgtHG5GBCoBzcDfZ9p+EB+yHjl9HVmGnUO0adTz vhQeIiMLdsTUfcls86EzOwn7FOw79q73adgIyHKTwrLvAp1XRC+wC4ZseIXqcQnhltbb /JdHDFADqXo+UsVesa1iHf3ZbwlMNH7hi1l8Wx/GJOIwvkKcrD/RASCxQuuL49ls29Nd +JbYTqldBYPH9Jhd5+boKC4B0vi+6gBaCJpgNdlDqMmY87vmbTR9G6FZXTQo31jAmRYN hzCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749222092; x=1749826892; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=XhE/4kgP6Fj+Sk1yGpIDfKiYEXxDvnVhFRdNE9ODL7c=; b=A40M7AamSdGK85GV1FY491+BC2trW/fWKL+UXS3kMebSj8HQ8nrjF7YH4HCEJXad7F wJ8FQdFfqawwa03pl2cObMnj9XRB87rC12oo7mgCMkYy+8Nu2NliGgPGPhwCL5E6Mr20 +2kb1Fn/QmudJ/nzu43+Loq0tNCzfxA4Tl7RSnQs5wCIGU7XAPt5kGRl7L0kEvJqsWvS o3c4X9ObQytE7unOUUXWclc92It4SJifembKjDcbRO4/PkiVU2zwo91ceFlIIk6yjpTD 45USfrnPHPSpzafMScU7LsA+e3ICcmT9TZ4maWrfta0u7k8yWaBEMi+b2z/skpr5iPsy 838g== X-Forwarded-Encrypted: i=1; AJvYcCXlSM2FdgYD0NVmuUVWRFSEltVF+PyBehQxmVV4h+jpHNnHL+DpvN2h5LMSFmRQY0jrzQUc1JoJeA==@kvack.org X-Gm-Message-State: AOJu0YzR2C8FzAucmRJ1WaQF96lyXGdn9P/YUYh2dQaV1Jg50SFGCmid x6atX3jx0m45zpSLLe9WILKhJDcReoFhR/oHBPqZyGVlrXTYwTNv3vrn X-Gm-Gg: ASbGncv5Mhl6n64ycx0DV1m7swkFfOqFPnFaGyPa7bbNULdsZQSJqNcgfs8hUlexXj8 W5sadk2SWd8iEiyFlBkbdNEvD6Wz8TbK42Oq1VysNCCE1GUJ9FgOGhDu+i5Ydu9WgpQvDDrkc42 5Na4mFsl9YrRRe+qewMENkZvp98fLEhh4Tv2ILsYSqTS2tiFrNhBWVuLeLJd4xu4je9rL+uDpeU fEGc+rmU6UncIznVUPL8lAz6IKv6wCAhJYI2RXwQVrV+MkrV/JB3ouQIYTyofCeBVnYAPTaLThI 9Qp7kWLka+7Cnxfc/Dmj6/exujeLjbyeIfo9IxIy+hU//LeH7znMywQSacOdPQaCQ60LzBkOiEf 23521J5q+oFSyi6mAsDAwjOEhAN5M6MCm8XAy1b5GrQwb2oM= X-Google-Smtp-Source: AGHT+IGht4L4AYrqtRi/DYoLhXywqrxJl5BXrMudsXr/8v6ZxPuIrlGuqilGoY0sNyJ/JMif5N4S6g== X-Received: by 2002:a05:600c:1ca9:b0:43c:fbbf:7bf1 with SMTP id 5b1f17b1804b1-452013fb5d4mr44245585e9.30.1749222090165; Fri, 06 Jun 2025 08:01:30 -0700 (PDT) Received: from ?IPV6:2a02:6b6f:e750:f900:146f:2c4f:d96e:4241? ([2a02:6b6f:e750:f900:146f:2c4f:d96e:4241]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-45203e6e424sm27286955e9.0.2025.06.06.08.01.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 06 Jun 2025 08:01:29 -0700 (PDT) Message-ID: Date: Fri, 6 Jun 2025 16:01:28 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC] mm: khugepaged: use largest enabled hugepage order for min_free_kbytes To: Andrew Morton , david@redhat.com, linux-mm@kvack.org Cc: hannes@cmpxchg.org, shakeel.butt@linux.dev, riel@surriel.com, ziy@nvidia.com, baolin.wang@linux.alibaba.com, lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com, npache@redhat.com, ryan.roberts@arm.com, dev.jain@arm.com, hughd@google.com, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, kernel-team@meta.com, Breno Leitao References: <20250606143700.3256414-1-usamaarif642@gmail.com> Content-Language: en-US From: Usama Arif In-Reply-To: <20250606143700.3256414-1-usamaarif642@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: E5122A0022 X-Stat-Signature: pzyeiecf36kxjikfhs96q4g7ypuzboie X-Rspam-User: X-HE-Tag: 1749222093-678276 X-HE-Meta: U2FsdGVkX18H/RCpq0VJAd5dAJaKnUUGcTuHNzj0jC657lJc8GQek2G7AwEH6i62ZcdhyIQGsgsi/ERTow07qGaTF9uF9D0gB9bsjJDl0kj/8X8vl7lP/jAvUIlL9GisEZEbMulhIcUlPdd9TiCvB3iMJxpivg/X0V8Ln3rkbXGebQy29wuT5Al2lA5TVnXyYhvLrSPJWPlaB+MuHMKEF/kUnp+Iyuz+9R31whzsV9TCArvXT46GGhH3OKSdWJOn/dyTx2qgUIrn0IA0+xxxiNRx4mDFgvdDgXe99ljWRv00RYgxIBzr9EQucXIJl7+F2CbdTME9uYqUfhTOO33nra7d9Zb/ae7HEmQKMWJdty/0H16pyaLatefYd2bfH992ZZgO1DxJjjHw/RW9aeUUdrOmXZH36bOCmUtzDWQS6xJDZdUUpWDtaXvGHmdclZi4C66Z7lQTG5Ew7KTUiVv6vFQGXyJhYypYoO7+yFW6CE3gsFYFueqywloiHFvlG0f9NbYmwiGbbQYeiNBCSWgbDPChJ07HnGjcrpeFryDJD53XIRD4W81p83As3vm6T/61wSRpymL/35/MVb3HJMrH5STgd1y+WMadoYp5o6fm+UQS7YiZDqEV/58o/sGduMDrpwvw6SiinPonofEo9DuzhMRFWd3TATlR3x7EROGnBq1UtG0zCswumQIkXmz8c5JkxD1UVcsp7FqislfeuhIEiA5D6mjGqHZMS4JopwyaKM0LIi0SIFvYTTF1qdhFKm+MObzKxFRc/infaSLQ5t8kJZOu+f4PnkH7EIqY/73n7PAEtCE6IZFUfUQ7qBiuuEkp7BUsQACPzuTBc9sFJB0FFUQuiaSchm9Az3KcYs3g8gj+r/X9492TP99sQr6pc0vo+RC4qP87IypU5sgNVK6ZezAGnsFh3fyoH2vvHHisNvJGlHAWZ5TEGYKaLqghKWMC0SibYhN1S8Cj5wcUMOj gB4fUFx8 waqUJWr38UmlkH9JjbGBeQSIcbDveqHt12xyCingKzxXodE5qXud6DLZZ0rNLVo9b3JNAxQ42QYWDxpOZ7mO2U0sOFPfBu13hxUFAINbqpEq+Rw7TppTW1/rlexmmdYVr6FRMdOwwp2DZ1QkeYMdRaDlKgvTfMAV6czgJ9gbk+McIxapu1JrJEYBS21d+uFfwNejn3qS6y7jMilmO2cJ31wiSJ1V8QpEQlnCNsoWreas4Pmb+JYZdK1GHYQXECqOpKo0HSJVRWa7pVZMnx0+AQKMJS/+BtXNiIG85MOzSeNORkpPP0+vN55GvtHzUFG+iwJtC/EVuHnv3GC6GCoiTAsHwXXBubo9twZx5/55gtvMB5QMr1c6GPSpR2/3sGEwYrP+fMZ1NkTkgzSHqgpsbvrWe2z5SVH7PGYFsGYrggmffsYOshrlJnr80VC2L8obOnGvVrMNwWplxVafeDOhb8ja//qw9L9vVtwRT/uuDoYAAKLf4GCvNR5GZuuwy6QGpNxEn X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 06/06/2025 15:37, Usama Arif wrote: > On arm64 machines with 64K PAGE_SIZE, the min_free_kbytes and hence the > watermarks are evaluated to extremely high values, for e.g. a server with > 480G of memory, only 2M mTHP hugepage size set to madvise, with the rest > of the sizes set to never, the min, low and high watermarks evaluate to > 11.2G, 14G and 16.8G respectively. > In contrast for 4K PAGE_SIZE of the same machine, with only 2M THP hugepage > size set to madvise, the min, low and high watermarks evaluate to 86M, 566M > and 1G respectively. > This is because set_recommended_min_free_kbytes is designed for PMD > hugepages (pageblock_order = min(HPAGE_PMD_ORDER, PAGE_BLOCK_ORDER)). > Such high watermark values can cause performance and latency issues in > memory bound applications on arm servers that use 64K PAGE_SIZE, eventhough > most of them would never actually use a 512M PMD THP. > > Instead of using HPAGE_PMD_ORDER for pageblock_order use the highest large > folio order enabled in set_recommended_min_free_kbytes. > With this patch, when only 2M THP hugepage size is set to madvise for the > same machine with 64K page size, with the rest of the sizes set to never, > the min, low and high watermarks evaluate to 2.08G, 2.6G and 3.1G I forgot to change the other pageblock_nr_pages instance, the patch will need the below fixlet as well. The watermark numbers will then be the same as when 4K PAGE_SIZE is used. commit 0c6bb4e5b3aa078949d712ab9c35e7b2a33cd8a4 (HEAD) Author: Usama Arif Date: Fri Jun 6 15:43:25 2025 +0100 [fixlet] mm: khugepaged: replace all instances of pageblock_nr_pages This will change the 64K page size, 2M THP hugepage madvise min, low and high watermarks to 87M, 575M and 1G. Signed-off-by: Usama Arif diff --git a/mm/khugepaged.c b/mm/khugepaged.c index e64cba74eb2a..1c643f13135e 100644 --- a/mm/khugepaged.c +++ b/mm/khugepaged.c @@ -2650,7 +2650,7 @@ static void set_recommended_min_free_kbytes(void) } /* Ensure 2 pageblocks are free to assist fragmentation avoidance */ - recommended_min = pageblock_nr_pages * nr_zones * 2; + recommended_min = min_thp_pageblock_nr_pages() * nr_zones * 2; /* * Make sure that on average at least two pageblocks are almost free