From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7620C433EF for ; Tue, 15 Mar 2022 12:45:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 330B18D0002; Tue, 15 Mar 2022 08:45:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2E13C8D0001; Tue, 15 Mar 2022 08:45:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1A94E8D0002; Tue, 15 Mar 2022 08:45:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0120.hostedemail.com [216.40.44.120]) by kanga.kvack.org (Postfix) with ESMTP id 073A68D0001 for ; Tue, 15 Mar 2022 08:45:44 -0400 (EDT) Received: from smtpin17.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id BB8DEA22E6 for ; Tue, 15 Mar 2022 12:45:43 +0000 (UTC) X-FDA: 79246592166.17.F232332 Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) by imf10.hostedemail.com (Postfix) with ESMTP id BD9E3C0007 for ; Tue, 15 Mar 2022 12:45:42 +0000 (UTC) Received: from canpemm500002.china.huawei.com (unknown [172.30.72.57]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4KHtMN0Gnzz9sp2; Tue, 15 Mar 2022 20:41:52 +0800 (CST) Received: from [10.174.177.76] (10.174.177.76) by canpemm500002.china.huawei.com (7.192.104.244) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Tue, 15 Mar 2022 20:45:39 +0800 Subject: Re: [PATCH] mm/mlock: Use vma_lookup() instead of find_vma() To: Matthew Wilcox CC: , , , References: <20220314151728.20800-1-linmiaohe@huawei.com> From: Miaohe Lin Message-ID: Date: Tue, 15 Mar 2022 20:45:39 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.177.76] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To canpemm500002.china.huawei.com (7.192.104.244) X-CFilter-Loop: Reflected X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: BD9E3C0007 X-Stat-Signature: pa387y14gmn6eg4r6kf8ik7yxurd4os1 Authentication-Results: imf10.hostedemail.com; dkim=none; spf=pass (imf10.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.189 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com X-HE-Tag: 1647348342-833270 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2022/3/15 20:39, Matthew Wilcox wrote: > On Tue, Mar 15, 2022 at 08:24:04PM +0800, Miaohe Lin wrote: >> On 2022/3/15 0:16, Matthew Wilcox wrote: >>> On Mon, Mar 14, 2022 at 11:17:28PM +0800, Miaohe Lin wrote: >>>> Using vma_lookup() verifies the start is contained in the found vma. This >>>> results in easier to read the code. >>> >>> This conflicts with the maple tree. >> >> IIUC, maple tree is the implementation detail of the vma and this patch >> should not be conflict with it. But there might be some trival conflict. >> Am I supposed to delay this patch until the maple tree's work is done? > > This function is rewritten as part of the maple tree patchset. > There's no point in merging it now, or later. > I see. Thanks for explanation. > . >