From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B7BAC35FF3 for ; Fri, 21 Mar 2025 04:48:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 13231280002; Fri, 21 Mar 2025 00:48:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0E339280001; Fri, 21 Mar 2025 00:48:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EEC66280002; Fri, 21 Mar 2025 00:48:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id D35DC280001 for ; Fri, 21 Mar 2025 00:48:21 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 73395161EAA for ; Fri, 21 Mar 2025 04:48:22 +0000 (UTC) X-FDA: 83244326844.12.8604974 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf17.hostedemail.com (Postfix) with ESMTP id A5B8540005 for ; Fri, 21 Mar 2025 04:48:20 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=none; spf=pass (imf17.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1742532500; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qk3CxC6Q1bbA9Eg1SnZyXcGupWhsmFq2DGjQukFKkL8=; b=uSVSVwbBy87fibi2wGxt8BwaVtxz3/ieJTj7w74g6OzcHpI/DM1mpP/4gJLQz7Nw3r/z7L IqCPn7v6nuH/nXvfVAEPcKKO4OM3D+bz12Wl70rp0Lyk1nmz7IPOiwEr7VO69GRW7qwSZt Uzrmn+pJz/dMI28PVnRg3REiEXJ8up0= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=none; spf=pass (imf17.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1742532500; a=rsa-sha256; cv=none; b=d2DoXBrYa06tFFui4BRr0f9NjKwQ2RoGRXI2VTOvmNd5l1ygp4R8SKRiyd43Ygf512Ch6J o1wC/23X2+5PWGpsPfiZL0rGd9up+/8ZaG54RRAG76jb/+WpLEqMum+u/R04chzFy/aPbo 5HtQQwJF/ejDiITwRUxLm7dnqbnj2gA= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 94279106F; Thu, 20 Mar 2025 21:48:27 -0700 (PDT) Received: from [10.162.16.153] (a077893.blr.arm.com [10.162.16.153]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 68A1A3F673; Thu, 20 Mar 2025 21:48:18 -0700 (PDT) Message-ID: Date: Fri, 21 Mar 2025 10:18:15 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm/page_alloc: Replace flag check with PageHWPoison() in check_new_page_bad() To: Ye Liu , akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Ye Liu References: <20250320063346.489030-1-ye.liu@linux.dev> Content-Language: en-US From: Anshuman Khandual In-Reply-To: <20250320063346.489030-1-ye.liu@linux.dev> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: A5B8540005 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: r7y8rjx7ywpzojnghmpfb9a3591kiuk1 X-HE-Tag: 1742532500-119208 X-HE-Meta: U2FsdGVkX18ahYKbjsZA1VekcSMm9dwdKmnLS5etufJjgG2BzFgZnsIJhddldnA/Y4y/T76x9zElD2F6C4wjWjo8znPDqwZiVC5B/Qnv/ASOB9pId9nvjLnEovAzEVuosVEcQ7Cc7bDI8R8zVNLXeF+bbR9Zn0ndzejTr1S/8JoOad63VXwvjbP1hy5JExfQVW8s3EZMXaNVnXDeQyJJgl3IEYbCidjtGJedlKr/W/+YGoRZ/V65LJJaQR3ySBx1qtNJrEG2IjYBQNOGZsFgBGeusdqkKg0kUTYnucrCDhmGMEjl7uh0Ycdem4XbTwcp1Ho2l0YTBgK4b4x5E4bQJx4YhHhy+acx1kE6q54P2o2vY+kBoWShEzyhglyTqDtzCYNCecGgwuE14Jo6xvCWPvqj03diHvu5Gko+9MB9GM+jl5I/kdgdFIWfpmGo67LWgsvfAt7yHyJ4fJaDsYlD88ng5lvf99JXAriSIcRYdxKqfOv6OIwCB+FU3sUl04ooAKtWHKPnf14+aBkYyAog/ks+2hXwExbNDLismw/6Q4kRDE1tdkzbWBAPMcmOyiTow4onIIQjUtF7622ZxPzgOV66oPoWKWq3Bi8y9zEvfpidViFsbtduy8g2pe0ZINtUk9yp/QVJaN/F7QOuMrIKIFUUfBWa9/i+qONkXulZ7o/Z1u/uA97V0jH+uScDjv0NQFeeDqjrc1T2XrhnlOzNtiNAh1elktJfswcSTKcH62j7WSy5gCtArUmfUfLjv9RFw5QsO/u2jOojF8BYGXPOtyrQBzpwak9FVgcd1gNFztEV4IUrukePU0HKfMhy0o05DJud0dQp47dHdi2wdZdV5Ygt8GdUZB2rfhwUnJTOCRpG1WkYzpxocfE0yju9K/v9cqLoSgR6AfmN3flV8P2U83At+jxIZBNWq+3JxvIjLh1rEDEXMZVMMjKGCKcbJSkb6YQP1Xj3UF0lTcsNBhz Ta8IT3fX zFoteeuSgH0F6mN7twvI/yUOeycA3Wj0KVOGWJ/739uqCD28lHQ5Pb2yWprHvjeF/jz2GwKy2YEAgGMmPpLha/oOw8G+7rfU9BehawOiA7YK3pIWerwWQIlK7VTzfSGBqAxX9tlwTDUlzzsvtFgSydwfAb64TQRgAVksFW4V7n28otLctynKTkgUge7zP2NLFcvrVJmBXRI+PGRgWOoIVcW8K0jGesMnv+FLTFlvXkISv7+6OmWPYpUAxzQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 3/20/25 12:03, Ye Liu wrote: > From: Ye Liu > > This patch replaces the direct check for the __PG_HWPOISON flag with > the PageHWPoison() macro, improving code readability and maintaining > consistency with other parts of the memory management code. > > Signed-off-by: Ye Liu > --- > mm/page_alloc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index fe76fd237dd0..6ef54abebf51 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -1427,7 +1427,7 @@ static __always_inline void page_del_and_expand(struct zone *zone, > > static void check_new_page_bad(struct page *page) > { > - if (unlikely(page->flags & __PG_HWPOISON)) { > + if (unlikely(PageHWPoison(page))) { > /* Don't complain about hwpoisoned pages */ > if (PageBuddy(page)) > __ClearPageBuddy(page); Reviewed-by: Anshuman Khandual