From: "David Hildenbrand (Red Hat)" <david@kernel.org>
To: Wei Yang <richard.weiyang@gmail.com>,
akpm@linux-foundation.org, lorenzo.stoakes@oracle.com,
ziy@nvidia.com, baolin.wang@linux.alibaba.com,
Liam.Howlett@oracle.com, npache@redhat.com, ryan.roberts@arm.com,
dev.jain@arm.com, baohua@kernel.org, lance.yang@linux.dev,
rostedt@goodmis.org, mhiramat@kernel.org,
mathieu.desnoyers@efficios.com
Cc: linux-mm@kvack.org
Subject: Re: [Patch v2 1/3] mm/khugepaged: remove redundant clearing of struct collapse_control
Date: Fri, 14 Nov 2025 09:53:00 +0100 [thread overview]
Message-ID: <a154f3ab-36ec-4b5f-8c61-6719808a2a34@kernel.org> (raw)
In-Reply-To: <20251114030028.7035-2-richard.weiyang@gmail.com>
On 14.11.25 04:00, Wei Yang wrote:
> The structure struct collapse_control is being unnecessarily cleared
> twice during the huge page collapse process.
>
> Both hpage_collapse_scan_file() and hpage_collapse_scan_pmd() currently
> perform a clear operation on this structure.
>
> Remove the redundant clear operation.
>
> Signed-off-by: Wei Yang <richard.weiyang@gmail.com>
Right, and the structure does not seem to get used in between. Thanks!
Acked-by: David Hildenbrand (Red Hat) <david@kernel.org>
--
Cheers
David
next prev parent reply other threads:[~2025-11-14 8:53 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-14 3:00 [Patch v2 0/3] unify PMD scan results and remove redundant cleanup Wei Yang
2025-11-14 3:00 ` [Patch v2 1/3] mm/khugepaged: remove redundant clearing of struct collapse_control Wei Yang
2025-11-14 4:37 ` Dev Jain
2025-11-14 8:53 ` David Hildenbrand (Red Hat) [this message]
2025-11-17 8:04 ` Baolin Wang
2025-11-17 17:23 ` Nico Pache
2025-11-14 3:00 ` [Patch v2 2/3] mm/khugepaged: continue to collapse on SCAN_PMD_NONE Wei Yang
2025-11-14 8:54 ` David Hildenbrand (Red Hat)
2025-11-14 3:00 ` [Patch v2 3/3] mm/khugepaged: unify SCAN_PMD_NONE and SCAN_PMD_NULL into SCAN_NO_PTE_TABLE Wei Yang
2025-11-14 5:06 ` Dev Jain
2025-11-14 8:55 ` David Hildenbrand (Red Hat)
2025-11-17 8:11 ` Baolin Wang
2025-11-17 17:25 ` Nico Pache
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a154f3ab-36ec-4b5f-8c61-6719808a2a34@kernel.org \
--to=david@kernel.org \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=baohua@kernel.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=dev.jain@arm.com \
--cc=lance.yang@linux.dev \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=npache@redhat.com \
--cc=richard.weiyang@gmail.com \
--cc=rostedt@goodmis.org \
--cc=ryan.roberts@arm.com \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox