Re: [PATCH] mm/damon: add loadable module support for sample modules

[Enze Li <lienze@kylinos.cn>]

On 2025/12/12 05:55, SeongJae Park wrote:
> + Christoph
> 
> On Thu, 11 Dec 2025 20:56:14 +0800 Enze Li <lienze@kylinos.cn> wrote:
> 
>> This patch adds loadable kernel module compilation support for the three
>> DAMON sample modules.  While preserving the existing built-in compilation
>> option, the change introduces necessary code exports and configuration
>> updates, enabling these modules to also be built as independent loadable
>> modules.
>>
>> Key modifications include exporting required function symbols from
>> damon/core.c and changing relevant Kconfig options from bool to
>> tristate.  This allows users to select between "built-in", "module", and
>> "disabled" configurations.
>>
>> This enhancement provides greater flexibility for both development and
>> deployment.  Users can now compile the sample modules as loadable
>> modules and manage them dynamically at runtime without reconfiguration
>> or system reboots.
> 
> Thank you for this patch, Enze.  Actually we tried to make the modules
> loadable, but there was an objection [1] with kind clarification from
> Christoph.  In short, we don't want to make DAMON supports loadable modules
> unless there is a real use case in tree.  Samples are supposed to be samples,
> not real usages.

Hmm...  Fair enough.

> Do you have a real use case of the sample modules that require loadability?

Yeah.  Just finished preparing a patchset -- will send it to the
damon@list in a moment.

Thanks,
Enze

<...>