From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C813EB64D9 for ; Tue, 27 Jun 2023 00:13:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4574D8D0002; Mon, 26 Jun 2023 20:13:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 407448D0001; Mon, 26 Jun 2023 20:13:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2F5DE8D0002; Mon, 26 Jun 2023 20:13:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 1F7188D0001 for ; Mon, 26 Jun 2023 20:13:21 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id D6727C0878 for ; Tue, 27 Jun 2023 00:13:20 +0000 (UTC) X-FDA: 80946603360.08.528889A Received: from out-57.mta1.migadu.com (out-57.mta1.migadu.com [95.215.58.57]) by imf17.hostedemail.com (Postfix) with ESMTP id DF4BE40013 for ; Tue, 27 Jun 2023 00:13:18 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=iijq2dGR; spf=pass (imf17.hostedemail.com: domain of yajun.deng@linux.dev designates 95.215.58.57 as permitted sender) smtp.mailfrom=yajun.deng@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687824799; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=TFgU9qn91+n5dnmwJFQd5phUqXXyZnU0m9ZLzY0G0lQ=; b=D4IG2HD9owPz4CQEklsvFJ9rnntfeHwu1ZpImv2+eDcs7b9g+RpAPdfsyQZeYbpUKYaAYZ GcWloOqyvDL7XgCf1++o9jBUThhQruAqJlZJu02LwAPpggxdK+xNEtAQlD/blVg8Kqzglt XbeaBGoNO2HR0jKnUSx5wIQzYK8NThg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687824799; a=rsa-sha256; cv=none; b=Yk341MBEyDlRrA5+pQYb5h8KC7xS+yr/lnR4D6aHE9wv4QBWanDjKN6lU2UpBAarA769YC dh3OcREHb/6XxAzSALHTBn4CGu/eyqZl6AlMAudUERIgo+ezgaWQks8oh48CCN0ys6fy2f 0JpDSOFs6O/iwFxsrBRZ8pHODxlYoBA= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=iijq2dGR; spf=pass (imf17.hostedemail.com: domain of yajun.deng@linux.dev designates 95.215.58.57 as permitted sender) smtp.mailfrom=yajun.deng@linux.dev; dmarc=pass (policy=none) header.from=linux.dev MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1687824796; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TFgU9qn91+n5dnmwJFQd5phUqXXyZnU0m9ZLzY0G0lQ=; b=iijq2dGRrhXtGry+SS/vYvXL2SGxp0knv6IxSR/oDlmCIHBV3tD+DGWTQ9tHwykJbxLR40 K8gXTRR0zfx3vcwMGJzh1BAR0QA2F5hsQxw3+U61vl1Kgt+sV/yPliVjH2HoEK/kJBuiQb XmMjL7Zmqq2L1/+s/wmpudpPgXk1H14= Date: Tue, 27 Jun 2023 00:13:16 +0000 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: "Yajun Deng" Message-ID: Subject: Re: [PATCH] memblock: Introduce memblock_reserve_node() To: "Mike Rapoport" Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org In-Reply-To: References: <20230625050850.GJ52412@kernel.org> <20230624024622.2959376-1-yajun.deng@linux.dev> <4c361d62e0b77242fe4b8592c82c4d90@linux.dev> X-Migadu-Flow: FLOW_OUT X-Rspamd-Queue-Id: DF4BE40013 X-Rspam-User: X-Stat-Signature: yowihuib4ci3xw7xbgtb8iuw5n3pd9qx X-Rspamd-Server: rspam03 X-HE-Tag: 1687824798-534490 X-HE-Meta: U2FsdGVkX1/+rdYd2Ur6fZ/Q60VQ/XoyAVIgPdrMo1K2J+mklMrzDToXmHe+mbN05HmSmRXkb9T+8Gg2AqhoV4enpNkxzeEZzPmRqcGUhPp2Fz85YRl7C3+mK16Gs9G//p65SZl9aLdVaB6G6tZDGQbv3thq+ZFq+KYZPuOmx4JGD6Z3V704GZoO2fbNN2vGpUpgEOlys5DjRG8Y7E0LDKv9C4JDU0hH7TeBE9VCKGWl+qlvZVTa7iz9nwXVl92AcqVejrHPLItygbwDPlfK4tM/AHf8D2CgpaBZVcPaYcQpqQOrVfFQHOb7Alspwn2RBhN+SzgbVVDV55VwCrumN/agD7rqLAbjq0DQpod6luBYltCfXhIR3VZFnp4+YpltHiGDKW4B3fg1kydETvrbuh9Ox/pbOzJBREyd7tsU943PDdadEe6LCcV17MD95tUxtz0WFgIBXfeGbap1tva3ldHJtDxuCy2peAb5aJAPuc/Fmue9l0lWaGHHOPt4rHHANSoSwT6/uMAxXYpI64Qk1U/D4Hq1LOhtn1ppoXLsLQlCJtH7ximDdyl3LF7hjB40SXjUnX2yhkWikOtpiL9DCkD5qmN0wLPD7gA5P3hf0HEZd7OBwzmE+Jf5ecFAJY5fMPV6fvtR0nl0+o1dr8KBWtoGM9ZyRP1nPJw1754q4NP7EpDi/JyKNAggORreaxJJinjv8X7eN63gjkqNokXE4flx0pLcffcVu2gn4ehKsL+O6uhpJW81sju/w4aJjbLmYyZiSoZM70rRFzwQdhaW6H0ki+dbdzEiMCyGqz63kN420c7TkQrwPrhd/gueRKnwxJ24NamHvvCHDWvL0StTEuhbw40Rfhmev6tVtPKG7vH78id6aSgnQvX9J3CZ4+MA7+vhc7zCixziuLyEFlXzjCs1RTbXVSSRwjW6RmjSg85dWg9DnICJ1JJwkdDEH69xiDDohU0l4yGgLPfdr4/ fEAKjSUw 6hpL5bgdtxTxtJV+wPyRAnj7WQSpjHItXMfXmPQV40B1qpjgUU7jh/CCqulXd+JegFXO4tgbe9Icq1VVb0hr77NMsl7Ij+8u/qRaXwLrSLn96iPgZHNaFhXHirc21NbVVc7xIUG3v+CVmwYXBrzS5KIgf3Z977izXqcbM4AVlZtXF+OWTxvLorP1lsMr5Je3Xt0g6 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000002, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: June 26, 2023 2:21 PM, "Mike Rapoport" wrote:=0A=0A> On= Sun, Jun 25, 2023 at 07:39:10AM +0000, Yajun Deng wrote:=0A> =0A>> June = 25, 2023 1:08 PM, "Mike Rapoport" wrote:=0A>> =0A>> On = Sat, Jun 24, 2023 at 10:46:22AM +0800, Yajun Deng wrote:=0A>> =0A>> It on= ly returns address now in memblock_find_in_range_node(), we can add a=0A>= > parameter pointing to integer for node id of the range, which can be us= ed=0A>> to pass the node id to the new reserve region.=0A>> =0A>> Introdu= ce memblock_reserve_node() so that the node id can be passed to=0A>> the = reserve region in memblock_alloc_range_nid().=0A>> =0A>> Signed-off-by: Y= ajun Deng =0A>> =0A>> What problem does this patch = solve?=0A>> =0A>> If we set nid and flags in memblock_alloc_range_nid(), = we may not need=0A>> memblock_set_node() in memmap_init_reserved_pages().= =0A> =0A> When memblock_reserve() is called before NUMA setup, the node i= ds are still=0A> unset in memblock.memory, so very early reservations wil= l be missed and we=0A> still have to update node ids in memblock.reserved= later.=0A=0AEven so, we still need to pass the 'flags' to the new reserv= e region.=0Achoose_memblock_flags() may return MEMBLOCK_MIRROR in membloc= k_alloc_range_nid(),=0Amemblock_reserve() couldn't pass this flag in this= case.=0A=0A=0A>> I tested this patch and delete memblock_set_node() in m= emmap_init_reserved_pages().=0A>> It works fine. I did not delete membloc= k_set_node() in this patch just in case.=0A> =0A> --=0A> Sincerely yours,= =0A> Mike.