From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4ABDD0E6FC for ; Tue, 22 Oct 2024 05:07:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2334A6B007B; Tue, 22 Oct 2024 01:07:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1E37F6B0082; Tue, 22 Oct 2024 01:07:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0F94A6B0083; Tue, 22 Oct 2024 01:07:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id E272B6B007B for ; Tue, 22 Oct 2024 01:07:13 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 17C8F120F5B for ; Tue, 22 Oct 2024 05:06:59 +0000 (UTC) X-FDA: 82700053884.24.5A42D6C Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf03.hostedemail.com (Postfix) with ESMTP id 2259B20007 for ; Tue, 22 Oct 2024 05:07:03 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf03.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729573581; a=rsa-sha256; cv=none; b=lnUlLLxevZ9hrnh6YBAFioBbIUC0uVRri0kub2wxnWkDSg3rzPM/U9+dLwa775tPd0ZruW mbv0o+zXCc2mL8cuiESF/t8b+CtzpmrCUe622bXgslcQaW7As72HctqEMB2qquH03b+3ne ulF10yfCwmVHnu8CJ2nalfbXIeAMDsE= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf03.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729573581; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vKiyfs5gmJkfkeTQKgTJrCROLH2InFnP4W0nW1D+LBE=; b=MOhJj96T4GJArcOap4sX2h6DfdTKox/e/GJrRTD0azOkqQo42WtFqUdOMoFF7amXWQxgms a6CpfpT9/VKN9PaKgr4iFX8nnuUbaoBCIMgP5CRVj4zh8wcSmwNkcuWbRElzj38iwJiETR GsXkH+Lhr/YRBpCvzzHbyPFROjrhHJY= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 3A408497; Mon, 21 Oct 2024 22:07:40 -0700 (PDT) Received: from [10.163.41.149] (unknown [10.163.41.149]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 787123F528; Mon, 21 Oct 2024 22:07:07 -0700 (PDT) Message-ID: Date: Tue, 22 Oct 2024 10:37:05 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm/page_alloc: Use str_off_on() helper in build_all_zonelists() To: Thorsten Blum , Andrew Morton Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20241021091340.5243-2-thorsten.blum@linux.dev> Content-Language: en-US From: Anshuman Khandual In-Reply-To: <20241021091340.5243-2-thorsten.blum@linux.dev> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: 2259B20007 X-Rspamd-Server: rspam01 X-Stat-Signature: fynsdbocitx3tg5bs6z91zt4ndbe9icu X-HE-Tag: 1729573623-720885 X-HE-Meta: U2FsdGVkX1/KQ6uqs28G/6Bau1AbOpshec5iKyzhNKGikL/ulqNITOlVUfvx9DXk32dBybnThG9jEgTfDpnIMKOH7M8o7Dm6ZPWmkP+oqQqo4IwGN0YwIBjZpXlVVt+la23Tkx6gpL/ji9D+SJ/kqtM0LTN/BkXtARNKrmSt8OPCS3loXSuu02PNW+08IlMGEfQ7XohEj/ZkJoiyAYU3t95BHw2R32vrYYbxKPpk0Wal4dS0OlhCO81nHkRBuoyN9nAEVNV2D3aBDx7sgObyd4uUK1Q/ww5MKzwz1ldgUsDbaBn/3tqIBjW7fI8gUiSf6Ms3pS0gK9KH8HD/mwoU1DHLv4JM14ikkjkPnlvWRNOmg7Yccx2E0iKBLWk77XuZeKAkSXqDhWIIAKE2iBQvQHMj2i+6Ld3h7mUDm0c0d3hCJxIC9ylNhvF7CvnI+csAEwOTO1XuoSmKanw+ko1vBHr8CZWEXmzRQw6ENASkkYh3X7CxGdK1n6bUJp6+kX77HwuoVZWvCkjICxBycszJmjINBIYWHwnHeNb+yHxUPMmJY1ykIKpeUzly4Nb6Ht7hm/U9QfWzMkJfmOr3ON/zxp4xBmKGDfyREhzt4jkym1T3am6+UMsB7+MDG2zygEmYE1QfxXJjLnPQG2I6WPMfo6EOrvpwbNYgOpmdVzQHKlXQiPul31C87PbxfmXu75wzeMCfUOPhLr2dSjz/NzHXd21FlFhhR/OmIElmP4EDTCstR14lRT9cFSoOo9L3GLjXz6Bm9vp/rhQm+yJiGlOCEh/NuzeKhnPhwNagr4FoE17QtqNNXsqsLX9J1/GTQ/+asXoXQ7toiuzAPbHQSkosgjmHnIfextm+8ZXpwoJwHCBPsx5rADGmJMcB9CM86l+7wrQYiVWuYhp22gjtHd8qb2M/iQ2y/9NvwXC7uE8puv0AMuGhlP6anjKJmPLnbe05IaVYqNUaYWGZOlWO3Cd mEszZ/JL K0VKrQbbaCrIhiQV7WMY525+p03nDWpkYl3Ca2sCFhFWuR/lLJPYLx5yhdWaGZW78wOBDdnlCCYdBFmE4JK10FD5Wge/P3jWY06PRXRHI1oopXJ5qSKxViD/SdfDVshfLDwjrne4VEt19kSA6hw17ESY/fbvX9SESczJPrZyT38pD2g70aZVQ4hKB05OQIiknG01O X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 10/21/24 14:43, Thorsten Blum wrote: > Remove hard-coded strings by using the str_off_on() helper function. > > Signed-off-by: Thorsten Blum > --- > mm/page_alloc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index 8afab64814dc..11d3fa3587db 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -5495,7 +5495,7 @@ void __ref build_all_zonelists(pg_data_t *pgdat) > > pr_info("Built %u zonelists, mobility grouping %s. Total pages: %ld\n", > nr_online_nodes, > - page_group_by_mobility_disabled ? "off" : "on", > + str_off_on(page_group_by_mobility_disabled), > vm_total_pages); > #ifdef CONFIG_NUMA > pr_info("Policy zone: %s\n", zone_names[policy_zone]); There are multiple other instances which could use similar str_on_off() as well. mm/kasan/hw_tags.c: kasan_vmalloc_enabled() ? "on" : "off", mm/kasan/hw_tags.c: kasan_stack_collection_enabled() ? "on" : "off"); mm/kasan/sw_tags.c: kasan_stack_collection_enabled() ? "on" : "off"); mm/mm_init.c: stack, want_init_on_alloc(GFP_KERNEL) ? "on" : "off", mm/mm_init.c: want_init_on_free() ? "on" : "off"); I would suggest converting all of them together in a single patch instead.