From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1FFF4C4345F for ; Wed, 24 Apr 2024 15:29:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A6BB28D0018; Wed, 24 Apr 2024 11:29:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A1B8B8D0011; Wed, 24 Apr 2024 11:29:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 895558D0018; Wed, 24 Apr 2024 11:29:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 6CB948D0011 for ; Wed, 24 Apr 2024 11:29:13 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 2B0441A024B for ; Wed, 24 Apr 2024 15:29:13 +0000 (UTC) X-FDA: 82044808986.23.C4B3231 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf14.hostedemail.com (Postfix) with ESMTP id C0D07100009 for ; Wed, 24 Apr 2024 15:29:10 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=bVEnr23w; spf=pass (imf14.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713972550; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ZEJp/mhsJN4ER43ot9dFcBJVuSAFehmL/rhGxfiI5bo=; b=gLPKLd+3VQ5aNJSURhBGBnjpB1DnOceiFon/BTQ+8HayJrDezzvkXrIMBPfGr16+y5UzX4 zE4iJ/ZaG2ys3SZZzaEcv2cK6Gv5nbyliD6ZcUWeD3eAiKaWezNXi1p/2dEwKuhnZqlU1G gHZhJJvDcAL2Zvh3qu5yBuMAVmRdAUY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713972550; a=rsa-sha256; cv=none; b=GqLdT2UqruFirPabxJKykeIcPzXZB5rl3LK3nbWqVLJTcgCtHmreTl+Fo+lqjm2+qhjuPi x+X/npGGT0HQMJQ5mLikwiPabeNhHydimv1OgMP+sKbHM1hhU9k5WLQ7lloSol+VoJnCJx O7K2Pu4HPPo0nGNzzuH1XO07xoqBB10= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=bVEnr23w; spf=pass (imf14.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1713972550; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=ZEJp/mhsJN4ER43ot9dFcBJVuSAFehmL/rhGxfiI5bo=; b=bVEnr23wqZwnm2N3xLXvMqM8v4FTNjgwFDdwGswGcdbjm974o03mNlJQVyg0vr3H6+I1Eq jIkIrUnBeSkwu2QoRU3c0Bc4BdcTZgarRFuV07+MOP1pDJHPJQUpbk/tT6jg3ZjwpG/ViN QVoI2yMHqY6uPsUX65wonCQ4vrkuB8I= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-16-lAiZPAjyMISfKA0iUkez_Q-1; Wed, 24 Apr 2024 11:29:06 -0400 X-MC-Unique: lAiZPAjyMISfKA0iUkez_Q-1 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-3477835b2f7so4087536f8f.0 for ; Wed, 24 Apr 2024 08:29:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713972544; x=1714577344; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ZEJp/mhsJN4ER43ot9dFcBJVuSAFehmL/rhGxfiI5bo=; b=EIM+/2gXGHsrH4T418YulERHxEJ30Y4IUqQXaVbDDlbDj6XB2CkzqFd3fzwtrTLehm 8c12Tg62bJR7AcfX0NjJfkYilt7yp0nFHS2Myg2mkrfMeCKUAvgAhCXSN5xaNCJsbb+p vmx13UZlwLzAC7HRCxROIVP9qOW4AuEZTHMtSf4Rs3PerDkNJJ6E6pS+KzM1wytepjAZ gh7Ya4zvqUOIi19Lr23xInlUh/jYSWISZFWGYyhCffBf/8CR1parbKRxikSWS/SIPhG7 cWYP99YbTWGvF8pzNrBU8CKwsEcrauUeSIf/AkTlCSiqzq8/7Js/HNWszqP3NYM5VdF1 e4AA== X-Forwarded-Encrypted: i=1; AJvYcCVJ3K29sormDKG60UABpMzbMnQZWi+95mbYFFgjENyWMnWenNWd8IwG7/7d4p2ZeX5DcErjSV7mNddn1Vpagp1Va9s= X-Gm-Message-State: AOJu0YxIFCrUmnj+tme1toqwAPo6723U1mHWDS6rSpttt/MUGGYhcL1m hF9GKYYIDNutWvVVf0B68Ai46kMQ8Om/rj/6UR0Hh1YuDv0NAo8f2n8jhUI229OnOnHy132VzyK RDOJm2w1SpzzMZN+kCv3pQNFhGFQMehmv/PIH2A+BheG2ER1h X-Received: by 2002:a5d:47c1:0:b0:34b:dc52:265b with SMTP id o1-20020a5d47c1000000b0034bdc52265bmr1086649wrc.49.1713972544719; Wed, 24 Apr 2024 08:29:04 -0700 (PDT) X-Google-Smtp-Source: AGHT+IH9kcJgw6tU4GEfJ/+s2f39siAqViX3EQAdIm57net5ujoaw3chaOw32HLJ1Gk2hoPGSGV1tg== X-Received: by 2002:a5d:47c1:0:b0:34b:dc52:265b with SMTP id o1-20020a5d47c1000000b0034bdc52265bmr1086628wrc.49.1713972544299; Wed, 24 Apr 2024 08:29:04 -0700 (PDT) Received: from ?IPV6:2003:cb:c70d:1f00:7a4e:8f21:98db:baef? (p200300cbc70d1f007a4e8f2198dbbaef.dip0.t-ipconnect.de. [2003:cb:c70d:1f00:7a4e:8f21:98db:baef]) by smtp.gmail.com with ESMTPSA id cs18-20020a056000089200b003437799a373sm17557155wrb.83.2024.04.24.08.29.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 24 Apr 2024 08:29:03 -0700 (PDT) Message-ID: Date: Wed, 24 Apr 2024 17:29:02 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/2] mm: introduce per-order mTHP split counters To: Ryan Roberts , Lance Yang , akpm@linux-foundation.org Cc: 21cnbao@gmail.com, baolin.wang@linux.alibaba.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org References: <20240424135148.30422-1-ioworker0@gmail.com> <11455268-d522-4b3a-8961-892e42cc50f0@arm.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <11455268-d522-4b3a-8961-892e42cc50f0@arm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Stat-Signature: bicyh35h4jwwg19i1d3p7fbuz169r33x X-Rspamd-Queue-Id: C0D07100009 X-Rspamd-Server: rspam06 X-Rspam-User: X-HE-Tag: 1713972550-665774 X-HE-Meta: U2FsdGVkX184nUOvJDSX77rMXhJ53pmzyDID+RMiPz6BbOIK+VBmytup7OkgdDtFVIqqWuakJBTMwEWRhz9LTI4l++l/5DWU+P7JkDQlAkeFVNCBvq3EGg8PJ408EjuhBcBEnd5+DXa0VHfhBRB8EutHtNkCVefnFO5QfyoTmlkXzyasF5JVTeD2Gy+Yw+EH8gnCitX5CvOhxDXztKfjyEhjxAXmui2manncpm0R36qNfHxdcND6RY5VYpp68jFMKIX1iZd70dsurOq8C/LqMlim4GtA2NDdSAM2SrvLN9ZoHT5wzzKNM9IIqyu99FmiumL5W+FqX8j2EhocXT6lp2b6rNyAyv9qdflKe+sy7dKFoOE/wcf6dI+mD8IYqLwTWBmYXsz1tEo0Eb0yb+rfjzBZH5RT98mLcmRv2VUGlWQg2mg7IA2vd8zEpxkNzADJ6r/OYVpX+jSgDPrlpP6xmW5NQGdO7gMDCzSh/Vt8K3dsXttg88IvRBa0+sDez3Qrxk7mz9ovvNDi7sqvqiLAgOHOwndTSxWJN+geHR0fEd7N3qTGwxzxpzLH3OBLGu8OK+JYNlxQICgO1YoN2C2aAe3DjQRBITvmBb0yVHFbIZF1HCAEg/gg3PoM/aJMTDZXae6EYc9JdcPLaZYDSeltt0OVV4x8W4JOzaSMv0NBbq9mCK3BKBHIy3uTl/17EmbaP9VAoXAheR7sh0qpNjAzg89FpbC4O6CD4f2dUGRD/qW6ywfEJBENsdG3KLq+VHfBq4Oajv7h2lQCTB0FkZbddc2cdRpt9lJ7qYRPy9MPIqQ+hSAc30cg1aj1nb/MjfJtJjDPyTKQWONJrnANR3k2CiVW4JoK9W0MC9VuG6UtGNldyujg3vRs0+rIAq9va2l10PwlJJGQsPq1lyKHILNKLYUpnsr8AcZomra7n8blz9k76hQufw1FI9beEHnNjuO5RWKB7XjyXYZMx7M2osA Dc7CwPXy 7ObWCkXLlFOgJQ99ORBodcFsSBpR6deD5o3lbIzd+Apzrhl9BKoxyWNc9b/agK+WQFqtzqYL3UD6VYW+yns74kATeJJ2SHqi0U8krJxI758RgiNXOElZ6ECWf7X6XC3/dDC1N+DH8xQUbZq7YyZ2lb+ggYPQEMviuLwZ0DoPfIlKbztpimWxn71YdVsUTZJ97nlbUykaYlBEWk+2pVnjdZKZjbkPYVVECLuuCU/E6lXKNNuvzGPTv0Ioi9NzsmwLvFNGAid1QADwIiJ11ey5xAAmU5zR1WSmlw6xupaCL9jt+NuFbypYj6w/4EMITsuFboOKhgJJz/xYcrYDvso9EU2VC0ZnIRm/2VKPTFG26TdvnNJ7moXJoFL7KfKp/SZ5nIO+zuDqrV8MqNT5EUZrE5Zyx2S9EWDGNaBt6NmyAHhAjAs7JldeqUZyx09NVEBGLOSE9 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000753, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 24.04.24 17:20, Ryan Roberts wrote: > On 24/04/2024 16:00, David Hildenbrand wrote: >> On 24.04.24 15:51, Lance Yang wrote: >>> Hi all, >>> >>> At present, the split counters in THP statistics no longer include >>> PTE-mapped mTHP. Therefore, we want to introduce per-order mTHP split >>> counters to monitor the frequency of mTHP splits. This will assist >>> developers in better analyzing and optimizing system performance. >>> >>> /sys/kernel/mm/transparent_hugepage/hugepages-/stats >>>          split_page >>>          split_page_failed >>>          deferred_split_page >>> >>> Thanks, >>> Lance >>> --- >>> >>> Lance Yang (2): >>>   mm: add per-order mTHP split counters >>>   mm: add docs for per-order mTHP split counters >>> >>>   Documentation/admin-guide/mm/transhuge.rst | 16 ---------------- >> >> We really have to start documenting these, and what the sementics are. > > I think the diffstat is backwards; the series definitely adds more lines than it > removes. And patch 2 is adding 16 lines of docs, not removing them. How are you > generating this? `git format-patch` should do it correctly for you. > >> >> E.g., is split_page_failed contained in split_page? Is deferred_split_page >> contained in split_page? >> >> But also: just don't call it "split_page". Drop the "_page". >> >> split >> split_failed >> split_deferred > > I guess we are back in "should we be consistent with the existing vmstats" > territory, which uses split_page/split_page_failed/deferred_split_page > Yeah, "thp_split_page" really is odd "transparent huge page split page". > But here, I agree that dropping _page is nicer. Right; we also shouldn't call it "thp_split_page" here :) -- Cheers, David / dhildenb