From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B5F8C3DA4A for ; Sun, 11 Aug 2024 20:14:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BAB926B008A; Sun, 11 Aug 2024 16:14:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B5AC96B0092; Sun, 11 Aug 2024 16:14:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9D3FB6B0095; Sun, 11 Aug 2024 16:14:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 7AB1C6B008A for ; Sun, 11 Aug 2024 16:14:45 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id D107B1405F0 for ; Sun, 11 Aug 2024 20:14:44 +0000 (UTC) X-FDA: 82441067688.04.8E4B757 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf19.hostedemail.com (Postfix) with ESMTP id 7A09A1A0004 for ; Sun, 11 Aug 2024 20:14:42 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=KYtfB2dG; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=9SiQN9Fq; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=KYtfB2dG; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=9SiQN9Fq; spf=pass (imf19.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723407271; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9D/KmRd9c6rXJChAaABYGZf445gCX9B0P6fJLBpMWqI=; b=nuOzX/grADLgyVRF0VHH865UWFzr/Rnpmym0B7bnD/Uu1Zey5XFj6UPWh7IARLk0/YJuKA R3uWjGJwI7BwlQMljgWpUGa0z+pmlSgOSe+TuVAQ8PM5Gz6xeL1X4l51ZrjI+1K9bokO72 ajfYogO+tAd8vRDYHP7nyThWRmDye1A= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=KYtfB2dG; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=9SiQN9Fq; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=KYtfB2dG; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=9SiQN9Fq; spf=pass (imf19.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723407271; a=rsa-sha256; cv=none; b=0vLl9/ZRxDxjCrx7WM6Lderd2jTDjVFoPTaYzPcvb5dWaj2nyxk5cW2X7XpBggWTPinPMF obOoN5ebZKAldvQvkItb1VZ+OFwPAZmwx+uj6TFgYjs/gZbr+qmCPw5xGaXP28/mm7XnIF VcYzIRMkR+Ai2USkV5gZsfucpZUmH44= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 716BF223C0; Sun, 11 Aug 2024 20:14:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1723407280; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9D/KmRd9c6rXJChAaABYGZf445gCX9B0P6fJLBpMWqI=; b=KYtfB2dGBykn2wTDhiVBKG5TSqpXgqugCTdTWtbA2QgJnrG7OxzCapNdHtp+s9KNIO7L/q aeUYaUDGOvf3531hA888HZfb+9DEgHFQZDnAkM4ytX2RyrYlYzHoEJVbXZe9v38IJePmzC cREduBizwPkxsrq9ZU/NGnBPSm/GkLc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1723407280; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9D/KmRd9c6rXJChAaABYGZf445gCX9B0P6fJLBpMWqI=; b=9SiQN9FqFmdTw3js8wqUmVk18GP+8wQGTmHVXm++EXVxZaV6RGXfEFRP+KOo5nfekuNfny GPhPyRkUFfHljMDA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1723407280; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9D/KmRd9c6rXJChAaABYGZf445gCX9B0P6fJLBpMWqI=; b=KYtfB2dGBykn2wTDhiVBKG5TSqpXgqugCTdTWtbA2QgJnrG7OxzCapNdHtp+s9KNIO7L/q aeUYaUDGOvf3531hA888HZfb+9DEgHFQZDnAkM4ytX2RyrYlYzHoEJVbXZe9v38IJePmzC cREduBizwPkxsrq9ZU/NGnBPSm/GkLc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1723407280; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9D/KmRd9c6rXJChAaABYGZf445gCX9B0P6fJLBpMWqI=; b=9SiQN9FqFmdTw3js8wqUmVk18GP+8wQGTmHVXm++EXVxZaV6RGXfEFRP+KOo5nfekuNfny GPhPyRkUFfHljMDA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 042C61398D; Sun, 11 Aug 2024 20:14:39 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id nQoROq8buWYGcQAAD6G6ig (envelope-from ); Sun, 11 Aug 2024 20:14:39 +0000 Message-ID: Date: Sun, 11 Aug 2024 22:16:32 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm, slub: print CPU id on slab OOM To: Axel Rasmussen , Andrew Morton , Christoph Lameter , David Rientjes , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Joonsoo Kim , Pekka Enberg , Roman Gushchin Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org References: <20240806232649.3258741-1-axelrasmussen@google.com> From: Vlastimil Babka Content-Language: en-US In-Reply-To: <20240806232649.3258741-1-axelrasmussen@google.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Action: no action X-Rspam-User: X-Stat-Signature: 9mwp89ggja51c7mh3jn1q7jsp371946m X-Rspamd-Queue-Id: 7A09A1A0004 X-Rspamd-Server: rspam11 X-HE-Tag: 1723407282-690348 X-HE-Meta: U2FsdGVkX1/FHLUzDukMbUuAcjgvCj1zPhzRxDi+y8qBl5UDeo4RSo9xzo8TaaQh9Uz+KWfvtr7faNGBoWp95toSVqwshfuwww3RHMAQjhInsVMO1OiWYVeW5jz0BP+9mRaGKE/nKNf2WbIGeo2DiNwypTjmXqSYoVdsA2rQrUhXaX1M6i7kvFA+8Eh4MuX7komx5T1aaRBd7HwnSSkwCkKiaVgO8w/BVk+9THQR8sAq92nHQ91Ydtcec54rqQI0rgG3GfT9FP3XCvy7toq2uCNPgsJe1UJDgr8bAlxDNyOSzV4GxyWyKgsMPGHF8Yh9aFV8QW/kuH9zwK/zvGRQVXWcAoAWdjK5v0mKVlEaeH/W30kdD9ZvnZ1CO+urQ8jeYQiYBAY4XUQm33kBfADaVkGYf94kZeiqSfb9ew5fsBSQPZtydgidvCWTUWJ5xH3b9Aqh7KD9NDFjpmJI4W7MShOuoa+H7kMbhW6ucDo70aOP15OCEFWwOWj1Q3n1RWefy/Vn1ZXvkQCDemwgN1YkDz8QPzoQnwPOD+8oRe79Sb7n7KtnNc4opQHzAOHV1jmV11HpeMVjGIYDQzpAL0a+GZP0b1FKxk1fHYuS7eLJfvBeHRhX8XwN039GqkGEDP/EsCD2iN1PKN2QbroJFN8WMiKSkyPHVDAVJUP6nw2RXFCMt2nyhpoL69+U7lq45NyvJabZUJpRvSxr9Q2o/tm3D+xS6nPUDBbb9OaAvyL+7Qh8LDQ4q8kG7QaDuPHZtpEAOFzc+vbbdW44hTFLdhRj+B3+GNsUsb8QlOoqyUfOErV/JCZcPDz148/ckaOKYeWeRH8lbW03L5RZP+9iYRfw0qL/hhia5ivabb4VWfXgPgZE9kFRj5zJi5w67Imjg1nBr1VlIHNrO1amsXZ9A/cyU3G3IYVdVmvYT6mRUQnMtrH0ExsdGmynHhf6GEbTOyWnvm60MdN9SDYV3qYVzZP A7pzmOhd Vn9ZILjMiG9/Kh1prAZZ4EJwQqaTXQMgy3seOaTKxNxJ6FtPuK+ByZQJw7FgqNzxhob3W9iaPKvPIVREY+500QyFdPXP3HYqo2siV/6oGkn87PqZDmvOVtkn/Xklj22pg8nKQYglwzducnvtEXIIfOm/xf+EVTgINlvQmhDplJJjqmHqn4BhoLHLCnggyhVz9+3EtfMXXlaBwUg4Wyhkkz0KbWglbJBvtvqBr9xJjhz6RUPi47sYB4ZEtpPdQhWQqUePF9nGeN7MvtkvJ1e4M6axDY34XVE0hvHYrXEdxO+GoQzpW6oICXOR0zTKMvbYopRanTGUS+qWQvurF/icgPnMdb/K2u3fuTiQ3oVOZuZfE5cg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 8/7/24 1:26 AM, Axel Rasmussen wrote: > Depending on how remote_node_defrag_ratio is configured, allocations can > end up in this path as a result of the local node being OOM, despite the > allocation overall being unconstrained (node == -1). > > When we print a warning, printing the current CPU makes that situation > more clear (i.e., you can immediately see which node's OOM status > matters for the allocation at hand). > > Signed-off-by: Axel Rasmussen > --- > mm/slub.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/mm/slub.c b/mm/slub.c > index c9d8a2497fd6..7148047998de 100644 > --- a/mm/slub.c > +++ b/mm/slub.c > @@ -3422,7 +3422,8 @@ slab_out_of_memory(struct kmem_cache *s, gfp_t gfpflags, int nid) > if ((gfpflags & __GFP_NOWARN) || !__ratelimit(&slub_oom_rs)) > return; > > - pr_warn("SLUB: Unable to allocate memory on node %d, gfp=%#x(%pGg)\n", > + pr_warn("SLUB: Unable to allocate memory for CPU %u on node %d, gfp=%#x(%pGg)\n", BTW, wouldn't "on CPU" be more correct, as "for CPU" might be misleading that we are somehow constrained to that CPU? > + preemptible() ? raw_smp_processor_id() : smp_processor_id(), Also could we just use raw_smp_processor_id() always here? I don't see this has any advantage or am I missing something? > nid, gfpflags, &gfpflags); > pr_warn(" cache: %s, object size: %u, buffer size: %u, default order: %u, min order: %u\n", > s->name, s->object_size, s->size, oo_order(s->oo),