From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC50DC6FD1C for ; Mon, 20 Mar 2023 19:13:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3C6A96B0074; Mon, 20 Mar 2023 15:13:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3768D6B0078; Mon, 20 Mar 2023 15:13:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 265236B007B; Mon, 20 Mar 2023 15:13:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 11B9D6B0074 for ; Mon, 20 Mar 2023 15:13:22 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id D388240EF4 for ; Mon, 20 Mar 2023 19:13:21 +0000 (UTC) X-FDA: 80590225002.18.ADCE41F Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) by imf03.hostedemail.com (Postfix) with ESMTP id E51712001D for ; Mon, 20 Mar 2023 19:13:19 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=nWIhlpdV; spf=pass (imf03.hostedemail.com: domain of opendmb@gmail.com designates 209.85.214.175 as permitted sender) smtp.mailfrom=opendmb@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679339600; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7s4+d2xWt406APG3wRaoC6OPOVdCpVfU3Vzs0598DdE=; b=tP2IZ1pysr6LjrR9I3tLRaqU312nghr21JcbEml/WjgGD8OhfiTNA9GcSWvOW70Fwnmmad PZZf1pxAH0oWY7NxHiDuOdo+WdwCu/4pIvjqOiDp/HYBuWkFMxoIXVBGT523tWP5htl4JG ptv8Y+7SvkDIhJrpxNNGDVuxuIfGr9s= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=nWIhlpdV; spf=pass (imf03.hostedemail.com: domain of opendmb@gmail.com designates 209.85.214.175 as permitted sender) smtp.mailfrom=opendmb@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679339600; a=rsa-sha256; cv=none; b=ShF1LwgjLTy5DyU0dJV99rZEsCMJRN8MMpR6V1FahugM3Ijnax+doXOajHj29SK98kkkGl 5/v4NhQAGcw1MQ8j/UIl6F6ywrwyVntq81fXeEatLZ6zL6T5qWCM4fcUHAME+JUtgDePco CxrN4e1RnqWs1QtZGwzzf6U8MAMW+9Q= Received: by mail-pl1-f175.google.com with SMTP id k2so13598271pll.8 for ; Mon, 20 Mar 2023 12:13:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679339599; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=7s4+d2xWt406APG3wRaoC6OPOVdCpVfU3Vzs0598DdE=; b=nWIhlpdVn9X/rafBumS94oat56jB+7pklSvZnGj8qyNxhGHhJaQmaKMZwaGI7dmLWf N1DZ/eyMLh/k2XkMLrz+YWkUaN/AJaUVzMfED8I+KJts1bMf3Ic/521/1lwuVmrfJVym K0gneeVelf0mfmAKHSxeXIO/fz21j89Hx9QoLQBQra5HYHMBjjM8Esl6ou5SgzSinu1G NeKlk5pOvB0FBQiXL4d+uZPJkI5jkFSIFoLqBOoBCJ3i/KXpSe55mYzKnP9XDaxTOk3Q 1xQ9vfCLrTAS5g9ZlwZPirvIJ/IfwrOZoK/TaRxCUp9VbXzimPaEsfXVE4xSEl+uo0V/ uZ3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679339599; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=7s4+d2xWt406APG3wRaoC6OPOVdCpVfU3Vzs0598DdE=; b=hqaHF98C4lIzUPmYby5DOLrHuRx7YNb7IU9zhATjB3so/avZr1Oyz+B6t7R7B9mROR zyapCpz0AWA6aww4o+BOnABVWTKcT3ZK20PFyXTJ+dnANvp5SkCxlUUnkadja4dysniG seu7lBTRdUHUO/g2uEoMyaBBjYoDmHQTDyzVuRG8wng8ypgLvVqhF67mUndPYBQdcTm9 Q5TwcrKOkzBoZ07EitTRiocizCSPnAjcK3gexyEdRSzPIWDMQRr8mLriVzD1mKzhypAG FaqqjPCF120B1a++DNoTcVeoBH2dcIFkBX1daLMWV/VAOxiZVKjuE9+17TXGoH1TWXxv /2vg== X-Gm-Message-State: AO0yUKVTk9gNPIRWqGWEvLFcgsnaFp9FK4F40iWqMYospyvq/za8pcgn kbAkz1NUKKHACXURUrj+m9o= X-Google-Smtp-Source: AK7set/om+UCx0oTBIvEc6pC8uk/9sYk4ebSnIZZLGaZ/Qi2rk9tEIfP5oc57UH1akcWeHNeolR7Pg== X-Received: by 2002:a17:903:5c7:b0:1a1:d219:eaf with SMTP id kf7-20020a17090305c700b001a1d2190eafmr4258951plb.5.1679339598744; Mon, 20 Mar 2023 12:13:18 -0700 (PDT) Received: from [10.69.67.31] ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id d13-20020a170902728d00b001994fc55998sm7032001pll.217.2023.03.20.12.12.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Mar 2023 12:13:18 -0700 (PDT) Message-ID: Date: Mon, 20 Mar 2023 12:12:34 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.1.2 Subject: Re: [PATCH 02/15] mm/cma: move init_cma_reserved_pages() to cma.c and make it static To: Mike Rapoport , David Hildenbrand Cc: Andrew Morton , Matthew Wilcox , Mel Gorman , Michal Hocko , Thomas Bogendoerfer , Vlastimil Babka , linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, linux-mm@kvack.org References: <20230319220008.2138576-1-rppt@kernel.org> <20230319220008.2138576-3-rppt@kernel.org> <8a461e44-7d24-5b5d-db04-e7fa85beeaa7@redhat.com> Content-Language: en-US From: Doug Berger In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: E51712001D X-Stat-Signature: gmhe3eix6sgn8nss5bt4butfmkqtr7nq X-Rspam-User: X-HE-Tag: 1679339599-602415 X-HE-Meta: U2FsdGVkX19tVhy2LLIGmdFfW99Oo9CRghIjRzMUpFdUC1vrdzQMu15VmfQoVkNtylc6Ju2LcNpu216p0fCIVkpxKlHwiN1BKIjY0YznqnglOz+/1R2aytxwh41c8hjyONip4wia3oUyKY8yXZ9RkYv/JZ2fv+TdTRs1imrOY25pa9YfiVvgNhQb/Lf75ooOA9tY+dFTor4QYGzmcG1+2zjABCFvgNOBEhH7Sq45JyAOyKp/JRpY1ANsYKqFy8YD+K+z0Tzsr/bRdwDEwd4u6y/9gIo2NbpkXTXt3puJeojGjvGyvHvQ/4mB+WAJEqu1OlDP2EwqZ4JYI1WIt1/UmhZASBIgo5YLFzVMxehLJJAQXc/m1z7/4J9LrfchesUV8a9+x2USdhmcjLbO1hbS5lW0c7z2TWxRXzUq5NNZ2OiKPCXQbbE9v/WHswjAhI4rS95VMc7ghgW/w7P2NKcCQ3sRoNE85zCxQZIgu1YqNBeFXeu6Ht15FF499BbHqdqi3fKO4787PafqOvbMx9SKrZHqWD60Eu5v4U4KyJmngxO4nzQ/A/42beCQxttoebgorp3DMkv9iQLBiTq2WvP+AWB+t2WVBOPPT3o/BXiA5OajRn+oeXdzLj8bck69L0kSlrcWbbq2xky9o/MpF2l5aSt2b8YZaybsNDMv+F9SUEj6EmGSfgLb9Y6M9S9p9/2OCLlYBG0hBiYVY2s/k10YL2Ck3xXvtFpZsbBYz9Yic8NBLyiBv7SzSOq8OmRoIU7MPaW0+BVcgl6R+En6D2JZXGPBhIaKDjTqxTh9YUVVpD/NDZoJqnd63PvqjPho7g+gtPVNjcOXcsyr2lTd+oXB6r2kParKBRmSNUgELWLuAwKZqsLQaQQJClr8tBa0sElTjgKeWlTSuXkFsyGQ3ZPo9XwUImXqCQwzdZF11i1BXu13siMyNxvMZC7A2jFy54u06T2u+ZchCIr1xCE+jPd 300+x9B3 f2yycEMwNye8rxAmGu/gh39lC7r1pfAXfygG2iYOi4Q6xuR0/Gr3e8SEM/C1s7DykY5bKkBUlkX0QWY0xMnoeQgAGSpO9su9xSLqRrsvVaQZIWGCWX/f7QF02yLIkr5xyfsCaeF8SKBnspWwGDGLZfL0WArjaKybO6+UadVnAfItqsdANiW9XB/yrosVrUktbPNmD1wSu4glj3W0L23Ca35kVvkBgm+M2rxrWq5U/jqo3RA3cNDAj2menifcdAR40ddu1FgkKtkBVckk8S0HOv0h0+sKNw/kI6C51fmnxK+amCIXhiuFmQdH7OH8cviP8BhsJmO2p/I8+ssDhhPd4q3BZy5q3K4yHVwwHKMOGt+jZjuW9MFcc5zqfbygEkaLWYqdWWOzq1RS2Iu1hGCaXQwNsBRFy4mXtdbZXqSutyF6mIe6ojhWGhA6S3mVLNNJw6vKhwg1kD+1p2DLy4bZpzJ6sh4IPiPql/+Ypp+S9nfrlJ4twznN6KirJ4IDmfdtvMOPxOKYH6Ve/KWeMgLpKWc6dR7uht6HHqc0wlAkIQO276JGiWnPUdfuDPRwpv1oZGo49fiZ2NNRfImg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 3/20/2023 4:11 AM, Mike Rapoport wrote: > On Mon, Mar 20, 2023 at 11:30:20AM +0100, David Hildenbrand wrote: >> On 19.03.23 22:59, Mike Rapoport wrote: >>> From: "Mike Rapoport (IBM)" >>> >>> init_cma_reserved_pages() only used in cma.c, no point of having it in >>> page_alloc.c. >>> >>> Move init_cma_reserved_pages() to cma.c and make it static. >> >> I guess the motivation is to avoid letting too many subsystems mess with >> pageblock migratetypes, managed pages, PG_reserved ... > > Judging by the git log it just ended up in page_alloc.c because > set_pageblock_migratetype() was static back then ;) > >> So it kind of makes sense to have these low-level details out of common CMA >> code, no? > > I don't mind keeping it out of cma and folding this into "grand move" > patch. Just an FYI, this conflicts with my patch: https://lore.kernel.org/lkml/20230311003855.645684-6-opendmb@gmail.com/ So it would work better for me if it was folded into your "grand move" (assuming that refers to your patch 4) and init_cma_reserved_pageblock() could be retained as a wrapper there in my patch if we want to still keep set_pageblock_migratetype() out of the common CMA code. -- Thanks, Doug