From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EAD75C77B7F for ; Tue, 16 May 2023 13:19:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6F768280004; Tue, 16 May 2023 09:19:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 68057900002; Tue, 16 May 2023 09:19:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 52139280004; Tue, 16 May 2023 09:19:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 4050F900002 for ; Tue, 16 May 2023 09:19:59 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 0551FADB53 for ; Tue, 16 May 2023 13:19:58 +0000 (UTC) X-FDA: 80796176118.30.BB1422E Received: from mail-pf1-f180.google.com (mail-pf1-f180.google.com [209.85.210.180]) by imf05.hostedemail.com (Postfix) with ESMTP id CF49110000A for ; Tue, 16 May 2023 13:19:55 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=kernel-dk.20221208.gappssmtp.com header.s=20221208 header.b=D73n14xk; spf=pass (imf05.hostedemail.com: domain of axboe@kernel.dk designates 209.85.210.180 as permitted sender) smtp.mailfrom=axboe@kernel.dk; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684243196; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=H4WKCdbuZXrmowcWv+oxI/osiNdEe2yY+VSOSYJSfVU=; b=cGLwZkf3Sb0do3k2B6vgSVV8NY/8in0fxK3XsGTGICLEUKOFZwqAdNCztBUXv+W7PXCisd rRnaZor4ImVxjoy6F3cZfvj1X/oXtuDoP1Jrd1YKzPsdG38KMUTl1T7hq1FrbbcX6GmB8+ LnhEV5XR5tFsrAIMLbr7YEiBQRnaMO8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684243196; a=rsa-sha256; cv=none; b=Bs+DL6oFnzi+cKdi5EudYo/vGfX9wlcjLuk3TkSR4v3UrbTaOwN14vDuI+le1zxizXKYLv J7PcLuewfGmDW7IznoPpGcj0/QqcNAMW8Ag3sKyHYepFodhBRPLbBYzsT3lUFFXEu6cJn1 DJI/u4EJoWwTRvA0LeCvJPDdBGdnOYM= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=kernel-dk.20221208.gappssmtp.com header.s=20221208 header.b=D73n14xk; spf=pass (imf05.hostedemail.com: domain of axboe@kernel.dk designates 209.85.210.180 as permitted sender) smtp.mailfrom=axboe@kernel.dk; dmarc=none Received: by mail-pf1-f180.google.com with SMTP id d2e1a72fcca58-6439bf89cb7so2515407b3a.0 for ; Tue, 16 May 2023 06:19:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20221208.gappssmtp.com; s=20221208; t=1684243194; x=1686835194; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=H4WKCdbuZXrmowcWv+oxI/osiNdEe2yY+VSOSYJSfVU=; b=D73n14xkNZ0zYWAfu+D9/zERZmjsGnclrNclfwbrnYvXdKydCAM6XXUxP2m6AKjw9k b7DrpnkxpJ+Z0aRuB3wun0x8dtBoeijqC+32ligWep5AlzcsoQswye5v5kmJhwM0ckEA /tspQmFWZkOAij0vir4X0awGwbkH6EYQMvHsyeoW0ReJ0MQRswPBdAOPp34BH79xhbTX yOY3DrZlG1QVbDvp0qJJFISARYyqIIZYBZ88Ihs1Nu3fXbLciLK7P4pu6Id6D7XVt6uX V0ErAmZ5pTUZ8vWdFAiCssJprIc1xiBwRAzMgywt7JCnYpOr6xyDTxcb9X/ZLpGgsQqb G7WQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684243194; x=1686835194; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=H4WKCdbuZXrmowcWv+oxI/osiNdEe2yY+VSOSYJSfVU=; b=AWhJ34QWOPIct4sE+S/78ZeEh95enpEWMI/1KE5abl46tfSFnM62R8J6m6yiV0j5GQ SI39b4wdybCrIfPuyJM2UgeEr65zJuj2XwEHZW+n5TLUb5YnrikaNGBjcYORamCTxiTw hD9wiz/fhgo/40rc8dtPpVcQ9cNgkAzfDoTvFmp0IJnNOfWeRb4dSHpJNa/4O2oOM++8 YHhvRHf/STY7GaElO2I1K0Ywb+lbuucOk+gs4a0QEzvTlQw9kKfjfMGhAgbO00t8elrt 6LFj7IPAWNKR0myxWczdYLHcWP7Li2oTWTrnmSKzypLg0UzBYc2dzmQV60MObKl9c0qA vKFw== X-Gm-Message-State: AC+VfDya7NV0bo+PF0IH5E9HAtMzfsWUDNa7shv4zUa56qfen3wqcNG9 9UXp0JCLVMl5w+lMibeDMsc1kQ== X-Google-Smtp-Source: ACHHUZ4FYse1kBDXE+ZocqaY+d33zSOzIzotgd2H3IRYi1iikVVpeD2YWCQL0aetJ9/7/2v96SEaHA== X-Received: by 2002:a05:6a00:2790:b0:644:c382:a380 with SMTP id bd16-20020a056a00279000b00644c382a380mr3134121pfb.0.1684243194518; Tue, 16 May 2023 06:19:54 -0700 (PDT) Received: from [192.168.1.136] ([198.8.77.157]) by smtp.gmail.com with ESMTPSA id a4-20020a62bd04000000b0063d47bfcdd5sm13459476pff.111.2023.05.16.06.19.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 16 May 2023 06:19:53 -0700 (PDT) Message-ID: Date: Tue, 16 May 2023 07:19:52 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v5 4/6] io_uring: rsrc: delegate VMA file-backed check to GUP Content-Language: en-US To: David Hildenbrand , Lorenzo Stoakes , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrew Morton Cc: Matthew Wilcox , Pavel Begunkov , io-uring@vger.kernel.org, Jason Gunthorpe , John Hubbard References: <642128d50f5423b3331e3108f8faf6b8ac0d957e.1684097002.git.lstoakes@gmail.com> <40ed22bb-53e3-ddc2-45ca-f0e763f26242@redhat.com> From: Jens Axboe In-Reply-To: <40ed22bb-53e3-ddc2-45ca-f0e763f26242@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Stat-Signature: 3uewu97p8nawqbhktnx8irrmsixekhns X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: CF49110000A X-HE-Tag: 1684243195-973499 X-HE-Meta: U2FsdGVkX18SSMTF5ZShTZgFf/e9WtfHDsL6oMC49zNIyKTDRd+HhPOL7Avl5F21+MOZb5QbqHgfFf9y2cvI5DJOQLGyUaO9UZvP0lse5fsuHyxTjYAilIxz3pRG1ocdHjO9Z7/mVrLioImi0KALfxpfYWHdO+Er/OYHTms4paJ6dsqOawDzwX7KKC9LSExZte6MHmpQpYR+nOdy7HuS00Rsft4rz4g5usF0m+Mij7PB0ilOH0g++c87z4waC0SmzTcArs1mdEIqvuBkYCL5SdxKqvUs0M2eDw8N54U7urgvLywqGHqC/RfBnAcSaf1tdit7uwBL2ZQlzpzj4ZdtK/JY/aQiyVV6nGyAznFE1Da8Mr5RGoHSy713HcvvTUok7kuRuS7B/X8LFb9qxmVyRdqUAK9ViVVUO+MsjYV+tfAklfat9c/JDeYjWbFvOe5BI8xb5MRS+329o+lkQU83wDkpbAqU5ro1hJ/ioMAz1uZgII4WIyeF+8zAyZIqkrClfQ+EFTLBcitfupKBjx0cRSWwZgBZk2kiZ6mxKfnsEbLvmr1kiKF8ejdHLfPE1ZD+yfqveFCyIuNb5RUNToy4oWAmn8+2r5h5q6Dc3Le6RrGHU6uugCg4CnwCW8orfco9wYPp0CW4OABpOMTiS29uz4OqVVytsoKktqlFbrU2uSY5W//bQhj1aQtugPKAShki4dcMrCZATayIr7Nf7iWYqtljkxwt+XH9t1yhjaDHsXYfZQMfOblwdHkEIuX2UX8fd7GbjBUZ2B/Up8cOGIaAtr/FSX0WLvJJZhldw0wMYfjnlvSk5PCtTbKgs3pE7mctGpQi1PN6lC7SiRfC1MCd1vXec1aqythr2ipqURj4NcZHYsEjNU0YTBCqTrO5XqkzTSOryBLGOj3sCxSgZLcPt+9O64Kg6+F7eviHjc8ORTxEpZz2G5bSi0rQH/uND37DlZVL/LWmX4zxbEXTpsP O8mB4tec fkMyyE7Bw18x02XVjHHhcYTXAaGwV8dqx511sLHEgJph1b2kGayyv/Vrye60v+TTvBfIzjU0G9LVHMdOIT4kuwbdwWi0eaWf9fagPle6RiGpGwdG0nNwf5dulPrLfODkBWgFPgjJOhBgk/jpHhUpKC8vmhObRb6j7ZmFil/IAIw86Ck73UNBPmcjkiGYAlqfBvRwT8ILR7wS2htFdfE0F/bwpluiwrx3Qh2ZrEPTF9vbTFBoVlgg1ogImQT4+2w6qC/8ivmHKvhwj3lt841xRP5moCeN9T7va7LWsrAhtZK4qxG1r2yvV1UnxiIvOlW6b742xGxwWOrL10Df2Ky6KwfkXhbTj8X8tkiHQfIfR48WUX0KVWBDkmcYKcknHm/k64VChRaOwTlkegoNEu883VBw3nNbecglai0uDuVNKiHuogBhginDEnOt/Yf4SEPLeM3prZLrr9y1kTwjdHHgSQ6/gsLQ6ALhWFypYhSfm+gu3EtF3OX2NG3byRpWV4AgUPIWJK1m2WfnbYxLpIXMgP/OSaadi2pAB/JVRG23+ahQt3EDs06Jx/dcQE1ynvkYAkArrRA3OX8YviTE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 5/16/23 2:25?AM, David Hildenbrand wrote: > On 15.05.23 21:55, Jens Axboe wrote: >> On 5/14/23 3:26?PM, Lorenzo Stoakes wrote: >>> Now that the GUP explicitly checks FOLL_LONGTERM pin_user_pages() for >>> broken file-backed mappings in "mm/gup: disallow FOLL_LONGTERM GUP-nonfast >>> writing to file-backed mappings", there is no need to explicitly check VMAs >>> for this condition, so simply remove this logic from io_uring altogether. >> >> Don't have the prerequisite patch handy (not in mainline yet), but if it >> just moves the check, then: >> >> Reviewed-by: Jens Axboe >> > > Jens, please see my note regarding iouring: > > https://lore.kernel.org/bpf/6e96358e-bcb5-cc36-18c3-ec5153867b9a@redhat.com/ > > With this patch, MAP_PRIVATE will work as expected (2), but there will > be a change in return code handling (1) that we might have to document > in the man page. I think documenting that newer kernels will return -EFAULT rather than -EOPNOTSUPP should be fine. It's not a new failure case, just a different error value for an already failing case. Should be fine with just a doc update. Will do that now. -- Jens Axboe