* [PATCH] drivers/base/memory: fix stale reference to memory_block_add_nid()
@ 2026-03-21 10:57 Kexin Sun
2026-03-23 8:52 ` David Hildenbrand (Arm)
2026-03-23 8:56 ` Donet Tom
0 siblings, 2 replies; 3+ messages in thread
From: Kexin Sun @ 2026-03-21 10:57 UTC (permalink / raw)
To: david, osalvador, gregkh, rafael, dakr, linux-mm, linux-cxl,
driver-core, linux-kernel
Cc: julia.lawall, xutong.ma, kexinsun, yunbolyu, ratnadiraw
The function memory_block_add_nid() was renamed to
memory_block_add_nid_early() by commit 0a947c14e48c
("drivers/base: move memory_block_add_nid() into the
caller"). Update the stale reference in add_memory_block().
Assisted-by: unnamed:deepseek-v3.2 coccinelle
Signed-off-by: Kexin Sun <kexinsun@smail.nju.edu.cn>
---
drivers/base/memory.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/base/memory.c b/drivers/base/memory.c
index a3091924918b..0d6ccc7cdf05 100644
--- a/drivers/base/memory.c
+++ b/drivers/base/memory.c
@@ -815,7 +815,7 @@ static int add_memory_block(unsigned long block_id, int nid, unsigned long state
/*
* MEM_ONLINE at this point implies early memory. With NUMA,
* we'll determine the zone when setting the node id via
- * memory_block_add_nid(). Memory hotplug updated the zone
+ * memory_block_add_nid_early(). Memory hotplug updated the zone
* manually when memory onlining/offlining succeeds.
*/
mem->zone = early_node_zone_for_memory_block(mem, NUMA_NO_NODE);
--
2.25.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drivers/base/memory: fix stale reference to memory_block_add_nid()
2026-03-21 10:57 [PATCH] drivers/base/memory: fix stale reference to memory_block_add_nid() Kexin Sun
@ 2026-03-23 8:52 ` David Hildenbrand (Arm)
2026-03-23 8:56 ` Donet Tom
1 sibling, 0 replies; 3+ messages in thread
From: David Hildenbrand (Arm) @ 2026-03-23 8:52 UTC (permalink / raw)
To: Kexin Sun, osalvador, gregkh, rafael, dakr, linux-mm, linux-cxl,
driver-core, linux-kernel
Cc: julia.lawall, xutong.ma, yunbolyu, ratnadiraw
On 3/21/26 11:57, Kexin Sun wrote:
> The function memory_block_add_nid() was renamed to
> memory_block_add_nid_early() by commit 0a947c14e48c
> ("drivers/base: move memory_block_add_nid() into the
> caller"). Update the stale reference in add_memory_block().
>
> Assisted-by: unnamed:deepseek-v3.2 coccinelle
I'm sure that patch was impossible to craft without an LLM. ;)
> Signed-off-by: Kexin Sun <kexinsun@smail.nju.edu.cn>
> ---
Reviewed-by: David Hildenbrand (Arm) <david@kernel.org>
--
Cheers,
David
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drivers/base/memory: fix stale reference to memory_block_add_nid()
2026-03-21 10:57 [PATCH] drivers/base/memory: fix stale reference to memory_block_add_nid() Kexin Sun
2026-03-23 8:52 ` David Hildenbrand (Arm)
@ 2026-03-23 8:56 ` Donet Tom
1 sibling, 0 replies; 3+ messages in thread
From: Donet Tom @ 2026-03-23 8:56 UTC (permalink / raw)
To: Kexin Sun, david, osalvador, gregkh, rafael, dakr, linux-mm,
linux-cxl, driver-core, linux-kernel
Cc: julia.lawall, xutong.ma, yunbolyu, ratnadiraw
On 3/21/26 4:27 PM, Kexin Sun wrote:
> The function memory_block_add_nid() was renamed to
> memory_block_add_nid_early() by commit 0a947c14e48c
> ("drivers/base: move memory_block_add_nid() into the
> caller"). Update the stale reference in add_memory_block().
>
> Assisted-by: unnamed:deepseek-v3.2 coccinelle
> Signed-off-by: Kexin Sun <kexinsun@smail.nju.edu.cn>
> ---
> drivers/base/memory.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/base/memory.c b/drivers/base/memory.c
> index a3091924918b..0d6ccc7cdf05 100644
> --- a/drivers/base/memory.c
> +++ b/drivers/base/memory.c
> @@ -815,7 +815,7 @@ static int add_memory_block(unsigned long block_id, int nid, unsigned long state
> /*
> * MEM_ONLINE at this point implies early memory. With NUMA,
> * we'll determine the zone when setting the node id via
> - * memory_block_add_nid(). Memory hotplug updated the zone
> + * memory_block_add_nid_early(). Memory hotplug updated the zone
> * manually when memory onlining/offlining succeeds.
> */
> mem->zone = early_node_zone_for_memory_block(mem, NUMA_NO_NODE);
LGTM
Reviewed by: Donet Tom <donettom@linux.ibm.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-03-23 8:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-03-21 10:57 [PATCH] drivers/base/memory: fix stale reference to memory_block_add_nid() Kexin Sun
2026-03-23 8:52 ` David Hildenbrand (Arm)
2026-03-23 8:56 ` Donet Tom
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox