From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB1B3C282C6 for ; Mon, 3 Mar 2025 19:31:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 72DF3280007; Mon, 3 Mar 2025 14:31:26 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6B7E7280002; Mon, 3 Mar 2025 14:31:26 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 57F90280007; Mon, 3 Mar 2025 14:31:26 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id D3DD3280002 for ; Mon, 3 Mar 2025 14:31:25 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id EEA86C0EB6 for ; Mon, 3 Mar 2025 19:31:23 +0000 (UTC) X-FDA: 83181233646.20.9AA978D Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) by imf17.hostedemail.com (Postfix) with ESMTP id 7CA8D40009 for ; Mon, 3 Mar 2025 19:31:16 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="JEAOd/vk"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf17.hostedemail.com: domain of inwardvessel@gmail.com designates 209.85.214.172 as permitted sender) smtp.mailfrom=inwardvessel@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741030276; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Xr2rN8A24AmJOSUP943E0GXZqRJ+CVeATonOvCvW6QM=; b=EszRnj/dXkgcNFvEszndp8Iy2zO29Z7NfMJsd1p/mqQtCWbX9gAFZC3BQ04/ePjPnLkgSe hXc123XxyU3AiJj8ZT7Agfpp0kdJrhwdz7EjrdenahsP08tdMXVK8n1y5hTtVjbPlbafTq s2rm05tSFNzmNVmUfmh2atmcCHYSCqo= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="JEAOd/vk"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf17.hostedemail.com: domain of inwardvessel@gmail.com designates 209.85.214.172 as permitted sender) smtp.mailfrom=inwardvessel@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741030276; a=rsa-sha256; cv=none; b=5pPkIRVmf0ik7MU8ihQ61R0VqivBsFVKO8KtyDefqKG23lbikSopaYDttv1ADfE1ZIf1r2 /QrvDCWCb0esaMawxawv1k1T1yc5mAlWLyFCaunZOJZJrYs9DhlNirQf2Z+j2SUOXFV0UE hCuSkoXC6shamFtfUlsCow9Je33gteE= Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-223594b3c6dso83028045ad.2 for ; Mon, 03 Mar 2025 11:31:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1741030274; x=1741635074; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Xr2rN8A24AmJOSUP943E0GXZqRJ+CVeATonOvCvW6QM=; b=JEAOd/vkLfyAUjda1PcIVpYEjNBSVtz/fxqAkad4xgJEOQycka/mgL9FY+ECHzYEJ0 pirQ2t705pVePShcqlFm22TPRRPgff/Y4X3WKZ+dKwoRIewWhZIYvWNUuVIjtDt4A5+E lZbX9WutPyBxCMrOVXc5TXHQuqhXwHDq40PpO4tfbP+jbaR+Qg07TnRo90orB2iM3F1p Eu/iznyg5lBv9kpV4Umw74B9Fo5I2V8zJNy2shd6dsPPQ2XfkkfZdzYya9sEecRPwoaf kzuLRgHkLRYSbbwBvmlkFnEpHuQ3Jml0LiFQcuhwghuRt4Wj69KHNxnMcGG+0tize1U7 R9Tg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741030274; x=1741635074; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Xr2rN8A24AmJOSUP943E0GXZqRJ+CVeATonOvCvW6QM=; b=vtwR431+HXa4NzM2mRhKcVlnAQBDDw/atVKSKyQo4A3TLjM/q3GccaBD0xvvKAVUmZ QbDzBzumQZCEWjc2RPas6aaJxFAh6iM89aNdZx+SdWLIKvmy9QZyMyZkT2HhKBn022Kv WmsHC3F+G9ZFSsNAd/LPLig/WItY+z69XvuMLXQr9URULa5uLpDikEk4vMeGRFF3EWCh Sz0jlpc2fmU34glMDyr9ktxK/86rCPQanuCMOF14Y/m5WeFpF6TZjhAWOWWX1CopEm6E 0jeM/8F9Z8HPqZeSC70ndhfvyjgt/tpsW8lUFICiX/nBXs1LnyvogbO8V8hOygZNtKWN +9ow== X-Forwarded-Encrypted: i=1; AJvYcCU3McCynaRtAWe5jQXvVPwyQEfLXhyPkZgqElMpyaEPYyKwNp44HyIS2xorxG2PEmzx9jabR8Esyg==@kvack.org X-Gm-Message-State: AOJu0YwJYmwiEytiy5mWwCjDjrgztOEOs4Ahnq4EKc4QdvDf6cR0eTek QsvKjzppR8NB9fhuV1eUe5LXA85dMjIu4dPAU7HWQyKLAgsLddBK X-Gm-Gg: ASbGncuDkGZRfn8Ohb83yuLRdJScs2nypV4aVe2Eq17kE8RnELoTZwA2AD8zbKScyPf RyZQulubuOhEQjXUZEQeg3t4pgorcbb+wJZn71lxhOWfyRTiWgcFjOVR3OdvNuvFk/Rd9zvzyj/ TDZB2FLWaDDOqzQQAWQj8+H4P7Hbwjur07k4O8url15Szvvvxp9kDxqUtWe8jF7YOg9qRYy2tHR I8EHgxmEFkknteDVpdfMTLch5CbTk2by5X5QkASk1woVv/AqATVno2N3bTs4Fey8toE84YJHdrV wosUb04rW5gjSVJ1cBKSqLiCa0KB76Q2g1qoCeKZrjoKw0R/Sq3JFnLyzIm6gGyVVbMEz03HHL0 AEA== X-Google-Smtp-Source: AGHT+IFp8Bi/HibOCtj3YAxJ6OJ6F53DYMfe2BuEKNrb6c7O537wvsCXJ/ZNmlxoMT15B6Xp+1U4qQ== X-Received: by 2002:a17:902:fc4f:b0:221:7343:80f5 with SMTP id d9443c01a7336-22369245249mr218997285ad.53.1741030273801; Mon, 03 Mar 2025 11:31:13 -0800 (PST) Received: from ?IPV6:2a03:83e0:1151:15:64c5:2132:888c:8c76? ([2620:10d:c090:500::7:c71d]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7356173aedfsm7050767b3a.95.2025.03.03.11.31.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 03 Mar 2025 11:31:13 -0800 (PST) Message-ID: Date: Mon, 3 Mar 2025 11:31:11 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/4 v2] cgroup: move cgroup_rstat from cgroup to cgroup_subsys_state To: =?UTF-8?Q?Michal_Koutn=C3=BD?= Cc: tj@kernel.org, shakeel.butt@linux.dev, yosryahmed@google.com, mhocko@kernel.org, hannes@cmpxchg.org, akpm@linux-foundation.org, linux-mm@kvack.org, cgroups@vger.kernel.org, kernel-team@meta.com References: <20250227215543.49928-1-inwardvessel@gmail.com> <20250227215543.49928-2-inwardvessel@gmail.com> Content-Language: en-US From: JP Kobryn In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 7CA8D40009 X-Rspam-User: X-Stat-Signature: u3rr7p31e1rxn3tb8ff7yzah4ypbbp75 X-HE-Tag: 1741030276-591932 X-HE-Meta: U2FsdGVkX18qnu63l0PlFiquk4kIjdjL6JQME/Ru+n1Mjd9Fqk0uXvFlXJ1j56t5JPwbH1juCoaHFszijG1zcTiwXIWNW9rqV4dgdrSZl0Sz4a3sXsS+/60u1MvrdflmIokzW7Vw95jxIXwrxMpffdNzkcXPlInJF7FXHNEo8p7AOIpYtrtSZPfe8aaY6Q7PUx4q6GWRtL3AY/DDhegA8X688HbQnniJcAtohLx7/EaXOuinoAwQEtuPVqMzz8e4F0xZEOkoEBlm2/r9IoIMT78HtmoxLuPnN+8zXG7KuaTXiOaE+HHMepWJb0zIbDL+L4t3igeK3fsRjIwwvGR5HrTsgWivp4NqRxe9hPigWA7lgXCJDn+QjsM9iKWl1h7g1TUeHi6/xnns/9cqysFVY6Xuui0GeHay9WQWwim5PzZzc1dYEvBcTNxqPgYwTuPJ59zp5ST5pM+3MH3c01TeyHLlV2Bk8Sb9MR/9pl7rJwdovs70ynyzaBRkZOAN9tknIFCQtrv9M5SV9/Y1U+2q0W5T5gwRIo/GmkUeGjt61/cDsKvZcN7FMWzIm3UGfqp4a3FD+dv+wNa9qFmwB8n2SG/GLd59APXNBdjyDkGCrb/XudNiUoiA/hNju5d1PLqrgRK3p3TxmhaFnz1dHdE301AsCZUqbyAHJeSz8/Nl+zy9T4LHALf3sy48qNkHLjhco17Llklpe0pt0zvbW/l2rQB3ATuTgBvkjiseYWRcXRN9dYKTwAcFahjShx6nJ8g7x+MVLMh4pATJWnPseRHQrzggAbFRWBB9lcmt/jiDLLkVbDcz/kcZmZ75x11TlbontfW1fDK90lkw3mzj814AA3q8m5eGYj8kt8tmn6AtZzPyMvs1KO2Ss5i/xyqSmBInL831HYFx3vmVO9MrbHaipyYW7C5vBP8KDh5R9ZMCHU0aQs/Y9dlBa3Z1F7mhUttb8YaM57DEaUJFfE5o6XV UnrPgD/K n21VlYX6hfwgQOKKWvEEjBs2EacqMD4wh6YNihjQ6wMfW50JyzoFzsw60J9jTmH+dEt2D3dPO6Q+8qRCpmIWcmGx5SCVJZQAyIgeLouXoc1YasbgNcqDyIrvmsh7EXkD/R2JlpBLNwE0gILqnq/WgngNALQTchszy2wP9QLhFC0pZ6D88TLSO1dIp7+3etjynL+bx2BXPh6nRzFOjj6bYAYzhJ5DEBhl3InkIrTZ8u7hyOSSB2zROzcWpLnw8oRKJD6M60yjoAa9fiernzKi0gkM33V7CnEhefITPWWBlJotEcqsrVyonqJMl5KZsH3MhDea7uyQZ1CCaC16fmheIFrGSEwKWGmjf2+EHyP2dGFOToeYmy30cw5brVIuszfVPyuL4BjR3lef8Q0Aa7beNikqQvCvAhjHR1v4+TxtjBFDrpc548eg2HLftX2nUt0l9+fcZHadsh8MDCaEr8KzXd6tSLl5u63mMsdpby9OvG0vBMVfXLTL6Sg0ooJO5YIjZrGx6 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000002, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 3/3/25 7:20 AM, Michal Koutný wrote: > On Thu, Feb 27, 2025 at 01:55:40PM -0800, inwardvessel wrote: > ... >> --- a/kernel/cgroup/cgroup-internal.h >> +++ b/kernel/cgroup/cgroup-internal.h >> @@ -269,8 +269,8 @@ int cgroup_task_count(const struct cgroup *cgrp); >> /* >> * rstat.c >> */ >> -int cgroup_rstat_init(struct cgroup *cgrp); >> -void cgroup_rstat_exit(struct cgroup *cgrp); >> +int cgroup_rstat_init(struct cgroup_subsys_state *css); >> +void cgroup_rstat_exit(struct cgroup_subsys_state *css); > > Given the functions have little in common with struct cgroup now, I'd > not be afraid of renaming them to css_rstat_* so that names match the > processed structure. > (Similar, _updated and _flush and others.) Makes sense. I can rename these (and others that now accept css) in the next rev.