From: Lance Yang <lance.yang@linux.dev>
To: Breno Leitao <leitao@debian.org>
Cc: David Hildenbrand <david@kernel.org>,
Baolin Wang <baolin.wang@linux.alibaba.com>,
Dev Jain <dev.jain@arm.com>, Ryan Roberts <ryan.roberts@arm.com>,
linux-mm@kvack.org, Andrew Morton <akpm@linux-foundation.org>,
Nico Pache <npache@redhat.com>, Barry Song <baohua@kernel.org>,
Zi Yan <ziy@nvidia.com>,
linux-kernel@vger.kernel.org, kernel-team@meta.com,
Lorenzo Stoakes <ljs@kernel.org>,
"Liam R. Howlett" <Liam.Howlett@oracle.com>
Subject: Re: [PATCH 2/2] mm: huge_memory: refactor defrag_show() to use defrag_flags[]
Date: Fri, 3 Apr 2026 13:12:56 +0800 [thread overview]
Message-ID: <a0cad1c0-f6dd-46f0-b9f3-f028d7dabe6e@linux.dev> (raw)
In-Reply-To: <20260320-thp_defrag-v1-2-6ab15d0d26eb@debian.org>
On 2026/3/21 00:05, Breno Leitao wrote:
> Replace the hardcoded if/else chain of test_bit() calls and string
> literals in defrag_show() with a loop over defrag_flags[] and
> defrag_mode_strings[] arrays introduced in the previous commit.
>
> This makes defrag_show() consistent with defrag_store() and eliminates
> the duplicated mode name strings.
>
> Signed-off-by: Breno Leitao <leitao@debian.org>
> ---
LGTM.
Tested-by: Lance Yang <lance.yang@linux.dev>
And also,
Reviewed-by: Lance Yang <lance.yang@linux.dev>
next prev parent reply other threads:[~2026-04-03 5:13 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-20 16:05 [PATCH 0/2] mm: huge_memory: clean up defrag sysfs with shared data tables Breno Leitao
2026-03-20 16:05 ` [PATCH 1/2] mm: huge_memory: use sysfs_match_string() in defrag_store() Breno Leitao
2026-04-02 8:21 ` David Hildenbrand (Arm)
2026-04-02 13:42 ` Breno Leitao
2026-04-02 13:45 ` David Hildenbrand (Arm)
2026-04-02 14:37 ` Breno Leitao
2026-04-03 5:09 ` Lance Yang
2026-04-03 6:46 ` Barry Song
2026-03-20 16:05 ` [PATCH 2/2] mm: huge_memory: refactor defrag_show() to use defrag_flags[] Breno Leitao
2026-04-02 8:24 ` David Hildenbrand (Arm)
2026-04-03 5:12 ` Lance Yang [this message]
2026-04-03 6:56 ` Barry Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a0cad1c0-f6dd-46f0-b9f3-f028d7dabe6e@linux.dev \
--to=lance.yang@linux.dev \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=baohua@kernel.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=david@kernel.org \
--cc=dev.jain@arm.com \
--cc=kernel-team@meta.com \
--cc=leitao@debian.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ljs@kernel.org \
--cc=npache@redhat.com \
--cc=ryan.roberts@arm.com \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox