From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB97DC4332F for ; Tue, 12 Dec 2023 18:02:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F047A6B030F; Tue, 12 Dec 2023 13:02:29 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E8D716B0312; Tue, 12 Dec 2023 13:02:29 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D2DAF6B0319; Tue, 12 Dec 2023 13:02:29 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id BE5D96B030F for ; Tue, 12 Dec 2023 13:02:29 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 70BF4120A10 for ; Tue, 12 Dec 2023 18:02:29 +0000 (UTC) X-FDA: 81558936018.10.1EE47AD Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by imf07.hostedemail.com (Postfix) with ESMTP id B078440032 for ; Tue, 12 Dec 2023 18:02:24 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=devkernel.io header.s=fm2 header.b=f+FUOvrr; dkim=pass header.d=messagingengine.com header.s=fm1 header.b=iu5dDUpU; dmarc=none; spf=pass (imf07.hostedemail.com: domain of shr@devkernel.io designates 66.111.4.29 as permitted sender) smtp.mailfrom=shr@devkernel.io ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1702404145; a=rsa-sha256; cv=none; b=ZmEudDYrzJV1nDIWnK3bN9Djc8wyjGYjZkURGAWjQHHhxWrd0tfYZIImC0T2zza86deQOU h6zBbqBWMOqc8rsOP69/w3zyW41DCVDZjBZULbm9HzLBRG88f0RrnGQlW+aADS8E2wWUn/ QJOtzl3gT3HzcnoSgbI8JurVpFnAQck= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=devkernel.io header.s=fm2 header.b=f+FUOvrr; dkim=pass header.d=messagingengine.com header.s=fm1 header.b=iu5dDUpU; dmarc=none; spf=pass (imf07.hostedemail.com: domain of shr@devkernel.io designates 66.111.4.29 as permitted sender) smtp.mailfrom=shr@devkernel.io ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1702404145; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=KEjNKWXCWFo0aaGshHfuAhiPFyNmIHyFQZWgfT5pa+Y=; b=wNCBnbFkrO/nqfVaxw9bb7Zwlfsfo5mtQGJGTy9COpaayoKHJ0rR2VSgGuHQHzJxXccgVV ZhZ+br4i/tRM90/uQ8flpXG+s5G5Zj/3hq2yT//Ui3eZlL3l/hL9klK6ZNyh6nSfY9A4et SpVTmpVpi3tqjjhF5e3Z5lJXUkP3fvc= Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 3DBEB5C0274; Tue, 12 Dec 2023 13:02:24 -0500 (EST) Received: from imap51 ([10.202.2.101]) by compute6.internal (MEProxy); Tue, 12 Dec 2023 13:02:24 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=devkernel.io; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm2; t=1702404144; x=1702490544; bh=KEjNKWXCWF o0aaGshHfuAhiPFyNmIHyFQZWgfT5pa+Y=; b=f+FUOvrrc9NOMQU1WECMkwiC8p +xCvP3zljcMza/GUnPpVMhQ2+bKL/PMYBxIj74NiXtLXyX2ZlisWjgVmF/tzZzoF byxoQ4B7LRtjPFZ8gKy90OXJa7BlIl3d3utJ+S7KvVBYYyOngFst4ZF26Pb5FYXB uWWAgjQeJjC5HZuCjwAJda9f4zd5Q27EuQlXULnW2nktrvsqtp9CYJ/eqkAB9b+8 nFdl3x01Ex1mUrt/1Tw5zbg46VKpl4OSuBA8FTQInaoOXX4LZW07cACR9uuqBq4U GQUH+CON2BxFUn4QQsNuXDgZ01waM/KlkzSPXmEyLQNLs/Fzs1gCslxS6uIA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1702404144; x=1702490544; bh=KEjNKWXCWFo0aaGshHfuAhiPFyNm IHyFQZWgfT5pa+Y=; b=iu5dDUpUhQT9PNPLgOcTfCFNzjKECP4fwZU+cZTd5VO1 c/XcKROxgn6U3UU1RIZUNatpN8eUECqMuO4Ebd8SubAABIMMvy/ommLaUVC7eFvW o46O+KiZzFuQwiVzBDnzIFMxjQjz596n8PcRsjPjJjm6UkUJb7sISKXmXAY23RO9 GmE9Fn0lrMYirll1fTOyaZTipJPBvvzwXcTBxHNsol5kwpvhHKbb5ga8WJtRi20u x/zM5HgD0HSEBic1eQooLZ34MkZVrTHrdKoBRyPzL+gybB8WL7jWRCqxhnXNviv5 Wn/NAOBnQ+/BVcBiLG72JmZAJVuUKHLLk9PPd24pIA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrudelgedguddthecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefofgggkfgjfhffhffvvefutgesthdtredtreertdenucfhrhhomhepfdfu thgvfhgrnhcutfhovghstghhfdcuoehshhhrseguvghvkhgvrhhnvghlrdhioheqnecugg ftrfgrthhtvghrnheplefgteffgfejtdelfeekgfetjefftdejgfdvudffiedtueevvdej gfevvdfgleetnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepshhhrhesuggvvhhkvghrnhgvlhdrihho X-ME-Proxy: Feedback-ID: i84614614:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id 80F88B6008D; Tue, 12 Dec 2023 13:02:22 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.9.0-alpha0-1283-g327e3ec917-fm-20231207.002-g327e3ec9 MIME-Version: 1.0 Message-Id: In-Reply-To: References: <20231204234906.1237478-1-shr@devkernel.io> <20231204234906.1237478-3-shr@devkernel.io> Date: Tue, 12 Dec 2023 10:02:02 -0800 From: "Stefan Roesch" To: "David Hildenbrand" , kernel-team@fb.com Cc: "Andrew Morton" , hannes@cmpxchg.org, riel@surriel.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v3 2/4] mm/ksm: add sysfs knobs for advisor Content-Type: text/plain X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: B078440032 X-Stat-Signature: mi1iqqojoqnuuxh17jn7wj7shbe1capr X-HE-Tag: 1702404144-65908 X-HE-Meta: U2FsdGVkX1/QyvJoQwEKNzkD0kPG+FnwqgkoUtY4e4PXnwqogRwkwsBVng+mS7fupn/nO8RfqifymQu0+XWoybZLIjMFoQpEzkQKEqdXNZgCj0nuDg+IDOQwHAK7DhBil5f9cOcMvYrLo3klXQZZ8jelSJKyVMG+iLTi5o6TUB8kD1GFdlzBrxh8D4eja5iF3WxefJPzwxg+mzPJK8iM4wfxNHIc00f8sWXYZbErgvXLcAtpkkgNIFQXPleBXeRuejfQT2lk1Vmxk2i51rz0YnX5DufZ8XWQD1GjSvCwfqLxSAQeroVTBy1hi0SWadujNWHPHwBgAsYMWJH5Id4fPPdRwKjSK3p7QPc38Dg2JgFHlLttXACBfsAT6DnPzJb3tsNw7IIAm+LzXzxWaO/M+ldEpwBLCcOx2soY3m3BLnsa7pgNyOSUbLvj+eYc19sPZrZ7xA7FHBZ7vNFMb8QNXVOV/cfF8KtM55LGuQKY1m/GuF4cjw/7SgOfSxxWJrEpIeryo5utwDZeCbD1NJHVuKfNZ3dFJP4JNvc+axC2E9exwAlvllfk63xh0/xX6vfKf7jRHZ4JuSHhgrdNZN/ATtj/2TdTu5GuOxUb6h0UpwWsoEwtOELxuy1wuyIzmg71MlM0pBzskg9IspjwJO6+/COp+yhxY5IWVFyaIu8KNFdXV7snC+ZWfuSG2ailIDHjcyX3ziGRhPdkBf0NMVPZGIVh9YPOptEfFZ37PJlh5kY8AnjsyRR64/3h8ibW2biShDSSSVeV9N0JMX+uEERHub39bK7r6+h0OSd8kAEbiglkdfS68mIoivEQBU0RD+KSLZ+eitM9r+w43OWnyv7pYkJ7nObI8GHUWKwpgJ8moK4PI9Dec5mZmHXF213K/VA9XhTb7wkLpRoO6XZMfILgaz364D6a/YXJz9jGGcXjFVLDnSjgRIwi0aD+BV6W40TYPGB9YRL7EmlAcJGUUed W8GFwbBD Lq3nsXS9tqzboux9G4B8F0eF8ZmCzGus9x4xq6/JnzR92gN8LTdnSUkQVoy+j8AP/L8dADrbmppTTtcAGCNjT3NA5T37N6QGj1peisEC3x7s+T6cYshp6dvP/2tDjTI+1VUHBp9HyCuz9M5QPR9Pf9aexf+zN6SiNt9Cp X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Dec 12, 2023, at 5:45 AM, David Hildenbrand wrote: > On 05.12.23 00:49, Stefan Roesch wrote: >> This adds four new knobs for the KSM advisor to influence its behaviour. >> >> The knobs are: >> - advisor_mode: >> none: no advisor (default) >> scan-time: scan time advisor >> - advisor_max_cpu: 70 (default, cpu usage percent) >> - advisor_min_pages: 500 (default) >> - advisor_max_pages: 30000 (default) >> - advisor_target_scan_time: 200 (default in seconds) >> >> The new values will take effect on the next scan round. >> >> Signed-off-by: Stefan Roesch >> --- >> mm/ksm.c | 127 +++++++++++++++++++++++++++++++++++++++++++++++++++++++ >> 1 file changed, 127 insertions(+) >> >> diff --git a/mm/ksm.c b/mm/ksm.c >> index b27010fa2e946..18b7185bbc65b 100644 >> --- a/mm/ksm.c >> +++ b/mm/ksm.c >> @@ -3735,6 +3735,128 @@ static ssize_t smart_scan_store(struct kobject *kobj, >> } >> KSM_ATTR(smart_scan); >> >> +static ssize_t advisor_mode_show(struct kobject *kobj, >> + struct kobj_attribute *attr, char *buf) >> +{ >> + const char *output; >> + >> + if (ksm_advisor == KSM_ADVISOR_NONE) >> + output = "[none] scan-time"; >> + else if (ksm_advisor == KSM_ADVISOR_SCAN_TIME) >> + output = "none [scan-time]"; >> + >> + return sysfs_emit(buf, "%s\n", output); >> +} >> + >> +static ssize_t advisor_mode_store(struct kobject *kobj, >> + struct kobj_attribute *attr, const char *buf, >> + size_t count) >> +{ >> + if (sysfs_streq("scan-time", buf)) >> + ksm_advisor = KSM_ADVISOR_SCAN_TIME; >> + else if (sysfs_streq("none", buf)) >> + ksm_advisor = KSM_ADVISOR_NONE; >> + else >> + return -EINVAL; >> + >> + /* Set advisor default values */ >> + init_advisor(); > > Is the "init_advisor()" really required? > The init_advisor is required for the following scenario: - advisor is used - advisor is turned off - pages_to_scan is used and run for some time - advisor is turned on again ==> Advisor would start with two high values for the first calculation >> + set_advisor_defaults(); > > That function should go to this patch. > > > I'll move it to this patch. I'll also look if I can should move init_advisor() to this patch. > -- > Cheers, > > David / dhildenb