From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id ADEB3C3DA6E for ; Wed, 10 Jan 2024 04:16:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2592E6B0093; Tue, 9 Jan 2024 23:16:16 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1E10A6B0099; Tue, 9 Jan 2024 23:16:16 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 05B946B009A; Tue, 9 Jan 2024 23:16:15 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id E40CC6B0093 for ; Tue, 9 Jan 2024 23:16:15 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id AA39C1602E8 for ; Wed, 10 Jan 2024 04:16:15 +0000 (UTC) X-FDA: 81662089110.07.9B82CEB Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2054.outbound.protection.outlook.com [40.107.223.54]) by imf18.hostedemail.com (Postfix) with ESMTP id 911FC1C0002 for ; Wed, 10 Jan 2024 04:16:12 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=r7CcTEbu; dmarc=pass (policy=reject) header.from=nvidia.com; spf=pass (imf18.hostedemail.com: domain of jhubbard@nvidia.com designates 40.107.223.54 as permitted sender) smtp.mailfrom=jhubbard@nvidia.com; arc=pass ("microsoft.com:s=arcselector9901:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1704860172; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=zqNDtwMHuYmiljc7pEzdvtPv3Fb89NksbVbEvjNbbLI=; b=FU115e1Ix0SE7lpGYQkAaK2ynACxotU9Yib7Eq3zW4H1U4anbol6SO6fakQA05xQQvERg0 DXYuFRfP4k1s7FL18/ubMNYBsj85LlLZSWa9zHqLPGmNyaER7Uk4a9kXvPQlO/g7n5Fg0p xRm/I83KdzPdDvkjhXqeTqAzwzau4yw= ARC-Authentication-Results: i=2; imf18.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=r7CcTEbu; dmarc=pass (policy=reject) header.from=nvidia.com; spf=pass (imf18.hostedemail.com: domain of jhubbard@nvidia.com designates 40.107.223.54 as permitted sender) smtp.mailfrom=jhubbard@nvidia.com; arc=pass ("microsoft.com:s=arcselector9901:i=1") ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1704860172; a=rsa-sha256; cv=pass; b=Y6RgUik09OakqsRIV0OQIcnw61eUIorzXiSWwszVPC1oSmTogdC+i1xhZC8LM8aI71RzG/ nSUngSeGN02eqGowTitTSY4V4J88bB8OoMAQuos+HkagR9M8xIAAs9yyXpRA1PmVARFvtQ Sny3PUWYcDs0Ldx1QOHriCI+0vlx6Go= ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Es/G5RQE8DMPK7WmtvQYWjzIKsrML1GnT5MOYm4qAvOO3VyWYUgAfDuIGLlxkVkqGiyZkq49P5kEI7Re+1HDf1SkeAGUwx0vl9v6FUoklcVZE/ztS3d1acm7UNRCAPKGqN1yGo3FrOSvb0eLSDRtt7tRrnDnUODmOXk1E9icG5Yh2MivZsuxosy9Af7Gcxn18Gp6qsfD0zOmcm3CIZEJ/xWc7TrUZ2UK9uQT/Phdp3ytRKclH+2iKrqBEO1VzieA6zpdHejkQgisHMlZ1iE5bLLdupA/CxddNRohBHgdGGsAVexpjWZyF+Yyg0i2G42eDgmijEFtU7EE5BBRvnFZ9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zqNDtwMHuYmiljc7pEzdvtPv3Fb89NksbVbEvjNbbLI=; b=GhG2x9azcQdqQloR8poGcgAReUlvIVEwUXIvGcB0/9KyJEjeFRe02wNRgCpJXWT9PMrFJhlkmRT1NteJPcJTejRgbYE/Vyp7IFCe+hVnW83BrembT+EI1c0queISzGBXWv6ay6nYG1cxRHbniRyv+/dJp3IWkFqxszQtwNtVtOE6j1RnqYllGtBNRKoARzliZIq2F5+Itaej5BZCvSc8Fm0slb290p40mZ90is1/Accj0FgdY05CiQ/wUV2tB19z27M67EHdOZANGok12804ZT4eC+QWMIoGBI8SrWCYj0iBkowfJbVskLXDmjf3pW7ghMC0uLIzeqOdB3qxgkFswg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=gmail.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zqNDtwMHuYmiljc7pEzdvtPv3Fb89NksbVbEvjNbbLI=; b=r7CcTEbuaAljHP6OSus8gDNrQc4YmDijOShEIopO0WHoWxmXQ47DHw44pQ5xh6DTdl71oldFE8V/oxousjGmeStp3SFom8n8qVEG29YcW1fUNCHCDr3SmmRwtAauxctrd/jtgzGY6FNkZyVMZ8FdGhLJ+htDPdgyziEU9GrGbJzEU4AaKcQaUOtsikgDC+9RG1b/2XRVmYubS1xU175DysWrrUCXp7ocqtrZbI+xHcTDPBsmucU9DAJQZFbBIZgIESN+J/0sUe+NPXoOtQCjquO1HNQvbhIGVBZ5ciesH4xMPPrGwYxsow5KJzJFUSJ8lDi8MGF7V2MB5qWrBT/Zpw== Received: from DM6PR13CA0043.namprd13.prod.outlook.com (2603:10b6:5:134::20) by SJ2PR12MB8873.namprd12.prod.outlook.com (2603:10b6:a03:53d::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7181.17; Wed, 10 Jan 2024 04:16:07 +0000 Received: from CY4PEPF0000EE3C.namprd03.prod.outlook.com (2603:10b6:5:134:cafe::1d) by DM6PR13CA0043.outlook.office365.com (2603:10b6:5:134::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7181.17 via Frontend Transport; Wed, 10 Jan 2024 04:16:07 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by CY4PEPF0000EE3C.mail.protection.outlook.com (10.167.242.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7181.14 via Frontend Transport; Wed, 10 Jan 2024 04:16:06 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Tue, 9 Jan 2024 20:15:54 -0800 Received: from [10.110.48.28] (10.126.230.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Tue, 9 Jan 2024 20:15:54 -0800 Message-ID: Date: Tue, 9 Jan 2024 20:15:54 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH v1] tools/mm: Add thpmaps script to dump THP usage info Content-Language: en-US To: Barry Song <21cnbao@gmail.com> CC: Ryan Roberts , Andrew Morton , Zenghui Yu , "Matthew Wilcox" , David Hildenbrand , "Kefeng Wang" , Zi Yan , Alistair Popple , References: <20240102153828.1002295-1-ryan.roberts@arm.com> <4e7445a0-acc9-487f-999f-a2b6d03d265e@nvidia.com> From: John Hubbard In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.126.230.35] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000EE3C:EE_|SJ2PR12MB8873:EE_ X-MS-Office365-Filtering-Correlation-Id: eb25a2c0-1bd3-460a-8e87-08dc1192de2b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: hxxZA9hyzT59iAYpgMMP42E0OJV+Vb/am2KT/Q+aZtbWLXmY63wi3GrxbHGD0GDmABNrRREmwuDvMgKtxTsNQ44B5qT/kUtFD3JYEzejCj3tnwgrQsQeQ9m7lYPqQ1kSmin9ZfvNIrf5n3iPkeMFvhffLLnj/mUK2pgKkeVvZT+Z9ww2ANowYfYVPtnEf+IZPSDvJyf/ccXzIKTWgNmb3nvUi1W8kZkEIMFQUkbLGp03ENmnCKp9PcowLOPID31KF2XZStzq2nlES63Yn10xILSeOGfxbU9IbVjLzvd5nTu0isWIN0Bk+nttjU2WsDkDgr1jvWwm1GOyNHo/C0xMl6WtJRx2foIMAsKOMkvDmwvlsmZGbwTjeY03FGMTqK+g029GFgzV+EeLE5gL6yKTxGuXghBWTheLm8d4/CSJn5fuDQsE/YpVfu9a//m0U7bm5xJd5cb6VxA6yDSk4WN5AHsdAIZ0Ny4WG0ErhiwiiaXqa5bPsZei4qNvkFCPM/m4QCejlcD9iyCO/snDJs5TwUCMDE+u/5CvPtL5BmAL3RtEG9OzRyeTvYHOXTmps5Mr/q/oWYNuMtp1zLO89X2d4dJ8onAnFCVhe/esiNFoli+0UpHNmE/R8cf+0NOMX8qy9C6TeimSASPg1Gl8yrjB0RRItTposu5Dq7b/bGLunYdi4CYh/6Bw9bUQDuyEOBUcMWWiVzD97YnzgMnkSUT8Jy1lWR0E4Ui4yQvElPpXwlIsaFep7mlGwoMOvnEXh3mqZXoA0XNEl7qjskM0txWN0g== X-Forefront-Antispam-Report: CIP:216.228.117.161;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge2.nvidia.com;CAT:NONE;SFS:(13230031)(4636009)(376002)(396003)(346002)(39860400002)(136003)(230922051799003)(451199024)(82310400011)(186009)(1800799012)(64100799003)(40470700004)(46966006)(36840700001)(47076005)(83380400001)(426003)(16526019)(336012)(40460700003)(40480700001)(2616005)(26005)(53546011)(478600001)(8936002)(8676002)(36756003)(70206006)(16576012)(4326008)(70586007)(316002)(6916009)(54906003)(31686004)(86362001)(356005)(82740400003)(36860700001)(31696002)(7636003)(5660300002)(2906002)(41300700001)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jan 2024 04:16:06.9125 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: eb25a2c0-1bd3-460a-8e87-08dc1192de2b X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.161];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000EE3C.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR12MB8873 X-Rspamd-Queue-Id: 911FC1C0002 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: k4minoqhrewzks56oc14y3sbfj4jw6pj X-HE-Tag: 1704860172-415829 X-HE-Meta: U2FsdGVkX18yc8HfC58URRIvsdwChQV76Uz7RTHAUeh8XUxVS9PyPjk8lxS7proENOlnhMw4ZyxSx2ngdNwyby9sgOcQ5HoFU4auompct3M+1wtqyT05q6n3MzbwvO5tNwI2Rk3dIH16LqSaJCVl82RckKx7ImTeGGjOuXN1zX+nrg8zkuFktXvFJx269m42tDXyyTIYaijPXQeXiw5KLbMzQ/06pi/mylVWapxce9EjK6LZYcfT02dLtZYIZN5WUIsL5Zra3b+ztirO0CS4LH+Tvu0KI/XSQTVMuUkr4FDU5Szr4PAyMr9KcqX3YJuiz+6CkgkXzRkqi3/9Y1+0xD+1PtrnB53ZPGh3oaWkZDCbWrgQMXPviC8kTBHg5/SERZkt0YKaj2MDDsT2VolRZYWksnP4xDtgG+fHx/BDFEGxmx+NPezZoIoRyq/PJMPLb3nbhVUuxHlg+86c/fYC5bkdK63xKC4JA5WNVdQMq7sU2JHAmpbmTwDsVe5B89YgyrU2iH/Z1MM/GkIs6+fDPXOXypA2rBF5mv4t/Y76UaL96TPgXkb49C0aBLnM6b19bAd4DgOaH0KTWlnCePMoK4wculHUk4KYFe49voPWazQxZo9P1R0J83atUW0xK4598Q2yHCmEZqqD5L7e5OqyBbRRi0Xk+AKj37W6mUsLlXtdzayWY7Bi8P/QEbuxgEQ0pNHv9+gzQ2qmW4XG50AtH/8IyFySORMaXBoaw7UfqwHyamTa9CgdkoK0VbQ1imKWaZTGeyoloGBBki2ykoo4pwHmeMas0UAngQYlIuqTs0aKl/PMBWt5ElL4YBFBklWLy5vvJQWRw/FSyoutp5Rx9qkdZxKuCqsyfkrZ7rsCdUBGx3DPu+Izp/AQbq8JG4d/VxwPHRGcecsRr0iU/5NBgZoB2KxQUUATUDJ6FidzLR3yvqUJn2BLqDABGClfnPPc2PP5TofwoKc/JpVr8MO eljh+txz 7hK0kVrSWdoqm8UnHftXWvxU0iULiaiSTFzaEx7OGz/zP/4TUmMiBPSawmQ6EDRRymDqvWwwDrjki8dbvX+/cM+4T/VVIeAlU8dn6Fp6wQYGKGmtx4HN4Rh227SYbDXfOtpjBQap9SH6qoY9lbt/lWIW+3wF2RTUBH/uV1CTKgoRVKb9x3bf26xy/W/v+z+QkTniYiMHjiCXEV8WM3ry19kxgDlSIiW3UXvMPpek+uqvZ8/O/rFiROGw3345x13ezU62MFPeDVa7tSvW9paUKGo4XiA9E0Q9p1baRGA7/AGa+wq18Hqa2N4Qdqe+cx8mgFzUdUOnWarLy5YLA1b2Y51qZixn94M7jrY+5hMNxTCFXn1jF6CQDxaoiUA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 1/9/24 19:51, Barry Song wrote: > On Wed, Jan 10, 2024 at 11:35 AM John Hubbard wrote: ... >> Hi Ryan, >> >> One thing that immediately came up during some recent testing of mTHP >> on arm64: the pid requirement is sometimes a little awkward. I'm running >> tests on a machine at a time for now, inside various containers and >> such, and it would be nice if there were an easy way to get some numbers >> for the mTHPs across the whole machine. >> >> I'm not sure if that changes anything about thpmaps here. Probably >> this is fine as-is. But I wanted to give some initial reactions from >> just some quick runs: the global state would be convenient. > > +1. but this seems to be impossible by scanning pagemap? > so may we add this statistics information in kernel just like > /proc/meminfo or a separate /proc/mthp_info? > Yes. From my perspective, it looks like the global stats are more useful initially, and the more detailed per-pid or per-cgroup stats are the next level of investigation. So feels odd to start with the more detailed stats. However, Ryan did clearly say, above, "In future we may wish to introduce stats directly into the kernel (e.g. smaps or similar)". And earlier he ran into some pushback on trying to set up /proc or /sys values because this is still such an early feature. I wonder if we could put the global stats in debugfs for now? That's specifically supposed to be a "we promise *not* to keep this ABI stable" location. thanks, -- John Hubbard NVIDIA