From: Rik van Riel <riel@surriel.com>
To: Josef Bacik <josef@toxicpanda.com>,
akpm@linux-foundation.org, linux-mm@kvack.org,
kernel-team@fb.com
Subject: Re: [PATCH] filemap: don't unlock null page in FGP_FOR_MMAP case
Date: Tue, 12 Mar 2019 17:08:50 -0400 [thread overview]
Message-ID: <a0bd108182aca3d41927819be09405e1d048a77b.camel@surriel.com> (raw)
In-Reply-To: <20190312201742.22935-1-josef@toxicpanda.com>
[-- Attachment #1: Type: text/plain, Size: 430 bytes --]
On Tue, 2019-03-12 at 16:17 -0400, Josef Bacik wrote:
> We noticed a panic happening in production with the filemap fault
> pages
> because we were unlocking a NULL page. If add_to_page_cache() fails
> then we'll have a NULL page, so fix this check to only unlock if we
> have a valid page.
>
> Signed-off-by: Josef Bacik <josef@toxicpanda.com>
Reviewed-by: Rik van Riel <riel@surriel.com>
--
All Rights Reversed.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2019-03-12 21:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-12 20:17 Josef Bacik
2019-03-12 21:06 ` Andrew Morton
2019-03-13 14:25 ` Josef Bacik
2019-03-12 21:08 ` Rik van Riel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a0bd108182aca3d41927819be09405e1d048a77b.camel@surriel.com \
--to=riel@surriel.com \
--cc=akpm@linux-foundation.org \
--cc=josef@toxicpanda.com \
--cc=kernel-team@fb.com \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox