From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C82A7C4167B for ; Fri, 8 Dec 2023 11:24:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6489D6B0078; Fri, 8 Dec 2023 06:24:21 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5F7326B007B; Fri, 8 Dec 2023 06:24:21 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4984F6B0080; Fri, 8 Dec 2023 06:24:21 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 329BD6B0078 for ; Fri, 8 Dec 2023 06:24:21 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 0011512019A for ; Fri, 8 Dec 2023 11:24:20 +0000 (UTC) X-FDA: 81543417522.14.E538588 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf18.hostedemail.com (Postfix) with ESMTP id 2F7691C0013 for ; Fri, 8 Dec 2023 11:24:16 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Ou8kQfLK; spf=pass (imf18.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1702034658; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=RCuVfiFWHDbXLNBhRFvIja18LVxlp+/90vRsS/RVFDc=; b=S1UiNCLFI/ZtgDJ7hVZqkU8bT6rT7TVR9HILoA6VQEUS+4SnklLS4zHcqts02VR2ntjGgx wuh6sjSDVOiAVIbMfViAADlGvHHw+4f2zLxpvbCQyctKAceRerOmmN2xzUhPxk+EDO7YCM jrOQTo/s74jliybD/21OwcMaGe7QTxQ= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Ou8kQfLK; spf=pass (imf18.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1702034658; a=rsa-sha256; cv=none; b=TBxk+/RCcaXPsNGom7rxg7J8o7CzNij+7VgkLsCJ1rwjmyDnqUGU1fzHtSx2JVYMohZCXG hwCBKGLvLTCk7w2O39M6j2OaPj88pRHUS3rrTR2bzm0aHYJ2xw+G+NpA7U05JO1dbiSpQ3 2HT+NbKV8p/qlC6bbWWQOpJcUVtOFRc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1702034656; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=RCuVfiFWHDbXLNBhRFvIja18LVxlp+/90vRsS/RVFDc=; b=Ou8kQfLKMr/v3xDfzZ0iZf4axcr21Fwhb2EmAUnVk3tdLiMvk4ZK6dO15H1ezauD7/z/Um 6DLfmtzm3kgNP2ERe+ISXIBlNG7yqH+iig80INqUgiutFz8f2+bHVRRUCAQ3AO++VdAfJn r3tq2fH+juWDbZ7VfxZo18tpID7u4LQ= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-74-PfjjPmUkNGWZiti3UWMQ0w-1; Fri, 08 Dec 2023 06:24:15 -0500 X-MC-Unique: PfjjPmUkNGWZiti3UWMQ0w-1 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-40b554730c5so14172615e9.0 for ; Fri, 08 Dec 2023 03:24:15 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702034654; x=1702639454; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=RCuVfiFWHDbXLNBhRFvIja18LVxlp+/90vRsS/RVFDc=; b=AmUs8ApGfxE3vAlV31RXGrkq/Q6SB8P+f44XDqiqFs64YOlSfITSl+c6RopRlalUM/ gsujjZZ828F6MvL6QosXK29IhtxJrWILIRdY3QmniWXvTvU4bbzwJzjO1yUue+KJ5WyP CPc7xMFLjjpgbm7H9PwBVb6TqKA7Fdpgkbt/AG/VgsjGOT+GRSGsCKzGQPQfEKOz5uue /iwpdb29Izr8xS30vQTTL64/Sq3B98npi3nbudd9JgcubgYA+ZIXLTUwL/eusXnUm4Gy iGO90Dskze6KmhOY/tn205lqqmGFTGVlClez9Hfp1gnold647Smuekd2ksBzHg9RCky4 hrbw== X-Gm-Message-State: AOJu0YzRXOZTaipWtEjTtAZQW50afMQUeHqDruULxEuZIqtmpPwYsXqR DxLDx3o8jXUijCvi2avtqqXC+zn63EWfAkvINFAkqdK2JiSvtCsVJQ2HkzCzaj8Y49cJCjWLXjc X/2PjhXvoNCo= X-Received: by 2002:a05:600c:354f:b0:401:bd2e:49fc with SMTP id i15-20020a05600c354f00b00401bd2e49fcmr2276355wmq.24.1702034654022; Fri, 08 Dec 2023 03:24:14 -0800 (PST) X-Google-Smtp-Source: AGHT+IFaPAfp15vPF4zwc3FxsV1ECm67uHlRyckS5h6TG1jm03XXMYbkyf487B7AwrqHjAP2WsWlQQ== X-Received: by 2002:a05:600c:354f:b0:401:bd2e:49fc with SMTP id i15-20020a05600c354f00b00401bd2e49fcmr2276347wmq.24.1702034653621; Fri, 08 Dec 2023 03:24:13 -0800 (PST) Received: from ?IPV6:2003:cb:c724:2100:3826:4f41:d72c:dc1b? (p200300cbc724210038264f41d72cdc1b.dip0.t-ipconnect.de. [2003:cb:c724:2100:3826:4f41:d72c:dc1b]) by smtp.gmail.com with ESMTPSA id i6-20020a5d55c6000000b0033340aa3de2sm1822647wrw.14.2023.12.08.03.24.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 08 Dec 2023 03:24:13 -0800 (PST) Message-ID: Date: Fri, 8 Dec 2023 12:24:11 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC 00/39] mm/rmap: interface overhaul To: Ryan Roberts , linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, Andrew Morton , "Matthew Wilcox (Oracle)" , Hugh Dickins , Yin Fengwei , Mike Kravetz , Muchun Song , Peter Xu , "Yin, Fengwei" References: <20231204142146.91437-1-david@redhat.com> <993ea322-8cdb-4ab1-84d3-0a1cb40049c9@arm.com> <067753e4-faf0-4bc0-9703-ec97b7de705e@redhat.com> <1ba5dd86-a201-4243-bab0-349395468236@arm.com> <537ac106-e4f6-4845-aa09-29b775269562@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 2F7691C0013 X-Rspam-User: X-Stat-Signature: wjquhutcomdrntuyw98m3cbczpqskw1b X-Rspamd-Server: rspam01 X-HE-Tag: 1702034656-788859 X-HE-Meta: U2FsdGVkX19HA8afsKNcFZQhX1/REzNFElg2aZ2h1JRtytFQdsnOosfuqRfl/DWXONbj6aZRhWWH3TElmSH995b5BwGn5mpd/gCQKVLEgfPY5aBtepsnYeMMnBwpXgkj2gM3KXj4UW+zMa/0cwhMCA8GQNNKlJa3WycSSCmn1UDH8eUaGSQp1JekjfH5oAQHLLEwpfcOQNy2QQqibimDCTI+fW3/eNWTXHEAZGKnAfk2KWmTybwHEqPaKaC++qUC2E/zvBo6BuKDJa6gMaOESvGn/HBhn22v/u7xfsSIR40G2Ghwi96K5CvzKN/Ss8dK60QF73w66zu+PZ2/UIgXLraDiaGaZJFs3uWWLNKSbFBowrckKNaHSdIZdOkgnh9Neb05Pja5Wdjbh2xgi3+tmY0wtGkqVSS4t7WgM6KUriP+w4Ay4OTCqsRxt0TyH7XwLrPRCfwXz7ZH8Mvi1tXaBO2ScYEpB98i/xaU3jpOs9gjPGiiu+aiWKQHo0dKbgv3jKbnPctiWKC35dbynirQPCeMm3IVjXyB8kbeRSPGI++ZjVyMb0IbOR4rjeeZ4U+Z7m3xo90d+5jlaEbSPhwUGYwzcjHziF9Q/ZVPvQ/Nc631dIbFRRt+Wnh0n6dxudAGAJWKt6jko1XE7kUDYza7eGlS8onbhr5nbpQrG5/rtacACr5H0kwOv1JVd3OxcdoLeUc860IyDDE9wsGiLParpyxf9GHkA1pPnSZRyzq+zpWe2IwSaMyQdY3dPgllAoIQsVJyI/4Q7F5hNqmHl/Fk4QQaUqyTnThf06WF4naQB/ISCrCL/kY2Lzyqx0TwVx5VZnsusl1X0CA8AxlZOlrSKOpTv3Vqj4SQbDJDT832ZaZzUvmK5jI9eKV14lNaRYsXqpgt67dJWi3notG6EOxnot6SzYL0SdYtZNxeZqQB17XSHu2XlrU5eq/1fmOcRToKje+t+urHbRtQLp86ZqE DIH5PmFn uMXTKCdRffGO8kjEFUI3NG0dpBX1VH7aWgMyRA+xZ2wrFPDKptT9cgU40NBR+9XMydT4N15mQuY5qNDmMv4Svo2uiysPjqja8VCAOnvaMZ97RU52EbOawjDnS3Cwb7Eb4Xrw+VA1GndOeG3ed6ShrAulHu7hZS3vawSWd9VS7c9TzyjuwMVKUZWh2UgbsIFrw/fbNY5Jwis/z1JLqYs1yMZfcoxofbOP4pD/VzReS9AZRf8NmHZhO2BKU87CErpOqPUeWXRYx3RJIPLhAOYy/fGvfslZutQkDrwpHuL3Lr8OcT7Th4/JTVfd4zY1mv4TH46rfiP+w+HF2fm4hlxWZqH8fN3Ia3VaFP2GeWxzhECQfurmNl0DyaYQO2vhJm36ky04fNKTSWXcSyQM/FUlIEEQbtlyh/pHkRDhJkI0Qz7LzyeQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 05.12.23 14:49, Ryan Roberts wrote: > On 05/12/2023 13:39, David Hildenbrand wrote: >> On 05.12.23 14:31, Ryan Roberts wrote: >>> On 05/12/2023 09:56, David Hildenbrand wrote: >>>>>> >>>>>> Ryan has series where we would make use of folio_remove_rmap_ptes() [1] >>>>>> -- he carries his own batching variant right now -- and >>>>>> folio_try_dup_anon_rmap_ptes()/folio_dup_file_rmap_ptes() [2]. >>>>> >>>>> Note that the contpte series at [2] has a new patch in v3 (patch 2), which >>>>> could >>>>> benefit from folio_remove_rmap_ptes() or equivalent. My plan was to revive [1] >>>>> on top of [2] once it is merged. >>>>> >>>>>> >>>>>> There is some overlap with both series (and some other work, like >>>>>> multi-size THP [3]), so that will need some coordination, and likely a >>>>>> stepwise inclusion. >>>>> >>>>> Selfishly, I'd really like to get my stuff merged as soon as there is no >>>>> technical reason not to. I'd prefer not to add this as a dependency if we can >>>>> help it. >>>> >>>> It's easy to rework either series on top of each other. The mTHP series has >>>> highest priority, >>>> no question, that will go in first. >>> >>> Music to my ears! It would be great to either get a reviewed-by or feedback on >>> why not, for the key 2 patches in that series (3 & 4) and also your opinion on >>> whether we need to wait for compaction to land (see cover letter). It would be >>> great to get this into linux-next ASAP IMHO. >> >> On it :) >> >>> >>>> >>>> Regarding the contpte, I think it needs more work. Especially, as raised, to not >>>> degrade >>>> order-0 performance. Maybe we won't make the next merge window (and you already >>>> predicated >>>> that in some cover letter :P ). Let's see. >>> >>> Yeah that's ok. I'll do the work to fix the order-0 perf. And also do the same >>> for patch 2 in that series - would also be really helpful if you had a chance to >>> look at patch 2 - its new for v3. >> >> I only skimmed over it, but it seems to go into the direction we'll need. >> Keeping order-0 performance unharmed should have highest priority. Hopefully my >> microbenchmarks are helpful. > > Yes absolutely - are you able to share them?? > >> >>> >>>> >>>> But again, the conflicts are all trivial, so I'll happily rebase on top of >>>> whatever is >>>> in mm-unstable. Or move the relevant rework to the front so you can just carry >>>> them/base on them. (the batched variants for dup do make the contpte code much >>>> easier) >>> >>> So perhaps we should aim for mTHP, then this, then contpte last, benefiting from >>> the batching. >> >> Yeah. And again, I don't care too much if I have to rebase on top of your work >> if this here takes longer. It's all a fairly trivial conversion. >> >>>> >>>> [...] >>>> >>>>>> >>>>>> >>>>>> New (extended) hugetlb interface that operate on entire folio: >>>>>>    * hugetlb_add_new_anon_rmap() -> Already existed >>>>>>    * hugetlb_add_anon_rmap() -> Already existed >>>>>>    * hugetlb_try_dup_anon_rmap() >>>>>>    * hugetlb_try_share_anon_rmap() >>>>>>    * hugetlb_add_file_rmap() >>>>>>    * hugetlb_remove_rmap() >>>>>> >>>>>> New "ordinary" interface for small folios / THP:: >>>>>>    * folio_add_new_anon_rmap() -> Already existed >>>>>>    * folio_add_anon_rmap_[pte|ptes|pmd]() >>>>>>    * folio_try_dup_anon_rmap_[pte|ptes|pmd]() >>>>>>    * folio_try_share_anon_rmap_[pte|pmd]() >>>>>>    * folio_add_file_rmap_[pte|ptes|pmd]() >>>>>>    * folio_dup_file_rmap_[pte|ptes|pmd]() >>>>>>    * folio_remove_rmap_[pte|ptes|pmd]() >>>>> >>>>> I'm not sure if there are official guidelines, but personally if we are >>>>> reworking the API, I'd take the opportunity to move "rmap" to the front of the >>>>> name, rather than having it burried in the middle as it is for some of these: >>>>> >>>>> rmap_hugetlb_*() >>>>> >>>>> rmap_folio_*() >>>> >>>> No strong opinion. But we might want slightly different names then. For example, >>>> it's "bio_add_folio" and not "bio_folio_add": >>>> >>>> >>>> rmap_add_new_anon_hugetlb() >>>> rmap_add_anon_hugetlb() >>>> ... >>>> rmap_remove_hugetlb() >>>> >>>> >>>> rmap_add_new_anon_folio() >>>> rmap_add_anon_folio_[pte|ptes|pmd]() >>>> ... >>>> rmap_dup_file_folio_[pte|ptes|pmd]() >>>> rmap_remove_folio_[pte|ptes|pmd]() >>>> >>>> Thoughts? >>> >>> Having now reviewed your series, I have a less strong opinion, perhaps it's >>> actually best with your original names; "folio" is actually the subject after >>> all; it's the thing being operated on. So far I sticked to the original names used in this RFC. I'm testing a new series that is based on current mm/unstable (especially, mTHP) and contains all changes discussed here. If I don't here anything else, I'll send that out as v1 on Monday. Thanks! -- Cheers, David / dhildenb