From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B986FC61DA4 for ; Wed, 15 Mar 2023 14:51:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 59D876B0074; Wed, 15 Mar 2023 10:51:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 54C3A6B0075; Wed, 15 Mar 2023 10:51:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4145D6B0078; Wed, 15 Mar 2023 10:51:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 2FF9E6B0074 for ; Wed, 15 Mar 2023 10:51:43 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id E4EB5A08EA for ; Wed, 15 Mar 2023 14:51:42 +0000 (UTC) X-FDA: 80571421644.19.3676EA1 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf09.hostedemail.com (Postfix) with ESMTP id C365E14001D for ; Wed, 15 Mar 2023 14:51:40 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=hhtriCNr; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=3KraaO6g; spf=pass (imf09.hostedemail.com: domain of hare@suse.de designates 195.135.220.28 as permitted sender) smtp.mailfrom=hare@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678891901; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7zN92RATXHClyStOM+d5V8uZWcn/TnTw/Njd/6C4epA=; b=E5dVpKxT4WkGs7mqyfMCY6args34ISIL0dJpkvWDf2D3cre7ojrDbzJM4H8PHJDtSsmplU BtZnCPHj8qXMtwo15UGljhGfxQpJSyZberl2tcMRtawlOMeki5uPUf6e+krCctgnrPTJPe LnHbGV5XjTBcibAWvlr9MsGx+Vvtz90= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=hhtriCNr; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=3KraaO6g; spf=pass (imf09.hostedemail.com: domain of hare@suse.de designates 195.135.220.28 as permitted sender) smtp.mailfrom=hare@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678891901; a=rsa-sha256; cv=none; b=kvr3YcowHLub7MEBrIfvwZ9/cITfjM0hNH03rJwx9b+zrF5XfKcfYctEa5fu+om95c+4M9 PgjisrX628E6mKso0ZxyPgu1y0+TzxGVtNRPmVfCWDiYdF5NUw1dcxYAI8HCwCvz6SRT8r Al9UfbihAG4SmEZUyzahlnnd//6kNY0= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 3FED4219B2; Wed, 15 Mar 2023 14:51:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1678891899; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7zN92RATXHClyStOM+d5V8uZWcn/TnTw/Njd/6C4epA=; b=hhtriCNraBCnTfLEs3tdlL0KY8e9/UGeNlNxe/Rzcn3Y2wQmJl9Zhfw5kwz764TkjVZIW2 KBz3ViihppZ1vOiOUmS5GlzcZenc7ZpupP8OI+HTM18Nl7XfjBx56GNBl6xwuBsEqznvbA VHxg/JEM6yX5nHOsXcypLNLjzgNRrQA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1678891899; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7zN92RATXHClyStOM+d5V8uZWcn/TnTw/Njd/6C4epA=; b=3KraaO6gycZxDWk83e+AXp9e/HO+t+93D+tFnY0MOiGFNcA9jaDsWN//mFB/SY6YL1PVTy p4ffaRKzuVcYxbAg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 682FD13A00; Wed, 15 Mar 2023 14:51:38 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id cp2tFXrbEWTpVQAAMHmgww (envelope-from ); Wed, 15 Mar 2023 14:51:38 +0000 Message-ID: Date: Wed, 15 Mar 2023 15:51:37 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [RFC PATCH 1/3] filemap: convert page_endio to folio_endio Content-Language: en-US To: Pankaj Raghav , hubcap@omnibond.com, senozhatsky@chromium.org, martin@omnibond.com, willy@infradead.org, minchan@kernel.org, viro@zeniv.linux.org.uk, brauner@kernel.org, axboe@kernel.dk, akpm@linux-foundation.org Cc: linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, gost.dev@samsung.com, mcgrof@kernel.org, devel@lists.orangefs.org References: <20230315123233.121593-1-p.raghav@samsung.com> <20230315123233.121593-2-p.raghav@samsung.com> From: Hannes Reinecke In-Reply-To: <20230315123233.121593-2-p.raghav@samsung.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: C365E14001D X-Stat-Signature: 7b8rwubz69i14bt93xzatbmdz7wckb99 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1678891900-991636 X-HE-Meta: U2FsdGVkX1/GEaT4wEQwnHvg1Tl2eRDTOX78atXA6GKMT59JFUgW3O6ryrCqfNyzJ8nTBMgTc05rf872beFZ8SmDeH7oi2SEomtUmMsbwpguVI+EFK6HaefHph+3ZZboQNsfy8sxo2JC9uWP03Om/p1Vt10s3DjO1jlqeZ5GWNzmHV9STnostPK13xN8WrVV8VmOBUDDl+FitPvapsTuhCHmyedovGTfrhm66bf1Fq836tv1fQFq2U7jUQ8U8hpfRJ9qbyRwYT2HpYVQNq72LL3UbOE7invHs2P+WLr0qFvniV+rId8YAL4B0H1EElFXV8GnJLAGBGyWxpSkl6ONnFdogkpScNJljzxeFDzW2GEsC4PCibuNpyCjd5d65cw8deeNfNBSiMc30ah/c8QgNRr31roqmO6qkkYnx38uNWMHAUMLUxQSw+0Yrjll00ybtr2wlrsAFc2ZdPGYdDMFAfIvFVWad3tXzOYovdJL6eq81oUGOjzSyRUpx9oY+LkCbz/bDjAXN/Pl0gH/eDva6LiEJK7rKZ8SAM/tKiXUb0Hdw8nBnLiuEo6bFmpBLY8K+8/4Re4/KAGSmlhuFuN+cjX1H5u05g1u8BdzIPizzU4/F+HBBZSxF+ZYCW7kltMKtYnnSDguyfKr7+U/eyOFMHSFawjlHlyaFSZ5RzmXRO/1HWspqwWi2yP2UtYRHYZY8Kvu2oQ1MGWek2xmQ/3hpF7GQp4X0aW3R3iTvfcUbGMjNYpxcL/RKEbqcnSj48109HSJNozIZIVa4S8gEwKKy9xvmyWM7hplKSY2rVmW9YGF7LRzHCpuuVDhbg5zjxgWNPFpoXP8BCL0HZrmm0knMwZlSy3DRpKKywnK+k6Jy6bApGut2N7VmqVXubdMXFYLtGCCEveRq+uj9KCvUzpCvKpDbrrYmzoDZLqLIxhg/NQIzq8+oUYwk0si8HGuRvAUz3ikkKEsT/z+a+e7+j/ 9c+YQzXG 1u2jzSb62mlzuDF2MKj5fVLe6sk1enR4T00goxulmuzjsh+iw6HTogBR0eaiJQXNWZ4OM6C9rvBoBgdFFBawZ7sspNGRQuME0N9MhUoX4Hu3SRH9O4PJjNDh/ZH5qC4GqvE+G+RKYDlkEjHPqVciCCE1VQDYDBm77V1rbfMTItOPo/Ueir4jJZu8Bhrwre5taEtDnfuETIHD4S/W+MgGdWTkY4cnuKNIjVgmlitn/1ARlNErrOUQCZECUieZ1J02ZVbAiUhHEc6UjjwD0dXDTRV1nQjdiXRg1mqmHTUQyMrVbVGfY4ynFRyIGZQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 3/15/23 13:32, Pankaj Raghav wrote: > page_endio() already works on folios by converting a page in to a folio as > the first step. Convert page_endio to folio_endio by taking a folio as the > first parameter. > > Instead of doing a page to folio conversion in the page_endio() > function, the consumers of this API do this conversion and call the > folio_endio() function in this patch. > The following patches will convert the consumers of this API to use native > folio functions to pass to folio_endio(). > > Signed-off-by: Pankaj Raghav > --- > drivers/block/zram/zram_drv.c | 2 +- > fs/mpage.c | 2 +- > fs/orangefs/inode.c | 2 +- > include/linux/pagemap.h | 2 +- > mm/filemap.c | 8 +++----- > 5 files changed, 7 insertions(+), 9 deletions(-) > > diff --git a/drivers/block/zram/zram_drv.c b/drivers/block/zram/zram_drv.c > index aa490da3cef2..f441251c9138 100644 > --- a/drivers/block/zram/zram_drv.c > +++ b/drivers/block/zram/zram_drv.c > @@ -610,7 +610,7 @@ static void zram_page_end_io(struct bio *bio) > { > struct page *page = bio_first_page_all(bio); > > - page_endio(page, op_is_write(bio_op(bio)), > + folio_endio(page_folio(page), op_is_write(bio_op(bio)), > blk_status_to_errno(bio->bi_status)); > bio_put(bio); > } > diff --git a/fs/mpage.c b/fs/mpage.c > index 22b9de5ddd68..40e86e839e77 100644 > --- a/fs/mpage.c > +++ b/fs/mpage.c > @@ -50,7 +50,7 @@ static void mpage_end_io(struct bio *bio) > > bio_for_each_segment_all(bv, bio, iter_all) { > struct page *page = bv->bv_page; > - page_endio(page, bio_op(bio), > + folio_endio(page_folio(page), bio_op(bio), > blk_status_to_errno(bio->bi_status)); > } > Can't this be converted to use 'bio_for_each_folio_all()' instead of bio_for_each_segment_all()? Cheers, Hannes