From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B36DAEE499F for ; Wed, 11 Sep 2024 12:36:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 39CB3940030; Wed, 11 Sep 2024 08:36:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 34B7E940021; Wed, 11 Sep 2024 08:36:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1C579940030; Wed, 11 Sep 2024 08:36:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id EBCDF940021 for ; Wed, 11 Sep 2024 08:36:31 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 5ABEF1617E7 for ; Wed, 11 Sep 2024 12:36:31 +0000 (UTC) X-FDA: 82552405782.23.795C8EF Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf10.hostedemail.com (Postfix) with ESMTP id 270EAC0002 for ; Wed, 11 Sep 2024 12:36:29 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=iC020y9M; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf10.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1726058104; a=rsa-sha256; cv=none; b=QOqH2yhXH7BL5d02VcdZIYLOUAizS1CaKrnNBB7wEr9Lzug2BJpdSA3rJw/cjr2Ca00YIy +RsfpzukX+N54m8Aa2P2rTsy1ySIPpKVw/4cixaHo0ruCNc1SmkbdLT1Uxo1LCMXrsQ3Fn 56Bc+q4edd5oZ2vUKkJHupOrBGRjh90= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=iC020y9M; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf10.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1726058104; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=soY97vB1T+EQhAcbnY7ctp4CFdxOH/BAwVpD1gxBgB8=; b=U5wVAMMjWua8ssy4+QHXoMLoGNtPNxyOffLBfQtr5jMxwOAqcTBN1qUyjWl5uSOrEV4eBM GFzpoLpnHeHAsBbKk8JPmswdlBOalLJlKOeM/X/PQlFFF6FxZu35XsvegxuV5qLjbpCC5S MmpRErsS2Ma2zWCl21FzPUKdO7Ov9vY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1726058188; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=soY97vB1T+EQhAcbnY7ctp4CFdxOH/BAwVpD1gxBgB8=; b=iC020y9MGmBRNEFlYyyX3sTNZA7YFGXxI0L3GzKvrLTgMdKRv0Y4DYV0hefQeI39HixJF4 U2OechSXKourigmBZd772gYxo5h4df8TYWsehpcVXJjVmq9dvrQ1c9Rh/to/D2qFqU/zxC ZAahTEXn2VbAQfs4FvwClzpSw46bMiQ= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-455-tQsKrbUgPgWkFFvfYg_efw-1; Wed, 11 Sep 2024 08:36:27 -0400 X-MC-Unique: tQsKrbUgPgWkFFvfYg_efw-1 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-377a26a5684so3101925f8f.0 for ; Wed, 11 Sep 2024 05:36:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726058185; x=1726662985; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=soY97vB1T+EQhAcbnY7ctp4CFdxOH/BAwVpD1gxBgB8=; b=HxsVWZVP5Jag4ECkpJauVHcWifkZhAil+BAC7XZGiqULmsg0LRikANnG2IVWwnwpP5 k/mQbP6hQpJ75v0aXeRvblYbWYS8sKHRPDc8Lw7X2igr7bUlCzHEYbrgsvrhASuVvwwM J2V7h2C3vh44c0BRYUzEulUTrNJp370ivOrw5lUMvlRM73t7mGdhd4ZjFLM6yKwbuVUR 0JfZ8oyzz1V0NiUbVVBvkb0HuYnNahfyXkZIBSFuMf33G9MjWA5wkA1/nuU8Fbo0rKgt osshz1rzVi8xq39T7ZpkNtvtjGp5FpCVGo95c/QaV8+zZ0xgdnNDDvQSdHTm7cehae4o K2qQ== X-Forwarded-Encrypted: i=1; AJvYcCUXaNKAinL91fdobdLng1hyPz1rRemJlvclOpYoFqHEQl/BKe3CjgTO3rRp2vOErX00VbrfDuqcDA==@kvack.org X-Gm-Message-State: AOJu0YwaQk66lVeGKgifYukIXlKtY2yYf79gEobrDF8pNSIuihEfYzOP jsJz/tHt3FInEIUrvaQWENjrTsvx+fRP9V1yBbt1OV9OFXG/oIbKax0QSZgz23PccTq7FFeydSG wxNzyALwp24J7j3dsexaDgP//q6Aw/T4YmhyhmwmdB3cDuA2q X-Received: by 2002:a5d:6212:0:b0:368:31c7:19dd with SMTP id ffacd0b85a97d-378895b79e0mr11674152f8f.5.1726058185174; Wed, 11 Sep 2024 05:36:25 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHBdLnQ/OyBRIrSAY9ow4pHwnVRbMCnkH0wVZ+vTA2ZeKNB0dHL0bpG9yXqFoeKd7Be4plXew== X-Received: by 2002:a5d:6212:0:b0:368:31c7:19dd with SMTP id ffacd0b85a97d-378895b79e0mr11674112f8f.5.1726058184634; Wed, 11 Sep 2024 05:36:24 -0700 (PDT) Received: from ?IPV6:2003:cb:c700:7e00:c672:608:5b3e:df8c? (p200300cbc7007e00c67206085b3edf8c.dip0.t-ipconnect.de. [2003:cb:c700:7e00:c672:608:5b3e:df8c]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-378956d3941sm11514826f8f.84.2024.09.11.05.36.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 11 Sep 2024 05:36:24 -0700 (PDT) Message-ID: Date: Wed, 11 Sep 2024 14:36:22 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 2/2] mm: Allocate THP on hugezeropage wp-fault To: Dev Jain , akpm@linux-foundation.org, willy@infradead.org, kirill.shutemov@linux.intel.com Cc: ryan.roberts@arm.com, anshuman.khandual@arm.com, catalin.marinas@arm.com, cl@gentwo.org, vbabka@suse.cz, mhocko@suse.com, apopple@nvidia.com, dave.hansen@linux.intel.com, will@kernel.org, baohua@kernel.org, jack@suse.cz, mark.rutland@arm.com, hughd@google.com, aneesh.kumar@kernel.org, yang@os.amperecomputing.com, peterx@redhat.com, ioworker0@gmail.com, jglisse@google.com, wangkefeng.wang@huawei.com, ziy@nvidia.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org References: <20240911065600.1002644-1-dev.jain@arm.com> <20240911065600.1002644-3-dev.jain@arm.com> <783a0d91-2910-4446-a979-c681dde402ec@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 270EAC0002 X-Stat-Signature: 8dh15j6hm4pmipbau3r7ozw3bshnw88u X-Rspam-User: X-HE-Tag: 1726058189-228939 X-HE-Meta: U2FsdGVkX1/MrEVTLhDf3Dpp4khENZC2/je+tVze7b49TV1RMdIN49fbKCjkwKdw5JzuNujYCeex3dwJsIrVBaeoVjCI8hWS0ncZw1gRAtMrKb47jFnglGs8bcw24vc7lZpkLZPPhoQ9BlpHW8VT70uGAIcl7LnOVIApCRfMEIjMq54/N3Cv5mx9GvPOMENQ5K9x5eEWfGZvxj7u153faHiSXOjPaNJS37ssui9JD+GNCtFKWoMOUSxa0ZOgp8D99IlPZWCDZmemHAZT+eZCaD6qtWDg2Ir7FNcSlT7z97hRD9zk5Zs1AslzqWFL8gDnWmurbVovX8flaQVMW0LXjQ8MzUiA+f97pMyAheUbBMQ4HlwwoW8HU6i3La9irPLn/vthWQedAKvecxbMVEAGAcJ54e90i7EruVFZwts1IVlk7bHmKJdKTnvlHcbfXuuSIdE7fWrsKzg3mEebwhd11ALSfKbcwv+gCA0qlVLc1XyKv9wexRtY5Xg5VeU4vwQ/UcOtkU7N+VUpovf2WJp5P/V+TSWMQfCi3wY0vDxF0m6dNoe1MpMErsM0AVL3KtHScV+iH/RhXfZOXJpytgjTfudmg0bJMEXTTSFNWXlUqkhX+iTotwJZ+nizDsHir0gl+fTnl3wETfT+JYcs4csgVVkcYNDIGmMvdrTrln6smAMLuozJM7Gk639c2Rw9Fb628e9IodnJPtuYqP7nxtC74bXixxLrLhGV0OUsLoyL5VVQNx5KFQEN/hPY6ofjWK2RTiqWBccj93wFuSUWYbc3ppKkZhp7zxcD9qJ9pzCV8yIzIIRlgbjFDhtq6U/CnxBmuzQ24XJNvSn8MByWFYzmeZAWOMhk3rtMn3+xaSac8/NfASj9TK4HgSRidBjxvbXAXiabJcw4Ib98Glz7q7tb+Ixg+/bo22oG2+IQGxDyjKa6b23fo2ArO8oECWsMRa8VpKjT1X9HmRqwHobvIG3 du8/Hly4 6keWSZc0MO+HZU+YFE/GCcDEWQRLJP98noX6uklIzwpcmwrj4P8RE1BTLGwjZXE/eQvKpxgLXEiUzEdxgJ+jmiCrpSB2FwxLRwiHHjUGDOXQP+n114VGUTAzmXoDneMgI+txWVtkIRCGoUCkJ8mCnZLfsoAf7dyrdbVDYcf8WmzCzIKWxZKulYcx6HS42c9YOI+K61kEFNlxU9BpTbdLLwEfw7ShNoxzqOky0O3sOtQJ8hYcaNZTop7LCGtvIgFO879dbWj4p2q+4cf1fcbJMmugwvigwPv6lQ2h5+v9hGOpwoKKECiKDwTjcgP4MK6QGnMZOm6Ncj/uJsEk6Uv7im+U3e9K0KCMl1+FbN9C2YM2FmGsF+vwwFbXUREH8SIvQeTy9dRyaIkPEjvnMaW8Pj1rzxFFZ+1G+uEv/h904H/kg0PA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.001901, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: >> >>>   } >>>     static vm_fault_t __do_huge_pmd_anonymous_page(struct vm_fault *vmf) >>> @@ -1576,6 +1580,41 @@ void huge_pmd_set_accessed(struct vm_fault *vmf) >>>       spin_unlock(vmf->ptl); >>>   } >>>   +static vm_fault_t do_huge_zero_wp_pmd(struct vm_fault *vmf, >>> unsigned long haddr) >> >> Is there a need to pass in "haddr" if we have the vmf? > > Was passing it because it was getting used many times. But nowhere do vmf > and haddr get both passed in the codebase, so I'll drop it for > cleanliness and > consistency. Yes, the masking is very cheap. -- Cheers, David / dhildenb