From: David Hildenbrand <david@redhat.com>
To: Dev Jain <dev.jain@arm.com>,
akpm@linux-foundation.org, willy@infradead.org,
kirill.shutemov@linux.intel.com
Cc: ryan.roberts@arm.com, anshuman.khandual@arm.com,
catalin.marinas@arm.com, cl@gentwo.org, vbabka@suse.cz,
mhocko@suse.com, apopple@nvidia.com, dave.hansen@linux.intel.com,
will@kernel.org, baohua@kernel.org, jack@suse.cz,
mark.rutland@arm.com, hughd@google.com, aneesh.kumar@kernel.org,
yang@os.amperecomputing.com, peterx@redhat.com,
ioworker0@gmail.com, jglisse@google.com,
wangkefeng.wang@huawei.com, ziy@nvidia.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH v3 2/2] mm: Allocate THP on hugezeropage wp-fault
Date: Wed, 11 Sep 2024 14:36:22 +0200 [thread overview]
Message-ID: <a09336db-4405-4b24-8420-c3ae4a16f73c@redhat.com> (raw)
In-Reply-To: <e160b45b-7220-47d0-83a3-9403ffb85bbe@arm.com>
>>
>>> }
>>> static vm_fault_t __do_huge_pmd_anonymous_page(struct vm_fault *vmf)
>>> @@ -1576,6 +1580,41 @@ void huge_pmd_set_accessed(struct vm_fault *vmf)
>>> spin_unlock(vmf->ptl);
>>> }
>>> +static vm_fault_t do_huge_zero_wp_pmd(struct vm_fault *vmf,
>>> unsigned long haddr)
>>
>> Is there a need to pass in "haddr" if we have the vmf?
>
> Was passing it because it was getting used many times. But nowhere do vmf
> and haddr get both passed in the codebase, so I'll drop it for
> cleanliness and
> consistency.
Yes, the masking is very cheap.
--
Cheers,
David / dhildenb
next prev parent reply other threads:[~2024-09-11 12:36 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-11 6:55 [PATCH v3 0/2] Do not shatter hugezeropage on wp-fault Dev Jain
2024-09-11 6:55 ` [PATCH v3 1/2] mm: Abstract THP allocation Dev Jain
2024-09-11 9:27 ` David Hildenbrand
2024-09-11 9:29 ` David Hildenbrand
2024-09-11 12:02 ` Dev Jain
2024-09-11 12:00 ` Dev Jain
2024-09-11 12:35 ` David Hildenbrand
2024-09-11 12:55 ` Dev Jain
2024-09-11 12:53 ` Dev Jain
2024-09-11 13:00 ` David Hildenbrand
2024-09-11 13:05 ` Dev Jain
2024-09-11 13:14 ` David Hildenbrand
2024-09-11 13:16 ` Dev Jain
2024-09-11 10:52 ` Kefeng Wang
2024-09-11 12:22 ` Dev Jain
2024-09-12 13:26 ` kernel test robot
2024-09-11 6:56 ` [PATCH v3 2/2] mm: Allocate THP on hugezeropage wp-fault Dev Jain
2024-09-11 9:36 ` David Hildenbrand
2024-09-11 12:10 ` Dev Jain
2024-09-11 12:36 ` David Hildenbrand [this message]
2024-09-12 15:44 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a09336db-4405-4b24-8420-c3ae4a16f73c@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=aneesh.kumar@kernel.org \
--cc=anshuman.khandual@arm.com \
--cc=apopple@nvidia.com \
--cc=baohua@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=cl@gentwo.org \
--cc=dave.hansen@linux.intel.com \
--cc=dev.jain@arm.com \
--cc=hughd@google.com \
--cc=ioworker0@gmail.com \
--cc=jack@suse.cz \
--cc=jglisse@google.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mark.rutland@arm.com \
--cc=mhocko@suse.com \
--cc=peterx@redhat.com \
--cc=ryan.roberts@arm.com \
--cc=vbabka@suse.cz \
--cc=wangkefeng.wang@huawei.com \
--cc=will@kernel.org \
--cc=willy@infradead.org \
--cc=yang@os.amperecomputing.com \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox