From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 360C1D0BB66 for ; Thu, 24 Oct 2024 07:45:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B45D26B007B; Thu, 24 Oct 2024 03:45:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AF6DA6B008A; Thu, 24 Oct 2024 03:45:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 970096B0092; Thu, 24 Oct 2024 03:45:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 75AF16B007B for ; Thu, 24 Oct 2024 03:45:49 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 5B43B161149 for ; Thu, 24 Oct 2024 07:45:28 +0000 (UTC) X-FDA: 82707711408.28.63DEA98 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf14.hostedemail.com (Postfix) with ESMTP id 6B04D100004 for ; Thu, 24 Oct 2024 07:45:26 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="dU/1qk8+"; spf=pass (imf14.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729755869; a=rsa-sha256; cv=none; b=NIuuJX3d+qi3S2RpVpgbyhylORvOQKEwbONJW0yoebDE7sx2mmkIqouD98lKGFes9LCIrX 89XDMnQpzmW0hbr835DyL8ar1DbAnu6oRaZJhJDvwwDTZ5sujvYN1cIWuJhRhq/G33TYlu XIX58k7Kb5kJJKwVozIPWZazhnFvdfQ= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="dU/1qk8+"; spf=pass (imf14.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729755869; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hPYuDToRpBPGSedDH6WO/E6lGGRZMoEslalgqhpMqfY=; b=Zs/LWi53kyzfn/f15yIjW6HWgLaLGecTpHRVIczUYIwnBhHojgKFJdR9Nm91tYGgdxWWFd k7uhaImif16zGDD9QhL9xexkyA0X7v54qQWUqEIQ9w59+zwDJqAyPCU74BpxTybG867CHf wVKzSMucWPblLEC+C4dGtZ/JIULQXNM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1729755945; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=hPYuDToRpBPGSedDH6WO/E6lGGRZMoEslalgqhpMqfY=; b=dU/1qk8+6d+6sQIBCerhlIdqxLHdt0MJmQXY8lgTi2H35xl2eO8+MsLyu7g7lkAYwUZfqI GPviiRrgdgdYmW5KSNpaaRJv66hChTywu4mZULSZbqxZUP/s0RX0lsPYgI/H4Qcx9AIchB n6HnE99CHQOpqNeJ1clmU2mmvNQKu/8= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-167-ftSaTawzNwq-ePMYfGtSyg-1; Thu, 24 Oct 2024 03:45:41 -0400 X-MC-Unique: ftSaTawzNwq-ePMYfGtSyg-1 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-37d5ca192b8so304766f8f.1 for ; Thu, 24 Oct 2024 00:45:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729755940; x=1730360740; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=hPYuDToRpBPGSedDH6WO/E6lGGRZMoEslalgqhpMqfY=; b=gBJhRPVN3+g1bEfEuk1IP8/fES+WXYaWGan5bM8qUNC1qsmAkdOedyrCBn8Wm4bD9i 8WQq9vkGWINiRFVWilmwlxaSaiYk2S3h9Pr5BHr9vrFc2UQFBcZj8eq24+Op+9cS+irz qvktNFfX52ymc8TxK6YoXix6w15CguQWIFFTrfGaB1d9L8HvtotLDthTpAL7z7IFMcWy SVha8g2PSXhqISyANMgoWooJrdP+P3yE3uuQPfol+IlqXAoRknLxPOZmyMwyMk5+n5kX O4LwMeWUmCkTtDFFTpHbssVF0yBXCuWJ27DSU1t/wG9e0QGUjQnbLz6xdeS7sJYpfSLM Yibw== X-Forwarded-Encrypted: i=1; AJvYcCXo9uO8PQ7nxM2jVC26nvhrq/Eor++9EBAjap8jBtCPVQVhJEz5I1HLyErHIISrZ1WADgsMgvHklA==@kvack.org X-Gm-Message-State: AOJu0YyQqI8qgys1maj4iOpHtnyyxqR0YDDj4tf0O79U3LhGTtlqeNDB 03iFAR0tNKdCiPLegbCu7wfuo8SdwKmV8vjMRQVchP7kfGYkeeubqLAvDPywaK/H/yLuSWIPhEj UaxHdsQx1fmGRWJMop3Kp3e+FIDtbSpcIOwZ/uLIPGR8OeUNr X-Received: by 2002:a05:6000:c6:b0:37d:3f81:153f with SMTP id ffacd0b85a97d-3803ac0670fmr638371f8f.17.1729755939781; Thu, 24 Oct 2024 00:45:39 -0700 (PDT) X-Google-Smtp-Source: AGHT+IELvXhEEh4kEkFbK5TioBTnFzdEpPS7Pp3lgM2sA9dD3bmQAPUom4l+fRdVw7hX/9kDiQSn1w== X-Received: by 2002:a05:6000:c6:b0:37d:3f81:153f with SMTP id ffacd0b85a97d-3803ac0670fmr638363f8f.17.1729755939386; Thu, 24 Oct 2024 00:45:39 -0700 (PDT) Received: from ?IPV6:2003:cb:c704:4f00:9949:9757:8f9a:e10? (p200300cbc7044f00994997578f9a0e10.dip0.t-ipconnect.de. [2003:cb:c704:4f00:9949:9757:8f9a:e10]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-37ee0b9442bsm10632960f8f.78.2024.10.24.00.45.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 24 Oct 2024 00:45:39 -0700 (PDT) Message-ID: Date: Thu, 24 Oct 2024 09:45:37 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/5] mm: pagewalk: add the ability to install PTEs To: Lorenzo Stoakes , Andrew Morton Cc: Suren Baghdasaryan , "Liam R . Howlett" , Matthew Wilcox , Vlastimil Babka , "Paul E . McKenney" , Jann Horn , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Muchun Song , Richard Henderson , Matt Turner , Thomas Bogendoerfer , "James E . J . Bottomley" , Helge Deller , Chris Zankel , Max Filippov , Arnd Bergmann , linux-alpha@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-arch@vger.kernel.org, Shuah Khan , Christian Brauner , linux-kselftest@vger.kernel.org, Sidhartha Kumar , Jeff Xu , Christoph Hellwig , linux-api@vger.kernel.org, John Hubbard References: <9be732fd0e897453116b433fe2f468ef7795602e.1729699916.git.lorenzo.stoakes@oracle.com> <20241023160405.33995c68f20c141325a8fadb@linux-foundation.org> <635de052-35a6-40e0-82ea-4349f3aecc06@lucifer.local> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <635de052-35a6-40e0-82ea-4349f3aecc06@lucifer.local> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: 7k7kec78p157a4z7ki4uj757tw6knf3r X-Rspamd-Queue-Id: 6B04D100004 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1729755926-129924 X-HE-Meta: U2FsdGVkX18dA+OYdforIbTwGqjQo99cTSNE9OAzdXGX2satu0q65Uoiw75htOkVVWssbGXOb4ZEWdRvgxVzc9xJoy8KQcyVWZ+sl/czr0gMTJoA1p3z4TnWgnHgIXYOcrbkH5lLwM0UWYfAXqE7U6dVx7rBu1InAVeMHU3/nHj56G8nZjDnR9XKbtk6i1Shb7PEip2RmLdDYu2q4U+zbVee6o7FBxqOgMm6kY3BNogRduijpekBp84mO/0gq4qfv28jbRPjIJMboOU4Fxs3ePSms+KMW5xhBSLXQ3rKLkxn4jrZ+FpiRGdhoInsHb27j3RFuA92zLsQKeCWnNzPNNd/xrp9df8B7EnpPxeloIsUwn8T+vbthMIVU4yViqtVE0pYHBxA4K5YYqVXWrQrv8QPken0mr7ThI8foGiRcKDZWWTrWiN6Xme/4Svp5ZvdoYw6pzimN6gAAWwXp2w3burxt7BohF+TnTBrZDpZOQZqlwSVEALk3bpE0zSO0peMpqbqX/mWz//VXxEaC59YOeUzjgQ2PIOaWoWY/mC1+6h214gHKcNdBhAXMOQa0wD/RiVUdIC6QJALn0bfsgq+MW28s3M2y621r9dh9cx/qxO6BxTMol0ZfnfYGa0/C9VpuhdyDtoprmmmStSm3mCf92IccEuXGykMdrA/D401pGWifY219Bq6nCQDJt8S9S+9jaeX8/WN068SOzcTtN+G9xamDUnEBlqXGCYI7G3A6GUV36zPcdJiWKVFDyNEHrX8HWLrFMxx6QH05oXoycdumraBVUtfSM80dPNmxQStqC6q9hlhn1fH1JS6skXloHrs/ugkyVjvt6ZH3HObBP4KI7fRaaZjlXhiC27l6VsyDAJyiVh26rZ8cJhTqmx4t8RElp47idIywtDAfqcgRGiwiSG7v3Kp/q9elE8Ux+ajz7I4AUAJoleMJze0XVSWxdPubdDI9Z0ZVgYJUtmR+Qn UGjlucSR T4znQFNvfvSL28LU8inRpI5BQkl2Pr36TQo0N0k1QWPUUZhOpGIubEFl2SSbvHC1RjQFmtbSm21RcE9zTvLv+fonQVgPiSzSB8EBJQZ4JYIVeA6hDPBMUY1R6BWRKLBDu7nPvaucXrDj+7j6R0jEANmgAxorwi+hB2zmg5TmUYi35I2eavEDm8mjvKtY1OJ6z4ipOJh3n7N5sERhrlz5nimTHBMBH2cd7eMB8VYqn344KIUH6IFHZWFRs/bRxZt7Ddr9mOBXN5NUEYUXKtTQrsaFvaWsEGI1FAc8MiSA9sE2qObsx0ZLz3enpU6sI3T+F2u5PZ5x4gKthTqbz8mxkxNUtUS/ugiK9fIiiNMZ72DajGmUWWCqaDxCpJJL3i1H9vYz3EY85bi/UMr0oxXzQ9EJNtx/0j5ehNMAodM9SCwr4iaA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 24.10.24 09:34, Lorenzo Stoakes wrote: > On Wed, Oct 23, 2024 at 04:04:05PM -0700, Andrew Morton wrote: >> On Wed, 23 Oct 2024 17:24:38 +0100 Lorenzo Stoakes wrote: >> >>> >>> ... >>> >>> Existing mechanism for performing a walk which also installs page table >>> entries if necessary are heavily duplicated throughout the kernel, >> >> How complicated is it to migrate those to use this? > > I would say probably somewhat difficult as very often people are doing quite > custom things, but I will take a look at seeing if we can't make things a little > more generic. > > I am also mildly motivated to look at trying to find a generic way to do > replaces... > > Both on the TODO! I'm not super happy about extending the rusty old pagewalk API, because it's inefficient (indirect calls) and not future proof (batching, large folios). But I see how we ended up with this patch, and it will be easy to convert to something better once we have it. We already discussed in the past that we need a better and more efficient way to walk page tables. I have part of that on my TODO list, but I'm getting distracted. *Inserting* (not walking/modifying existing things as most users to) as done in this patch is slightly different though, likely "on thing that fits all" will not apply to all page table walker user cases. -- Cheers, David / dhildenb