From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13B1CCDB482 for ; Mon, 16 Oct 2023 15:45:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9C1E16B00E9; Mon, 16 Oct 2023 11:45:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 949DF6B00EA; Mon, 16 Oct 2023 11:45:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7EAD36B00ED; Mon, 16 Oct 2023 11:45:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 6899B6B00E9 for ; Mon, 16 Oct 2023 11:45:04 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 21ACE1CB4AC for ; Mon, 16 Oct 2023 15:45:04 +0000 (UTC) X-FDA: 81351748128.21.44B6B61 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf15.hostedemail.com (Postfix) with ESMTP id BA95FA0019 for ; Mon, 16 Oct 2023 15:45:01 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=guJwgvZh; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf15.hostedemail.com: domain of jlayton@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=jlayton@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1697471102; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qLFJ6I/gwdue4jINf+DgjzrwjIHoB+fOVo8KsAWvSrY=; b=mKH+sldctvhd0quhlvpCD4R3WPs2hq9Aivc8txZxAPvTI5FGqiTAaRjBB2ZdNLLcZZmESk fj0zXhkCCGNoaJZP08zN5k+Y1RwXqwJIF/Lw2+aKp+dJY/k9y6BXP0MJbE4VVLttIxc5M+ 67C/DY03SpPgZlOLIoCuqE1ibmMqY8E= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=guJwgvZh; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf15.hostedemail.com: domain of jlayton@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=jlayton@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1697471102; a=rsa-sha256; cv=none; b=TDSPI3f3i7izQFlA4eXVFPCfTe/OEd4LRDtUrGswgvp7Lw6SLWXZCOWW8M3jpOczlIcQTi vmCEutT0NbgAM3q9ZqfdKx4qtThXNVo8aCp9vmL8YZHNG4VqNwsx612oHCD9psoNJJavWl 6BEl5BZ9jqWqLnVPQCG3hElap58LZRg= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 537DFCE1804; Mon, 16 Oct 2023 15:44:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C6D9AC433C9; Mon, 16 Oct 2023 15:44:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1697471097; bh=9uoP06owwVRPrncswrsWLKQbhdyottu9QKK6JcK20LE=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=guJwgvZhq0+Zrw5QhtmZPfW4yFn8mNZ3GKIUOfnH3zVXd6BdPrVmytwdm6n34W6H+ uih7zQPbYtKSkKjvX12X1J6ek6B8zzyXJmn5eqCg4IwuAOyGQx0jYQm2qMdPvM8/h/ okldncECKsUqeuslP3yRlKRpYtmuaVcKD5u1KKqN2qwhjDfbBPvqTsK/ImpYNzfBlg PwVq3fw8lT9Q+P+Xe/3V3jnUzY1Z8OYfP7nIEisoCu/s7myl43v1Xj0uocnCQRhAOa YW7F5nUwox2yNFVjc7qjLqmSSl+50CYdhXz3UikmW97Uk9eWg86Lnbks1taiDu1Lou AzOuWKDg8Q4fA== Message-ID: Subject: Re: [RFC PATCH 03/53] netfs: Note nonblockingness in the netfs_io_request struct From: Jeff Layton To: David Howells , Steve French Cc: Matthew Wilcox , Marc Dionne , Paulo Alcantara , Ronnie Sahlberg , Shyam Prasad N , Tom Talpey , Dominique Martinet , Ilya Dryomov , Christian Brauner , linux-afs@lists.infradead.org, linux-cifs@vger.kernel.org, linux-nfs@vger.kernel.org, ceph-devel@vger.kernel.org, v9fs@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-cachefs@redhat.com Date: Mon, 16 Oct 2023 11:44:54 -0400 In-Reply-To: <20231013155727.2217781-4-dhowells@redhat.com> References: <20231013155727.2217781-1-dhowells@redhat.com> <20231013155727.2217781-4-dhowells@redhat.com> Content-Type: text/plain; charset="ISO-8859-15" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.48.4 (3.48.4-1.fc38) MIME-Version: 1.0 X-Rspamd-Queue-Id: BA95FA0019 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: krknbxaybe798b5hho7ztu7eph43y8cr X-HE-Tag: 1697471101-961001 X-HE-Meta: U2FsdGVkX1/MfzcRnp5ehwQngICAzFPvb8CGB17lEYGUwD7O3sFV9ra9SXNPPYM4wCxOtMnJ/M+5xKnQcJOJnf21fQG++KjF5b504Q2k2NW0u/DcHum5UdWAV7WcM+8g3aBEKwIg3bJsUqV1efbuBKV1LQEvjqGV+vkOayS+F6dkOzRhLW0LOlvJk7lrPsuQ8OPZgC0sWhCiha+hGrjFX99lNQ3JNYP0xfv8wpAZKk5H8lsg2cZmSu0l+tYsuhJHcd5gKXfC8sugHdNyFC5DXW0FvWmbBewcmMo7buS8bMni5dpEycG2E2jz9Vt8vKU6Vglwh1GhET9M6SJjTVJf1UDSGanm6Bo+mWTEYsG3kPrcL+p5qidNz3oqUH4xLy5RpusFYBc61m933iiu0dsP1oA8EVZK5NZ8CN3xnpgwQDamn9QNwfULM4pcY8aKdiRlP0xS7ZV06F2ylA79qGbsII0NSkMrvM9Jdvrkvls+bwzGXZibWnGOA6wWloQ0YFHmhbRcpWIHVS4lzlHub5w+vnN+EtQYVnFaCAhPdo6XRWeFpaqAYrUDDkdD+1kG6osZVejjRFfKz3yNeEGeWWKHoaM2JtXbOMzPx+VKPqeK6sdfUAjaxZbhx0PiP3a6LvJWT0K9depGed3Ub6H//RCHyqTmQr1V1XmrKKwK1k3I/a/nYVxd9rm3ZNW64E/Roh669TtejyZ9oT2IleeHfj9EI7DyEn0CyZQilCLXvdPHSkaa9iwApTKvGeWQg4TjpWOa/VHQNgKIBH3N6U6MN7kt1KNi+EAnuIxFt+CUDobbpTkjF1KjOlWXi3/mEhbk/ZUZcYzFyPZH7c+ruiHa9Eczivd7+LmXCFAL3aRiT/EmPaA7VkbpQQoo3nqysl5QUbjVHQy8VYzfL+qDufOfFut2+ORcufmGtD3RUsB9ttsl37vML4FxXdDGOTWPCEh4IAQR3ezzcPdwzuG+glLivbX y3KeRiik o2KvosfMi4KD5MeQtsD4gJ/24bVVAZr57GcqmsqRLNAU1KGTRLVNSFGth0sLatHX+Bu269BMxhZk5IYp/3Nify5cO6lvU1PNf84kgZ4fJaosdXQxxQBYT6RL1ukvJViMP2Xe48GyPWuu9ae0dLDVDww0M88J+M5qQvuK+6s4miuhkvOR8C3S0QeDz8InmE+gEy8x99QBJYK0Y2h/3raPYC2TanSEJ14ACct5l5CV8jinQiV3W8aqmlsMGfqWbY/LStkPeLoWvi2L81RgrBn7qdN738stJtJ2+wfHA9Nn6xuvUWM6wFKDj+X5tC6+SaQwrnupnO5vdey4hPoCVBucXCGEc4XU7cNc7RIhvBlsS4SX03N+xdVTmYt0QrIS8IeAPUlfsz88c0a1XcQszBpgSW4wK2Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 2023-10-13 at 16:56 +0100, David Howells wrote: > Allow O_NONBLOCK to be noted in the netfs_io_request struct. Also add a > flag, NETFS_RREQ_BLOCKED to record if we did block. >=20 > Signed-off-by: David Howells > cc: Jeff Layton > cc: linux-cachefs@redhat.com > cc: linux-fsdevel@vger.kernel.org > cc: linux-mm@kvack.org > --- > fs/netfs/objects.c | 2 ++ > include/linux/netfs.h | 2 ++ > 2 files changed, 4 insertions(+) >=20 > diff --git a/fs/netfs/objects.c b/fs/netfs/objects.c > index 85f428fc52e6..e41f9fc9bdd2 100644 > --- a/fs/netfs/objects.c > +++ b/fs/netfs/objects.c > @@ -37,6 +37,8 @@ struct netfs_io_request *netfs_alloc_request(struct add= ress_space *mapping, > INIT_LIST_HEAD(&rreq->subrequests); > refcount_set(&rreq->ref, 1); > __set_bit(NETFS_RREQ_IN_PROGRESS, &rreq->flags); > + if (file && file->f_flags & O_NONBLOCK) > + __set_bit(NETFS_RREQ_NONBLOCK, &rreq->flags); > if (rreq->netfs_ops->init_request) { > ret =3D rreq->netfs_ops->init_request(rreq, file); > if (ret < 0) { > diff --git a/include/linux/netfs.h b/include/linux/netfs.h > index 282511090ead..b92e982ac4a0 100644 > --- a/include/linux/netfs.h > +++ b/include/linux/netfs.h > @@ -205,6 +205,8 @@ struct netfs_io_request { > #define NETFS_RREQ_DONT_UNLOCK_FOLIOS 3 /* Don't unlock the folios on co= mpletion */ > #define NETFS_RREQ_FAILED 4 /* The request failed */ > #define NETFS_RREQ_IN_PROGRESS 5 /* Unlocked when the request completes= */ > +#define NETFS_RREQ_NONBLOCK 6 /* Don't block if possible (O_NONBLOCK) *= / > +#define NETFS_RREQ_BLOCKED 7 /* We blocked */ > const struct netfs_request_ops *netfs_ops; > }; > =20 >=20 I'd prefer to see this patch squashed in with the first patches that actually check for these flags. I can't look at this patch alone and tell how it'll be used. --=20 Jeff Layton