From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.9 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1CA4FC433E2 for ; Sat, 29 Aug 2020 15:41:10 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id AB576206B5 for ; Sat, 29 Aug 2020 15:41:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="NvYz6Vfw" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AB576206B5 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 145BE6B0002; Sat, 29 Aug 2020 11:41:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0F6C56B0005; Sat, 29 Aug 2020 11:41:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 00C3E6B0006; Sat, 29 Aug 2020 11:41:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0042.hostedemail.com [216.40.44.42]) by kanga.kvack.org (Postfix) with ESMTP id E13636B0002 for ; Sat, 29 Aug 2020 11:41:08 -0400 (EDT) Received: from smtpin25.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 917078248068 for ; Sat, 29 Aug 2020 15:41:08 +0000 (UTC) X-FDA: 77204019816.25.lift68_26036fc2707f Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin25.hostedemail.com (Postfix) with ESMTP id 6ACDC1804E3A1 for ; Sat, 29 Aug 2020 15:41:08 +0000 (UTC) X-HE-Tag: lift68_26036fc2707f X-Filterd-Recvd-Size: 2627 Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) by imf46.hostedemail.com (Postfix) with ESMTP for ; Sat, 29 Aug 2020 15:41:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender :Reply-To:Content-ID:Content-Description; bh=93vPl4ISVwqsT/rzN0zFT8sEJycYYCjRF7JumF/z/7A=; b=NvYz6VfwpyD+r3/mz8kVTJNDWh oDcq20Px1L3OdYCXwdOTRowfxBe6Jgun2w/lOWw5H+CXzIMgFULh5o3BJdzMLMuhND59XX8x38tpW hCRZK+G1byqOABRJiqOMG2g56vu60fb7ObDIYg9bL5fTf7Tja9a5Ej9PoCff5agINSDREwe0pXMa3 qQXc3ggYYnkjpFiHLKbUDkzDSS4LlshQ/AiA1tLITGOQ5ollyJbVMP6RNOG+vNotSQuG4BADxICEW 4nLPsmTgilYClQbOoYaM/RjadHGFCCZZm6R79XhRmLmBHek5NbY1qpFuVFgv40DFOPLx8mxlb7Tc2 BW1f9NVw==; Received: from [2601:1c0:6280:3f0::19c2] by merlin.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1kC2yQ-0002UI-Bu; Sat, 29 Aug 2020 15:40:58 +0000 Subject: Re: [ALTERNATE PATCH] memblock: fix min_low_pfn/max_low_pfn build errors To: Mike Rapoport Cc: linux-kernel@vger.kernel.org, kernel test robot , David Rientjes , linux-mm@kvack.org, Andrew Morton , Michal Simek , Michal Simek , Tony Luck , Fenghua Yu , linux-ia64@vger.kernel.org References: <20200829000139.2513-1-rdunlap@infradead.org> <20200829130429.GG167163@linux.ibm.com> From: Randy Dunlap Message-ID: Date: Sat, 29 Aug 2020 08:40:51 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <20200829130429.GG167163@linux.ibm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 6ACDC1804E3A1 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam03 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 8/29/20 6:04 AM, Mike Rapoport wrote: > On Fri, Aug 28, 2020 at 05:01:39PM -0700, Randy Dunlap wrote: >> Export min_low_pfn & max_low_pfn in mm/memblock.c to fix build errors >> on arch/microblaze/ and arch/ia64/: (e.g.) > > Please don't. This would give driver developers a wrong impression that > these variables can be used to query memory boundaries, but this is not > the case, at least not on all architectures. > > I would prefer fixing it up locally for microblaze and ia64. I did that. and that's why this is labeled as an ALTERNATE PATCH. thanks. -- ~Randy