From: Randy Dunlap <rdunlap@infradead.org>
To: Mike Rapoport <rppt@linux.ibm.com>
Cc: linux-kernel@vger.kernel.org, kernel test robot <lkp@intel.com>,
David Rientjes <rientjes@google.com>,
linux-mm@kvack.org, Andrew Morton <akpm@linux-foundation.org>,
Michal Simek <monstr@monstr.eu>,
Michal Simek <michal.simek@xilinx.com>,
Tony Luck <tony.luck@intel.com>,
Fenghua Yu <fenghua.yu@intel.com>,
linux-ia64@vger.kernel.org
Subject: Re: [ALTERNATE PATCH] memblock: fix min_low_pfn/max_low_pfn build errors
Date: Sat, 29 Aug 2020 08:40:51 -0700 [thread overview]
Message-ID: <a0665bb7-3389-1178-0a79-2155fb88255d@infradead.org> (raw)
In-Reply-To: <20200829130429.GG167163@linux.ibm.com>
On 8/29/20 6:04 AM, Mike Rapoport wrote:
> On Fri, Aug 28, 2020 at 05:01:39PM -0700, Randy Dunlap wrote:
>> Export min_low_pfn & max_low_pfn in mm/memblock.c to fix build errors
>> on arch/microblaze/ and arch/ia64/: (e.g.)
>
> Please don't. This would give driver developers a wrong impression that
> these variables can be used to query memory boundaries, but this is not
> the case, at least not on all architectures.
>
> I would prefer fixing it up locally for microblaze and ia64.
I did that.
and that's why this is labeled as an ALTERNATE PATCH.
thanks.
--
~Randy
next prev parent reply other threads:[~2020-08-29 15:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-29 0:01 Randy Dunlap
2020-08-29 13:04 ` Mike Rapoport
2020-08-29 15:40 ` Randy Dunlap [this message]
2020-08-30 9:56 ` Mike Rapoport
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a0665bb7-3389-1178-0a79-2155fb88255d@infradead.org \
--to=rdunlap@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=fenghua.yu@intel.com \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lkp@intel.com \
--cc=michal.simek@xilinx.com \
--cc=monstr@monstr.eu \
--cc=rientjes@google.com \
--cc=rppt@linux.ibm.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox