From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4420C7619B for ; Mon, 17 Feb 2020 06:45:50 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 892CB20718 for ; Mon, 17 Feb 2020 06:45:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=c-s.fr header.i=@c-s.fr header.b="Jkfz6bJu" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 892CB20718 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=c-s.fr Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 2221B6B0007; Mon, 17 Feb 2020 01:45:50 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1AC1A6B0008; Mon, 17 Feb 2020 01:45:50 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 072A66B000A; Mon, 17 Feb 2020 01:45:50 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0021.hostedemail.com [216.40.44.21]) by kanga.kvack.org (Postfix) with ESMTP id DD1C36B0007 for ; Mon, 17 Feb 2020 01:45:49 -0500 (EST) Received: from smtpin25.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 64D5A824805A for ; Mon, 17 Feb 2020 06:45:49 +0000 (UTC) X-FDA: 76498683618.25.rake92_8a1119c8e7225 X-HE-Tag: rake92_8a1119c8e7225 X-Filterd-Recvd-Size: 3575 Received: from pegase1.c-s.fr (pegase1.c-s.fr [93.17.236.30]) by imf25.hostedemail.com (Postfix) with ESMTP for ; Mon, 17 Feb 2020 06:45:48 +0000 (UTC) Received: from localhost (mailhub1-int [192.168.12.234]) by localhost (Postfix) with ESMTP id 48LZHp5ycKz9tyTQ; Mon, 17 Feb 2020 07:45:42 +0100 (CET) Authentication-Results: localhost; dkim=pass reason="1024-bit key; insecure key" header.d=c-s.fr header.i=@c-s.fr header.b=Jkfz6bJu; dkim-adsp=pass; dkim-atps=neutral X-Virus-Scanned: Debian amavisd-new at c-s.fr Received: from pegase1.c-s.fr ([192.168.12.234]) by localhost (pegase1.c-s.fr [192.168.12.234]) (amavisd-new, port 10024) with ESMTP id 2CQ5mQXasQID; Mon, 17 Feb 2020 07:45:42 +0100 (CET) Received: from messagerie.si.c-s.fr (messagerie.si.c-s.fr [192.168.25.192]) by pegase1.c-s.fr (Postfix) with ESMTP id 48LZHp4Ys7z9tyTL; Mon, 17 Feb 2020 07:45:42 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=c-s.fr; s=mail; t=1581921942; bh=EaltpDTgnTrDBrsgY6UJWwdsZ8tEVbQgtxpz7LvsQrs=; h=Subject:To:References:From:Date:In-Reply-To:From; b=Jkfz6bJu21tolva67YXh2dk19yfmBfDCJTRJwnnZdeKJSj2QkUXlcEAPDSQqDVduo PPmHS5kfH8tLAt5DnL9UwxC4nWXDOogfv4OMZXGRl9BNZ2g1VYBb+M5199VUcWsmbj 1RZ2vD+qrTlc0QaZPEdth7m+baweLU1QKzSHI/cI= Received: from localhost (localhost [127.0.0.1]) by messagerie.si.c-s.fr (Postfix) with ESMTP id 0942F8B79C; Mon, 17 Feb 2020 07:45:47 +0100 (CET) X-Virus-Scanned: amavisd-new at c-s.fr Received: from messagerie.si.c-s.fr ([127.0.0.1]) by localhost (messagerie.si.c-s.fr [127.0.0.1]) (amavisd-new, port 10023) with ESMTP id zPiOIOz8XNJK; Mon, 17 Feb 2020 07:45:46 +0100 (CET) Received: from [172.25.230.102] (unknown [172.25.230.102]) by messagerie.si.c-s.fr (Postfix) with ESMTP id D32F58B755; Mon, 17 Feb 2020 07:45:46 +0100 (CET) Subject: Re: [PATCH v7 4/4] powerpc: Book3S 64-bit "heavyweight" KASAN support To: Michael Neuling , Daniel Axtens , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org, kasan-dev@googlegroups.com, aneesh.kumar@linux.ibm.com, bsingharora@gmail.com References: <20200213004752.11019-1-dja@axtens.net> <20200213004752.11019-5-dja@axtens.net> <66bd9d8eb682cda2d22bea0fd4035ea8e0a3c1fb.camel@neuling.org> From: Christophe Leroy Message-ID: Date: Mon, 17 Feb 2020 07:45:46 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <66bd9d8eb682cda2d22bea0fd4035ea8e0a3c1fb.camel@neuling.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: fr Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000046, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Le 17/02/2020 =C3=A0 00:08, Michael Neuling a =C3=A9crit=C2=A0: > Daniel. >=20 > Can you start this commit message with a simple description of what you= are > actually doing? This reads like you've been on a long journey to Mordor= and > back, which as a reader of this patch in the long distant future, I don= 't care > about. I just want to know what you're implementing. >=20 > Also I'm struggling to review this as I don't know what software or har= dware > mechanisms you are using to perform sanitisation. KASAN is standard, it's simply using GCC ASAN in kernel mode, ie kernel=20 is built with -fsanitize=3Dkernel-address=20 (https://gcc.gnu.org/onlinedocs/gcc/Instrumentation-Options.html) You have more details there:=20 https://www.kernel.org/doc/html/latest/dev-tools/kasan.html Christophe