From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11F26C27C5F for ; Fri, 7 Jun 2024 08:46:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8FAB76B00B1; Fri, 7 Jun 2024 04:46:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8AA826B00B4; Fri, 7 Jun 2024 04:46:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 724CE6B00B5; Fri, 7 Jun 2024 04:46:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 55D576B00B1 for ; Fri, 7 Jun 2024 04:46:55 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 0DA3F1407C4 for ; Fri, 7 Jun 2024 08:46:55 +0000 (UTC) X-FDA: 82203462390.27.CB75B57 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf28.hostedemail.com (Postfix) with ESMTP id C5A57C000B for ; Fri, 7 Jun 2024 08:46:49 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=b+BjaVSZ; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf28.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717750012; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9G908EUHZQO7xwQrAL392gNKVNYWE7yD+jfmTDynUcQ=; b=unfS5SQ8+YV8afvw9Wu7UZTo7VCkc26s/Nk2UMk/TchhwQ/N74xUzIZaymBesLPTUs34iq t5N8zyUyXZiUEHPj4ez+1xBFbwz4DPbZZPRb3RSbcEeoePySdNoW8tJragAIBDhLAShR20 KTNs8c7V7WWsx910MrZl6M/NM48vdXs= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=b+BjaVSZ; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf28.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717750012; a=rsa-sha256; cv=none; b=cevYbU+K+d58lKJXDvo35rZziGSFCF7wbC0b1g+dVm7NTvI+6grnQoXXHOlxcdzCb6K+9/ vqLlQP1CDyLquzr/X/X/TrWOx/c67njxrGYn1vXH7Z/tfGlqL6r6wvgjimUP7pmokfjWwP vEzIXStsEyJhlaBK3+OyiRT6bwZ0pzo= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1717750009; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=9G908EUHZQO7xwQrAL392gNKVNYWE7yD+jfmTDynUcQ=; b=b+BjaVSZOQTncogGOU4TxbVmQeSo2P9EW0+2MXuxFOn02S3HPaAC9nXcedxn61f1m+e/jQ +OXzaXhYuX/9Xq0uYyacWY5LWy+yTVdqv2FksiRHmAaNIpcDvf4muR0vr7Hk4zvteU+UpZ S6IhBRGUtsvUSheaIZ5OZl7pP7cgNsc= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-438-OoWzXVhsNnCTZmwX2LimvQ-1; Fri, 07 Jun 2024 04:46:47 -0400 X-MC-Unique: OoWzXVhsNnCTZmwX2LimvQ-1 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-35e114d0befso1282453f8f.0 for ; Fri, 07 Jun 2024 01:46:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717750006; x=1718354806; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=9G908EUHZQO7xwQrAL392gNKVNYWE7yD+jfmTDynUcQ=; b=p1Qf0oDqJtgT9lsOSB3gOsFq5dq0bnTHktz3oiNjJ4a3GZzQ7/G7P09xJshPeXqYPW OVezObFCtcpdr/X8BRhrQLx58mf9ayEd6HKGb3MgAq8V9B5bmGkNvJm5S0QbP5nBLOfL KdbzSSufrwVRvf6Rr08UhhfWoC3IIOOjUdKy/YG8iBsn7j65LVbm8nfDzTJfDilY1GhM NayZBI085EhgkP9czvxwG5N/YqIOUDkT+zP0jFIUDmCkDTKFud6RHRar2J+3GOcrRbHO vf0bsqvdC7/ai6CLSTQOfhsL66M1nn2khiJtXim04QI/XmKGHOrG7ZaN0HP3Jac8xBki w72Q== X-Forwarded-Encrypted: i=1; AJvYcCW66u1aBrQQ4QiWxmsF07gPrGW/8SdyeP0CV6fUxcWvehRRKXnhQEAtV4HkFptZayrx+1RpuxjoAhZvHIOCCqxyjpc= X-Gm-Message-State: AOJu0Yw5wVZKIn+hrKsCDaJIMeX143nRYqpbK6yzJTv8idxTlhPgsb5Q +OvPsjU/2mL9B9BmuzQksJJDcS7utxF/fYCRtt9AVRaFiJZFoet5e+Z++zNzZ7C3QwYL/b83RDG LAdFxWNj1UL4Lc0b2UCBBgYRg6G3jl5gHXv//WSxJ2yhGX5fR X-Received: by 2002:a5d:51ce:0:b0:35f:d4b:1368 with SMTP id ffacd0b85a97d-35f0d4b1525mr46346f8f.15.1717750005994; Fri, 07 Jun 2024 01:46:45 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGg0d2a/RQQtggUuTpTabIxQ3RXIDIBipSHymN3if6O/LiRJWp5s2rGBXZ/EghZCMjG9ddl6w== X-Received: by 2002:a5d:51ce:0:b0:35f:d4b:1368 with SMTP id ffacd0b85a97d-35f0d4b1525mr46324f8f.15.1717750005472; Fri, 07 Jun 2024 01:46:45 -0700 (PDT) Received: from ?IPV6:2003:cb:c71a:2200:31c4:4d18:1bdd:fb7a? (p200300cbc71a220031c44d181bddfb7a.dip0.t-ipconnect.de. [2003:cb:c71a:2200:31c4:4d18:1bdd:fb7a]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-35ef5fc12e0sm3505157f8f.100.2024.06.07.01.46.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 07 Jun 2024 01:46:45 -0700 (PDT) Message-ID: Date: Fri, 7 Jun 2024 10:46:44 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm: introduce pmd|pte_need_soft_dirty_wp helpers for softdirty write-protect To: Barry Song <21cnbao@gmail.com>, akpm@linux-foundation.org, linux-mm@kvack.org Cc: chrisl@kernel.org, kasong@tencent.com, linux-kernel@vger.kernel.org, minchan@kernel.org, ryan.roberts@arm.com, surenb@google.com, v-songbaohua@oppo.com, willy@infradead.org References: <20240606034016.82559-1-21cnbao@gmail.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240606034016.82559-1-21cnbao@gmail.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: C5A57C000B X-Stat-Signature: mw3ik5znrjzjs7inp1in57g1jse9ohp5 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1717750009-677604 X-HE-Meta: U2FsdGVkX19EDYlfRPySeTSohYcsJ0gdHjfneYdfUSpWSNBT4VCVi5CsvknxQ8NCi71/8mWpqb8UEyCu6V2N7nc9JAy5MZbtWwRYg9ejqA0jN5UmLN9JYHZ5kv8tIkOp/Hl2C1Q+W6HizS+aBt+hz1K+R8WIDX/JziWlHXvc9FgiryURLv2NW/sFUt4AMiVhfpMQ3ukqtlqi1k8xslK6x/YXU4bTvjlg+BHYnu2lgRGiLUpOdXC/uHeFawGnbx+RU6M1xW/R/UoP2DlN6uRbKhm6GGGZR3rkQCP+++uZF6h9pKVqGlLSYKIr7U+XLNrwdc6e61hz/KfwhfWvOTprVeCzCtqzCDmbK4AUWYwK1YGq4NyAxrORcYH4qKmZJuldJZZaQpT9ogfQM48i6RJ+DvPHP9yvXyQn46sZP8KRFbfMbpd6IEQMCvOqsBQ+ngNwfKzXpK6YvLoTcQOu2qRwmgCrKCCDF1MxkZpG6wUw7S1EHIHSdb9fq/ZIxLr7vG4hn0hvsTnjt5pUuxK4f6TSO1r0tBoVCiy6fTAbgT+SktpvOEDcjk9aXP3UXMCEbC/Ij/CjfWj0jCBafO6dEGNS86h2Xm8vpXdPD3AYRBwbOeBlPbEEaWOy2+CNHRNTUeDgtXcgH4JZKkpwGTcpJgIXwV0syhPD8W/7KMrc3ruyuJFH7opgurEEyPEGoTjWaH5pbN4yqvyTHf7yic1nnQmQpcQXD77+6ybmqJ7VcrzdILah3OItZ0Pz4mahkzpqusivqGr+ej1zDIvSFv7yrMuFMjGLXqojJFkxYQbnFQK+2I0Zf5ul8nw2aDoHkEJOOtKMuzhQPdV47FRDRbFPosWbl7nZwkYbjZHyv06IzGnLVpqW/hVR2icYeQx6GXuIOJhCaBJV2K97ISFnkRs0T+f0TsGAH8IyHEeJzdJ/QABgJp926QN44LQxGlDDm8gnl2fda4e7H49+xhAu6J33myZ bPhXAKa9 g4eFOBzvuOcGlbegwoM78roJYrc7G2si2bPZxWpFYBskhfu/M1k/1Etbac7eK2GaCErzY08aZL6cxTKHBhivKba9Z8mge9K+7CEmOS+uMPpk0rnzVej8ak+GFG/QHeI4CfU0YGKwcQx69juogKv2xIJOhFv2YstY5xajGpCBz6sl5YgGyfx6vt3i1yQIJcgKvru+UE9TCrviIuPK4LX3OcOm4dYjze30l48yTj1lX24NuEgWoP1NBjEL6ZYX96QBv76x6ccluqr1fO6RK9+dhrtwzQJSiX0Xqyr95OW2JnuseSSXvup/Z96W2tkiNN0CEAULVWhkC1J/7eAb3p/lbfP3rB5FVW+lIsVd0AiIXEmMqzyH7nDAW0J/pAt0kT1vZcQt7ooBspPlt5YryEURRWDwDVTCfT0UX729LNju+Kt+RV0YRZH9NH0Q0n64jwifcbdbfX3SPNOsh2j8fUTmJjGOFU2Hl3PhHE1Ookk0hD1CWs2uGCNbOiRF6y2NxncQbUFPYEZ3npXqqxtDiiCCjHQihepdHX6Cxk5hjFDC6qw4hbLJyG3jpKy7aEdg+5NNlk00W X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 06.06.24 05:40, Barry Song wrote: > From: Barry Song > > This patch introduces the pte_need_soft_dirty_wp and > pmd_need_soft_dirty_wp helpers to determine if write protection is > required for softdirty tracking. This can enhance code readability > and improve its overall appearance. > > These new helpers are utilized in gup, huge_memory, and protect, > and are particularly applied in do_swap_page() to optimize a > softdirty scenario where mkwrite can still be performed. [...] > +static inline bool pmd_need_soft_dirty_wp(struct vm_area_struct *vma, pmd_t pmd) > +{ > + return vma_soft_dirty_enabled(vma) && !pmd_soft_dirty(pmd); > +} > + > +static inline bool pte_need_soft_dirty_wp(struct vm_area_struct *vma, pte_t pte) > +{ > + return vma_soft_dirty_enabled(vma) && !pte_soft_dirty(pte); > +} > + Should these be "needs" ? I tend to like these names/semantics. > static inline void vma_iter_config(struct vma_iterator *vmi, > unsigned long index, unsigned long last) > { > diff --git a/mm/memory.c b/mm/memory.c > index db9130488231..6307c43796aa 100644 > --- a/mm/memory.c > +++ b/mm/memory.c > @@ -4322,7 +4322,7 @@ vm_fault_t do_swap_page(struct vm_fault *vmf) > if (!folio_test_ksm(folio) && > (exclusive || folio_ref_count(folio) == 1)) { > if ((vma->vm_flags & VM_WRITE) && !userfaultfd_pte_wp(vma, pte) && > - !vma_soft_dirty_enabled(vma)) { > + !pte_need_soft_dirty_wp(vma, pte)) { > pte = pte_mkwrite(pte, vma); I would move that into a separate patch, as it's not a simple conversion. -- Cheers, David / dhildenb