From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 281F5D62040 for ; Tue, 19 Nov 2024 08:53:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 146896B007B; Tue, 19 Nov 2024 03:52:59 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0CF386B0082; Tue, 19 Nov 2024 03:52:59 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E3C396B0083; Tue, 19 Nov 2024 03:52:58 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id C3B7D6B007B for ; Tue, 19 Nov 2024 03:52:58 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 76C501202A3 for ; Tue, 19 Nov 2024 08:52:58 +0000 (UTC) X-FDA: 82802228670.04.3D9C93F Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) by imf21.hostedemail.com (Postfix) with ESMTP id 85F8C1C0007 for ; Tue, 19 Nov 2024 08:51:21 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=Z8NgF2o6; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf21.hostedemail.com: domain of pmladek@suse.com designates 209.85.128.52 as permitted sender) smtp.mailfrom=pmladek@suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1732006310; a=rsa-sha256; cv=none; b=lpIKq1EuTTUXKcrAKDeoWCOYE0/eZG/G8chKunVgQLUwY8WpcO2aEFMnv+jmTla3AVekfj QQQQ5pzqPMTPPLmD68Ri8tD3lrqpFfdUocbhYFFwIIbTM6n/zdBhAPVTJ8q/nKBNDngiiM WD9Dw3SadYkZqUth4tHa6PrMYgLg25I= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=Z8NgF2o6; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf21.hostedemail.com: domain of pmladek@suse.com designates 209.85.128.52 as permitted sender) smtp.mailfrom=pmladek@suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1732006310; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qaBG3Z7R9DOuiOybc185RSD4M8rIPEBBhrkZgjFmOxU=; b=7dAxclDpM1RQwgW+Hz4uvCCKaQeQHabbxtMz8tmO1Q0p1lMx1myHtem2eTk4BZhPTza9Ch fOdf5U+lgwdL8ip/RPJVROnnSplhEumq0Dt022tUUrqKWS/b0YT6N+ggfztVaxDPl0aUGj dK5W6fEYACTYujGn23o7yrKcnWYUnI0= Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-4315df7b43fso5830945e9.0 for ; Tue, 19 Nov 2024 00:52:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1732006375; x=1732611175; darn=kvack.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=qaBG3Z7R9DOuiOybc185RSD4M8rIPEBBhrkZgjFmOxU=; b=Z8NgF2o6//6LgMiVHjBNHJMx9OGxIqytKiDrAjjODLPZmtZ4MpM8ljboxe8uaW4MvF Zf94WkO0JQE2wqSWKOhq8BAzpqNle69F+t36KD5O8lQgHOaDnSE1sn4pWUG1os5Udh7x 2Nqh49tunfMtrQ1AZLz0Hqx/726I/yiLsaQ/PeHiACn2KFgtKFzv89k9yPgMh7WnIs/o Kwx11bAiNihBD9iJBzk3En2jOCgwpu5HwzBP5Nw5PlO2UOkgi4wTB+lokVZEVqWVdRGq W2GVObIdsPrcSi6YGm033zvgERPstGewCJ+gkDbObSj74WlsFtsguI4AHEjpnz1H00V0 F0rg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732006375; x=1732611175; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=qaBG3Z7R9DOuiOybc185RSD4M8rIPEBBhrkZgjFmOxU=; b=JDwyLcgwVSELq/7S0TWVU49RTEvCGvt7odq3R1PXanB3f88h7jAme4IhWBYuc8+bvP ZsaW8ugui/Xgb5eCFtQ/ApPBT764nQKh1hKvjOS2iQpLe8b1S1mt9RiuE90gV2ir+f+m mqq6HeoRxWZmUDxR5hq1oRkBZDUzKiXsSAHpU5UPWhkyR4WUvGAZa737VJof0jbYTknN 3ezhS2bHv57QND4ytzAMoKju1JuZ7ypfx3JOtz19/tB3gWzW7l6MwE20aZ+3T1mKrMH3 uTRRpuEspD+cnII1Q1wgttVEFAnwMI26nrbIPRTag/dQhqCRjWXUSI8w1I7a+Xvmrh04 TVcQ== X-Forwarded-Encrypted: i=1; AJvYcCXPfAL0XR0gHYsYnGtHZOpkAX5QbVnoZs+Sy6F+HDijZZjRf+tQu/jzbQaOIlhkLImECgPs3mvTDA==@kvack.org X-Gm-Message-State: AOJu0Yy8NR8wV7Mlqutx5hfmZH6VMRVcSQ1on6D7hWlJ8e+b6G7KnQDL 7Rw6qBez4ls8Dh86iDcF8SDVba9SjGWoCWR3Q6g+KYR/qtYjiR/kwWnV2VOIy48= X-Google-Smtp-Source: AGHT+IHrqP9nC2rPwknktgIKbjWoIt1yh0m5e2N0IUvcTBAuP3H8V/AdHOWp2OIw94YWQU//ijQi/A== X-Received: by 2002:a5d:6d0f:0:b0:382:2492:3218 with SMTP id ffacd0b85a97d-38225aaee39mr12773115f8f.47.1732006374705; Tue, 19 Nov 2024 00:52:54 -0800 (PST) Received: from pathway.suse.cz ([176.114.240.50]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3824a8109a7sm3705943f8f.104.2024.11.19.00.52.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Nov 2024 00:52:54 -0800 (PST) Date: Tue, 19 Nov 2024 09:52:46 +0100 From: Petr Mladek To: Easwar Hariharan Cc: Christophe Leroy , Pablo Neira Ayuso , Jozsef Kadlecsik , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Julia Lawall , Nicolas Palix , Daniel Mack , Haojian Zhuang , Robert Jarzmik , Russell King , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Ofir Bitton , Oded Gabbay , Lucas De Marchi , Thomas =?iso-8859-1?Q?Hellstr=F6m?= , Rodrigo Vivi , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Jeroen de Borst , Praveen Kaligineedi , Shailend Chand , Andrew Lunn , James Smart , Dick Kennedy , "James E.J. Bottomley" , "Martin K. Petersen" , Roger Pau =?iso-8859-1?Q?Monn=E9?= , Jens Axboe , Kalle Valo , Jeff Johnson , Catalin Marinas , Andrew Morton , Jack Wang , Marcel Holtmann , Johan Hedberg , Luiz Augusto von Dentz , Greg Kroah-Hartman , Florian Fainelli , Ray Jui , Scott Branden , Broadcom internal kernel review list , Xiubo Li , Ilya Dryomov , Josh Poimboeuf , Jiri Kosina , Miroslav Benes , Joe Lawrence , Jaroslav Kysela , Takashi Iwai , Lucas Stach , Russell King , Christian Gmeiner , Louis Peens , Michael Ellerman , Nicholas Piggin , Naveen N Rao , Madhavan Srinivasan , netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, cocci@inria.fr, linux-arm-kernel@lists.infradead.org, linux-s390@vger.kernel.org, dri-devel@lists.freedesktop.org, intel-xe@lists.freedesktop.org, linux-scsi@vger.kernel.org, xen-devel@lists.xenproject.org, linux-block@vger.kernel.org, linux-wireless@vger.kernel.org, ath11k@lists.infradead.org, linux-mm@kvack.org, linux-bluetooth@vger.kernel.org, linux-staging@lists.linux.dev, linux-rpi-kernel@lists.infradead.org, ceph-devel@vger.kernel.org, live-patching@vger.kernel.org, linux-sound@vger.kernel.org, etnaviv@lists.freedesktop.org, oss-drivers@corigine.com, linuxppc-dev@lists.ozlabs.org, Anna-Maria Behnsen Subject: Re: [PATCH v2 19/21] livepatch: Convert timeouts to secs_to_jiffies() Message-ID: References: <20241115-converge-secs-to-jiffies-v2-0-911fb7595e79@linux.microsoft.com> <20241115-converge-secs-to-jiffies-v2-19-911fb7595e79@linux.microsoft.com> <718febc4-59ee-4701-ad62-8b7a8fa7a910@csgroup.eu> <96f3b51b-c28c-4ea8-b61e-a4982196215f@linux.microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <96f3b51b-c28c-4ea8-b61e-a4982196215f@linux.microsoft.com> X-Rspam-User: X-Rspamd-Queue-Id: 85F8C1C0007 X-Rspamd-Server: rspam11 X-Stat-Signature: qz94jfi1wjiuuaqf9y4aeutpeqo8y5wz X-HE-Tag: 1732006281-474028 X-HE-Meta: U2FsdGVkX19Ew7sk7nLnzTcwUY9Jxha5nLqOBt6t3sztaWbVSBjU2YFGRalg0h/wjrMia9HFAKSoAVviIzZU80caL/2/SWAUMFSF6YcEt7fD7PgRb2fMoEDpFKy/MMEATsiobNkB6gh/dXbLcOEjjEYA3hitIwIPYp9N4yeaLcsjYT1HB/6JZOM336Mm1hiyAa22TunqQMy2iHSeslX3PTP8KsgdufBMQMdoAdyK7igt6Wx/i2bNBLK5Tbi6YSQAQVTMttQqhgitkUldoMWNTJLvkD6Da4c5F0WG9p5TkWYFpO/b+KekTaFcPu992rPJhYNMU/LjV4X6alUccQssnS505zcNbnIrgXh2FXa4WF8iUmcUoH9QYf1Its5pDpZP9oZBURAY7iCrLL/tGTcCUUB0h98ZNYda+4fSZod0r2kL245Uzk7KGOUdvXb9XvZwX1PrxOGVor03TwW+xRLPYZIsU78F3t9Z7Pl00B0Pz81+ARw2iWQW62VByuEjjblfvus77Law5Jv8V69sipPO//wty9iCntV695bLPiqLzKS/69VIk6cmi9A1B7VRYHfYS5KL4CJTB032pybAfheVgbE4TjaK1YxwYgQQzDoeU+wwgnbqZ56ZO/BvPlBr+cLB9zNSRYf77+kaDHxNyzGQf3rPyJgXHV3GC1TytbXwFs5OXrVEVBfEjUVuoWvg4XMFZ0kZMh1qKo6TptbzhImByqNQtcB3ywaiV0A9pFSNKo6eYnAdxtjRt62g0+JtYaD27Xz3DT0IDuZpGkmNYKKYa20ndS3fAESQVRyju7XkMOEF6Wjs9AOBG/8Ilhj0s7UquHM83iyudKmG5HfTrKxaL62++djY86iqx/Vk8aq1jiHmlgBNebWL7QQlVMO9Zfd0Ccfn64iptpz+1yzbohLW95PRqg73q6p+WF+dFpcfTZB9qEOiraeoIWwLxd2iUZMIGFQ7ikc5p0ivi8DNZRH LOA8z4RD z4dXTjOzQywec5XqmvRlc5nFsd9oZP6k1UkY7MliwMWhU1UKW+34vTSX2UbfCClkBQeRYzmAJb2aBgI67NBCLd01YjPldJPA+O1wIVBpr1OfD3E+d8ALPjoPaVeH4N6TybplvMDCfkbNVzf3L/hQFYuMP2e5eDUaP0vtgl0d0zZZF+fr/1udyTF6p3wiL+ebtrN/EXtI0Mpq1wXn/FGA52p0fkNWv/ME1Ly32liWxJQNyVCD6xqGNZCcIu7bw2p2DjVyaAb1MUq4ehDd1Td6pJJshDO1ivracuN9tIJpWyhoGTonF8xy8pnn8lSfhC8AoadxN1/gw+dgkBflMKWhklss5FUOaIoamig5m+xPZNp11+04FscBOALKr91PiUHt0tkhYqZPlgWgVOdVz3CYZz/MeOzXoLnY2csvN/uV2a75GD7WjPEOc7fEjvKyCa4cHtPqyVPhivE6OJOPDrvFPqdPRESNkF54xN4jq X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon 2024-11-18 10:18:49, Easwar Hariharan wrote: > On 11/18/2024 3:06 AM, Petr Mladek wrote: > > On Sat 2024-11-16 11:10:52, Christophe Leroy wrote: > >> > >> > >> Le 15/11/2024 à 22:26, Easwar Hariharan a écrit : > >>> [Vous ne recevez pas souvent de courriers de eahariha@linux.microsoft.com. Découvrez pourquoi ceci est important à https://aka.ms/LearnAboutSenderIdentification ] > >>> > >>> Changes made with the following Coccinelle rules: > >>> > >>> @@ constant C; @@ > >>> > >>> - msecs_to_jiffies(C * 1000) > >>> + secs_to_jiffies(C) > >>> > >>> @@ constant C; @@ > >>> > >>> - msecs_to_jiffies(C * MSEC_PER_SEC) > >>> + secs_to_jiffies(C) > >>> > >>> Signed-off-by: Easwar Hariharan > >>> --- > >>> samples/livepatch/livepatch-callbacks-busymod.c | 2 +- > >>> samples/livepatch/livepatch-shadow-fix1.c | 2 +- > >>> samples/livepatch/livepatch-shadow-mod.c | 10 +++++----- > >>> 3 files changed, 7 insertions(+), 7 deletions(-) > >>> > >>> diff --git a/samples/livepatch/livepatch-callbacks-busymod.c b/samples/livepatch/livepatch-callbacks-busymod.c > >>> index 378e2d40271a9717d09eff51d3d3612c679736fc..d0fd801a7c21b7d7939c29d83f9d993badcc9aba 100644 > >>> --- a/samples/livepatch/livepatch-callbacks-busymod.c > >>> +++ b/samples/livepatch/livepatch-callbacks-busymod.c > >>> @@ -45,7 +45,7 @@ static int livepatch_callbacks_mod_init(void) > >>> { > >>> pr_info("%s\n", __func__); > >>> schedule_delayed_work(&work, > >>> - msecs_to_jiffies(1000 * 0)); > >>> + secs_to_jiffies(0)); > >> > >> Using secs_to_jiffies() is pointless, 0 is universal, should become > >> schedule_delayed_work(&work, 0); > > > > Yes, schedule_delayed_work(&work, 0) looks like the right solution. > > > > Or even better, it seems that the delayed work might get replaced by > > a normal workqueue work. > > > > Anyway, I am working on a patchset which would remove this sample > > module. There is no need to put much effort into the clean up > > of this particular module. Do whatever is easiest for you. > > > > Best Regards, > > Petr > > If we're removing the module, I'll drop it from the series. Just to > clarify, do you mean to remove all of samples/livepatch/* or some > particular file(s)? To be precise, I am going to replace: samples/livepatch/livepatch-callbacks-demo.c samples/livepatch/livepatch-callbacks-mod.c samples/livepatch/livepatch-callbacks-busymod.c with a completely different modules because I am reworking the callbacks API. All other sample modules are going to stay. Feel free to remove livepatch-callbacks-busymod.c from the patchset. But also feel free to keep it. The API rework goes slowly. I am not sure if it would be ready for 6.14. Best Regards, Petr