From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E09BD6007B for ; Tue, 19 Nov 2024 08:29:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 06B7C6B0083; Tue, 19 Nov 2024 03:29:21 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 01BC66B0085; Tue, 19 Nov 2024 03:29:20 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E25236B0088; Tue, 19 Nov 2024 03:29:20 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id C3A3F6B0083 for ; Tue, 19 Nov 2024 03:29:20 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 474F51202A5 for ; Tue, 19 Nov 2024 08:29:20 +0000 (UTC) X-FDA: 82802166594.20.9F27F86 Received: from mail-ed1-f51.google.com (mail-ed1-f51.google.com [209.85.208.51]) by imf10.hostedemail.com (Postfix) with ESMTP id 4EE66C0013 for ; Tue, 19 Nov 2024 08:28:56 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=GQPbPGdw; spf=pass (imf10.hostedemail.com: domain of mhocko@suse.com designates 209.85.208.51 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1732004898; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5jH4xv+sR4Al/gOR3OXvEI7SwC+hrXa/pJ8uLUM/+9U=; b=xrjhPaqYauyxV2Zzsplsdg4m0+085/2sRbZT5GwdENenIHEh6EfHvAX8zgpLFZxBCYraCG f0NL2qj92LgceVwX4nbjOuiHHJSfaicw1/rBjrKZcwgvNuNy7DoHL+xwNwLNsa02Dol8sn E6LkD4HqWExPf9iq2MpZdPxxTqNkclY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1732004898; a=rsa-sha256; cv=none; b=qVd6GgYQq3lnITrqYPONFT8/Kja0TXTitf+hPXbXAd1mMDreQ1wUYwrr+Xv5kt+Rkft9UV VqHhbXvWO+1Ww7i/6m/qTfcqGWpERvqBErwbUZkpYT09ZVmTq6fnvj5p1r/PDxcxHvAneJ fQEZc+pqynbCKvA0eyBQysDnCU2dK1M= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=GQPbPGdw; spf=pass (imf10.hostedemail.com: domain of mhocko@suse.com designates 209.85.208.51 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com Received: by mail-ed1-f51.google.com with SMTP id 4fb4d7f45d1cf-5cf9ef18ae9so6046327a12.1 for ; Tue, 19 Nov 2024 00:29:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1732004957; x=1732609757; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=5jH4xv+sR4Al/gOR3OXvEI7SwC+hrXa/pJ8uLUM/+9U=; b=GQPbPGdwl2BiLXDOF7Kq+0wYF5GPuur4kjKABfZSDvaIOfo6HBJ8a5xGmqxt77vKhc IPEm2F2BTg/Um1YlahUSX5VZjlFwdV/MdhAypvs06IOQJw6T4rsAPMg7oTPW2CsEZm0c NPAKAIxaFIRyTmNcT/0O4SX8DBYZDoouqPk/wMK1c6CEhBU8heJcTI4/P25s6G779EKj z/HFTciNhDUvFPdp8ncBUI3Dlr7U7+X6k3bajZhVv/SyOPtyV492qvpqFQxjLvXgVSsD gdbdtvw3mTC2IjAM+hNR9U5ZplL2Q9RIcB8BsoZptoE6bGSVt8vMSUtCknTzorc/0KLt 7mBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732004957; x=1732609757; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=5jH4xv+sR4Al/gOR3OXvEI7SwC+hrXa/pJ8uLUM/+9U=; b=DKaz7wi5j8y2xkdUcqkyFoPwtweP/1UmwZdRwPEpFOW4DHItGK0JWvQkj8dS3UyuaQ adOOueCTC7aBGi5DO8h9XCNQYo/r/2yC7g5zTWw06kDcbfGx5LmvYh6TPVLtJhjwjasy Qqwf2ptKkFcXbvhrnZ67xnSU+l3jeenJPMWykavxoWocucasjvXdojsKHMAFKyu4ovDA QzYQNvfkr4wCFFzgrQV6Fe2dRuXVpVHwTjwLABRP3aMxMvt/tDcMBhISrEC19jD8+0D4 QqJYbPM5R9GmvbZAVAlL+JP0SSNw/aTMrtATEYTV+EPIwtLo3ZU5mOEPd/jiVMzjcEID rb7g== X-Gm-Message-State: AOJu0Yzf3/vwXO+lRmCtA/Pl88QJOwcWq+E0+gS7qdm64Bv5te6VpDqs zbemtNOdi5e9aZEYHrfSrbc7423x/z/M2y38BQdHJHzV3wCyav4gCLYP82l0MQY= X-Google-Smtp-Source: AGHT+IEaZYns8YIqU8fVZizD6+A1wmyvYG60rg1tB1S9LYpkKleiNedOiGTxf1SR/nyQ4V3LKUmHkA== X-Received: by 2002:a17:907:7f0e:b0:aa2:be2:f1d1 with SMTP id a640c23a62f3a-aa4c7e17d55mr213141166b.10.1732004956734; Tue, 19 Nov 2024 00:29:16 -0800 (PST) Received: from localhost (109-81-88-120.rct.o2.cz. [109.81.88.120]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-aa20e046afdsm622185266b.163.2024.11.19.00.29.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Nov 2024 00:29:16 -0800 (PST) Date: Tue, 19 Nov 2024 09:29:15 +0100 From: Michal Hocko To: Pavel Tikhomirov Cc: Linux Memory Management List , lkml , Andrew Morton Subject: Re: Question about vmalloc(GFP_NOFS) Message-ID: References: <112f93f3-455a-4b89-94c9-d12844d972ef@virtuozzo.com> <377a6aef-46a7-4492-a44f-b2a46869a9d0@virtuozzo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <377a6aef-46a7-4492-a44f-b2a46869a9d0@virtuozzo.com> X-Stat-Signature: 1yymjfmdu5sic5efki8u6izzai4myre6 X-Rspam-User: X-Rspamd-Queue-Id: 4EE66C0013 X-Rspamd-Server: rspam02 X-HE-Tag: 1732004936-742781 X-HE-Meta: U2FsdGVkX18yV17VIPlOvNFDMVQ6sWlwUzpbO6DKJ5nEIOiR6eok/aaMX9bv/OtzEzskc03c+tj1RxelOrNLdpSMqZdhbQNjTlqDFX1YPEqFyNhbEQkd1tJIf0Qsozboil4W/Ech/lMDdkJoxgLqVN+fuZG1jwmx3/j3Ms/5UPZSF65AFX1sGDf7OZUCOLKsML1gLO0IhVMihPG43/2LGefK/o8iq1OJELb/0rdjJ825zOx/wOkXdoofhXe6j0JCA6F58c72xtfY4iMUgxASO+o8B+Jn/IbqBP54HNpEqhhhgikCpwnpvLNcVVpkq2XNwyNr/sApWgzTpkYDO3+UtYR8cevbmCOrRyIcK2YQBdvzg3QJPvZq1ugq3Qx5puMLCWSbFcYjzB2fmzGw3AOliZ1giRoRqVbnbxnMCocZLpLFLAH6LFMaKrI6cmo5ljwkIXVej7zkP8BsNMNhaSqM0QRXBLVv/f77I3kKvxfEU6YtvHJlHrNsXLW+ckuP/8bP1cFLUvJuKaRgKkkIqOldcpxaIz5adxLnZmvXXtC3dXKPREWjViteDQxSJB5m7PjQRPIFK/UyAYHkEuWYufSh0MOjMidA9n1VfdO575dWscDvYvswX5REAQngRAgOgj93NvC0DeG931imaq6InZ92sNwZGgdfGjFVMjaWuDjizYAUUdSPNfL6LJOsWTO14YE+FvKPXntZEWqT569PcYmx/keECrHz/b3iV9bOejxe/wch/0PVeXbZfuIRWgUSJBVJvn8FsbH/r1972NsLom+tcrCxK+rQIVi7+DRh7tCRhMkii0AmhYXvckaY2Sixzc/0O7xRRpvC2MI0TrMyWkprV5x2NKMMKB9wG15x9rLRWbFu01mUq41OPQhW0sYxGWIxOSKQ3sVC/BoRKnMfpmmWdvIzX0cXPHyaI296lMJpj3sG+55lhdBg6HLzKV2gKHP1D0IjSsV/yyHYJj05zOK nadlaswc qlRi43gancGmIQ6bm+M8wumUo9Rs0CWhj/oRdJnxrjoFRmBZCk/JTL2phz25FBVNafCj8guKksr2JP1iF2pcliG4TaWgnlu8xXn/pP90bjCwuNmiOdY1UCZc9ZUAx/k/BYi5OrufN8o73yMatJxbuTG7K2XsBwV9tpMTGezP8UgX7XXbpWv6UKDbxKDBsD9/veMfNmL0Ct7yKerFM6ULb+ZMy2gr0HVbZWrzCbnFUyE7z/LqyaTGKrlow4DHZDKfzeFmgYv+EQxrh3SJ17cPqpnL+5qAU1UxkZM91kIOF/K1E/eRechwxDfr8n0HIN6wqhJyHO6kMJXXJi6DETLUgZLbPGYl24QxO9/cj X-Bogosity: Ham, tests=bogofilter, spamicity=0.000014, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue 19-11-24 15:24:03, Pavel Tikhomirov wrote: [...] > In commit 451769ebb7e79 ("mm/vmalloc: alloc GFP_NO{FS,IO} for vmalloc") we > add implicit memalloc_noXX_save/memalloc_noXX_restore at this code path: > > +->kvmalloc > +-> ... > +-> __kvmalloc_node_noprof > +-> __vmalloc_node_range_noprof > +-> __vmalloc_area_node > > So kvmalloc should be safe now with GFP_NOIO. Correct. > Should we correct the documentation? Yes, please. I think it would be useful to explicitly name the above commit because pre 5.17 kernels or those who haven't backported it are still in same position and that could get dangerous if they try to backport [k]vmalloc GFP_NOFS patches. Thanks! -- Michal Hocko SUSE Labs