From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BABCED591AC for ; Mon, 18 Nov 2024 18:40:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2DFAE6B0092; Mon, 18 Nov 2024 13:40:33 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 268566B0093; Mon, 18 Nov 2024 13:40:33 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0BBAB6B0095; Mon, 18 Nov 2024 13:40:33 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id E2E406B0092 for ; Mon, 18 Nov 2024 13:40:32 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 9C16F1A0445 for ; Mon, 18 Nov 2024 18:40:32 +0000 (UTC) X-FDA: 82800078060.17.BC9B93B Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf07.hostedemail.com (Postfix) with ESMTP id 894E84001B for ; Mon, 18 Nov 2024 18:39:21 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=GeOY29sz; spf=pass (imf07.hostedemail.com: domain of rppt@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1731955140; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Zos79WCy1/02QSKpmxeP5Q08W8qZYSRZ3WbDy7F5oAk=; b=tWAPAgyhIP8XGzH2eMiEmUbXnm8keEiau7T76slX+G/DqViuMkOgJTZrGdxfitsYG6MHBu 1HATCixMg1x+exFy+b5VYisJ9INY4xdfRWTmuovAqpkMvc1HX0XaTecUGxgmdFrLLjQr8G jlp8Li0Ub10YvcOsqRLxftn0BgOXT5M= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1731955140; a=rsa-sha256; cv=none; b=yA3ru5mDHpsH9lBMb92sN6JJug7v2RQnjgJ0klRo0f1bsm/zKhez+tNpBp38wJHnwClHC7 RG8KQ4lLDC+EWiQ4o8hxqL/sfgyyLaQV1G9MQu96kydpvx0MLfYiuVQ+ot7j8T4PsHAEc9 VLPyzd2jR+9dNzNy8qM2Mm0VFJTjnjg= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=GeOY29sz; spf=pass (imf07.hostedemail.com: domain of rppt@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 11F02A419F2; Mon, 18 Nov 2024 18:38:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3A5AEC4CECC; Mon, 18 Nov 2024 18:40:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1731955229; bh=PgWfk6zhBX25rXxPAwmwUJeghk+GajLkQHlk+OfGUQc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=GeOY29szPjdxa0xm+vV9DTg2e5TPlxk7huuBMuJbtT+hTn5kPCdRWZ2oKgkC8UpSt VKEpF1/SK1ceIDW9rYbK4e2lrKnmmaewrajrem/5hOE+eL2aJiJwe2Mq1uUh3lhZ50 bF8KJonZOhyM89MpbuLHVivYouTUSuZbDmGNuIIUU6Sz4PBRF7AffgUgRIMQ22WWof 8/hSFdkboAANibLeqfLmV82IhRXIdNitXrU+lzbag6jN3GbbRMHw4voatyzJmOaEVn LYCc2cjDCBvkB/fCKjeR1Y3G/eBzyCxZ8foJEVKOfJ+JG689X8AaWtSJSKfiAkucWY LfgB8UgFNVmrQ== Date: Mon, 18 Nov 2024 10:40:26 -0800 From: Mike Rapoport To: Steven Rostedt Cc: Andrew Morton , Luis Chamberlain , Andreas Larsson , Andy Lutomirski , Ard Biesheuvel , Arnd Bergmann , Borislav Petkov , Brian Cain , Catalin Marinas , Christoph Hellwig , Christophe Leroy , Dave Hansen , Dinh Nguyen , Geert Uytterhoeven , Guo Ren , Helge Deller , Huacai Chen , Ingo Molnar , Johannes Berg , John Paul Adrian Glaubitz , Kent Overstreet , "Liam R. Howlett" , Mark Rutland , Masami Hiramatsu , Matt Turner , Max Filippov , Michael Ellerman , Michal Simek , Oleg Nesterov , Palmer Dabbelt , Peter Zijlstra , Richard Weinberger , Russell King , Song Liu , Stafford Horne , Suren Baghdasaryan , Thomas Bogendoerfer , Thomas Gleixner , Uladzislau Rezki , Vineet Gupta , Will Deacon , bpf@vger.kernel.org, linux-alpha@vger.kernel.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-kernel@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, linux-openrisc@vger.kernel.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-sh@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-trace-kernel@vger.kernel.org, linux-um@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, loongarch@lists.linux.dev, sparclinux@vger.kernel.org, x86@kernel.org Subject: Re: [PATCH v7 0/8] x86/module: use large ROX pages for text allocations Message-ID: References: <20241023162711.2579610-1-rppt@kernel.org> <20241118132501.4eddb46c@gandalf.local.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241118132501.4eddb46c@gandalf.local.home> X-Rspamd-Server: rspam10 X-Stat-Signature: sbrm9eqpgjetzuk4i1kjjkm5pzsdjd8k X-Rspamd-Queue-Id: 894E84001B X-Rspam-User: X-HE-Tag: 1731955161-735989 X-HE-Meta: U2FsdGVkX192xsOBfOpf6EhNmmC12rpwgJbKI8TeN1lX8xyFySL/xHmJtLLQWWjASsA8kZq3vY3Ul2zzhvNwsu7OvcvV2h68970xFADLybZXtukrB7+KKJvPc3bIAlnF2YB8onVAN2YZECFJfkGH54SqaVy8qbcTHZx2ITb9+oMR+/QEf2seUuGCodS/iAslt0zivZgKOJeuHSF0NLnsFb6GXJ+R2lF2idq3RwLTUEa5V7XVACH/U46cL/Do5fycszRkC5QBPisOf6RLc6tOOcfd2Jg4oxWCxqQxGEZcoRGlawdxI5NpuFrobxof//CTHq/rmpdQL3VlJJ7ZTpTkfjPRI9sBrJl/FYs0KtGllxcDtj1vS4DNff2iWXImSFMRi0ttZBbuosZOdkOWjwn/BcT8QxSxbskdG5aYfhXKeGArqqSYdcv3M9+QZzk3CanO3+ma26SJaXSU3hiJQV/ZivXukHE9kHSmY7ttIBcOWf+vUE0QhdUFaYZ42IDa+H5c7Fsl4m1QS8kaAW0a/fd/dZkMckC6B0eL3B94E8nbICtE1zq91UpDYRHsGLFvuFBmcTdsj3kqsH8E35tMV5s+ZcqdKkMEVonKe3TdSW7B0DXzPTemQ2dpKkWfG2V9lzFHF4f+9s4txNJWBENF49YzrBHb/JCR0lonX2xz9HZGAL+LVVqqpCzA2currGI5o9v6v/2G5YmY8GIzBMYL+j8cIkSuW7ncXFxh8wibMAfWu81tfnDTY7MswUHZ7jnWmVi0LkZc89+Jw0/CTKBHTJQ8yi1QIcKKIcv3MEaW0Iwn6lCCmEUkMG8ZN5UVP2ItZieM6ZM7d2buGjtOtargg53mUKOMNiDPpksp6SxWVGPlIoaSYw9koMCvN7ZvFNXfosAsTtRi85Ln2x9uIGULohvQAEFfndAq0dCb/1Oxe3s5G3fY2RhfV5bxmwiQ1jAiHF5P+HNfuRF9TDWxbHA2/tF BSH0Wile 3HrZm3jif5ko7zBjiLqS5y/tDUfSnhTwdEfERKkWSMSzBRkbWjSxNmnZMNjLp71inPbvpG3K6MYKfJZhRxibBOAiRecHyBFxrjQL50Y2hVCCqsKhuqwWbxMnJvBeNTy8/OV+7Zj6su3lWuaEzGSK4zpLI9Fzhtw0d/+iYcsGGsnRyuCcj+nAqRC8IwJ3mopDFEUa7naLvXpak1PiNL9BLyOhkjbOJsQrdz/8bI4JwDtAPhdhxvpuMzGHh5wYnQpwo6ouA51Hu3QUbSQf/OIPd1n4uhQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Nov 18, 2024 at 01:25:01PM -0500, Steven Rostedt wrote: > On Wed, 23 Oct 2024 19:27:03 +0300 > Mike Rapoport wrote: > > > From: "Mike Rapoport (Microsoft)" > > > > Hi, > > > > This is an updated version of execmem ROX caches. > > > > FYI, I booted a kernel before and after applying these patches with my > change: > > https://lore.kernel.org/20241017113105.1edfa943@gandalf.local.home > > Before these patches: > > # cat /sys/kernel/tracing/dyn_ftrace_total_info > 57695 pages:231 groups: 9 > ftrace boot update time = 14733459 (ns) > ftrace module total update time = 449016 (ns) > > After: > > # cat /sys/kernel/tracing/dyn_ftrace_total_info > 57708 pages:231 groups: 9 > ftrace boot update time = 47195374 (ns) > ftrace module total update time = 592080 (ns) > > Which caused boot time to slowdown by over 30ms. That may not seem like > much, but we are very concerned about boot time and are fighting every ms > we can get. Hmm, looks like this change was lost in rebase :/ @Andrew, should I send it as a patch on top of mm-stable? diff --git a/arch/x86/kernel/ftrace.c b/arch/x86/kernel/ftrace.c index 8da0e66ca22d..859902dd06fc 100644 --- a/arch/x86/kernel/ftrace.c +++ b/arch/x86/kernel/ftrace.c @@ -111,17 +111,22 @@ static int ftrace_verify_code(unsigned long ip, const char *old_code) */ static int __ref ftrace_modify_code_direct(unsigned long ip, const char *old_code, - const char *new_code) + const char *new_code, struct module *mod) { int ret = ftrace_verify_code(ip, old_code); if (ret) return ret; /* replace the text with the new text */ - if (ftrace_poke_late) + if (ftrace_poke_late) { text_poke_queue((void *)ip, new_code, MCOUNT_INSN_SIZE, NULL); - else + } else if (!mod) { text_poke_early((void *)ip, new_code, MCOUNT_INSN_SIZE); + } else { + mutex_lock(&text_mutex); + text_poke((void *)ip, new_code, MCOUNT_INSN_SIZE); + mutex_unlock(&text_mutex); + } return 0; } @@ -142,7 +147,7 @@ int ftrace_make_nop(struct module *mod, struct dyn_ftrace *rec, unsigned long ad * just modify the code directly. */ if (addr == MCOUNT_ADDR) - return ftrace_modify_code_direct(ip, old, new); + return ftrace_modify_code_direct(ip, old, new, mod); /* * x86 overrides ftrace_replace_code -- this function will never be used @@ -161,7 +166,7 @@ int ftrace_make_call(struct dyn_ftrace *rec, unsigned long addr) new = ftrace_call_replace(ip, addr); /* Should only be called when module is loaded */ - return ftrace_modify_code_direct(rec->ip, old, new); + return ftrace_modify_code_direct(rec->ip, old, new, NULL); } /* > -- Steve -- Sincerely yours, Mike.