From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29EC3D591A5 for ; Mon, 18 Nov 2024 16:56:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AA3D16B0088; Mon, 18 Nov 2024 11:56:40 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A53DE6B0089; Mon, 18 Nov 2024 11:56:40 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 943646B008A; Mon, 18 Nov 2024 11:56:40 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 731386B0088 for ; Mon, 18 Nov 2024 11:56:40 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 18B551C5577 for ; Mon, 18 Nov 2024 16:56:40 +0000 (UTC) X-FDA: 82799817240.13.B4C8134 Received: from out-184.mta1.migadu.com (out-184.mta1.migadu.com [95.215.58.184]) by imf21.hostedemail.com (Postfix) with ESMTP id CA8EA1C000C for ; Mon, 18 Nov 2024 16:55:04 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=XAa5sqiS; spf=pass (imf21.hostedemail.com: domain of roman.gushchin@linux.dev designates 95.215.58.184 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1731948850; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=59zS/1A05nM4M6tWzQtKALV91pOAZt9Z4V177dGFIA4=; b=x0TzBa94F30jR2o/UEnQ4/SqMFhFfMUPfum26FVzsvgUboL2YJbtPMWCAOjlyXHPdIJcOu dX1jiaclLtZI7qVGGFWTfYaatJcVijGpq5IrHpsSXgRKXI3lJc32bB3bOm+0l0PTG5OTUq ha2rUt8XWHDy5mfeMgD4cSL+R6L4S8E= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1731948850; a=rsa-sha256; cv=none; b=GspLOnpsfJb8t4ohumECGWj0f15tmmN9dZeck7mwPRj0E8OSJbegaN0wmJbnnfQqAfE6z7 eJWlCGFihAE7mrm3+2hCYkExKuXt/eS4pYNoTb2cjL9aHpyJJkJtsPpqfV/O1xccRnDpP2 Rnoqx5xUqTMyRa7l23TMX/RWiO1DdPA= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=XAa5sqiS; spf=pass (imf21.hostedemail.com: domain of roman.gushchin@linux.dev designates 95.215.58.184 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev; dmarc=pass (policy=none) header.from=linux.dev Date: Mon, 18 Nov 2024 16:56:31 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1731948996; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=59zS/1A05nM4M6tWzQtKALV91pOAZt9Z4V177dGFIA4=; b=XAa5sqiSA09ONIFQdTjTyerzgYSOFcQHoT32a0p2NLv3tpiBjMSfZwJ6W6St+SW7dMXSOV wzDOpyS2hU71eVWoIhWLa1gA6nvq+lvfxxBdOzicUd8TBCTb0n1IJ3af6Qv8Bl8jSqRK/c NcjQ+xtGFxNUs/8M0AwzOm5jwQF8Tkc= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Roman Gushchin To: Keren Sun Cc: akpm@linux-foundation.org, hannes@cmpxchg.org, mhocko@kernel.org, shakeel.butt@linux.dev, muchun.song@linux.dev, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/3] mm: remove the non-useful else after a break in a if statement Message-ID: References: <20241115235744.1419580-1-kerensun@google.com> <20241115235744.1419580-4-kerensun@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241115235744.1419580-4-kerensun@google.com> X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: CA8EA1C000C X-Stat-Signature: gf4ws3dmxkque84zodpfnn8dz6qd1f8d X-HE-Tag: 1731948904-850505 X-HE-Meta: U2FsdGVkX1/MhG645bUJtyMkbPgBwJmoBgp0n6X0gqvsLOYRpQZHRjQTzfNDzW5BcFcTDBV3lMEBjm1SAh+rnPJWm5TkRNBcjd/G8J0hrvNSJGrcxqevpzfJ3pY9Fd1xDYWwjuixTstMdM6X7eUaXdkiNrcpbKvv9SiUZLrtvhvBdRdFykZ5DvUDEDXVkNhgzhSfZKpSw/qn5Ru8rFwrZq7hlGLKs8JRthBkGmZlKevUtjyI3WL2LTbNIRWMm8KHSGw2XrPH++T01fkigXiFDchKqMiSWMqSQ/IhJFYqlTqDLTl4KUOEqQIfoFv2BdZ+fhp4VVkQTeKTtQ/4qe+zkwIi02f8SAHV5qhxHhIUKkTRTOBCeo9LYbK2h6mkEblmnUeZhT92AziK+sJmzn4MUe9+zeFEecOVLG5rtrUf3JQBJvD2KCjEXhZEKdcIgmkUosfXBFl3OSwFkUsi62y0oTbGrztWg2R46DmUilOElXjs3lM6K5DAg5kqQrlZkwYDVlDKhVlKduexIubQkB63aNFSnPOQkDdrVG+Wt1G2WuBrtrVhb/nfeNRdCZGPn5tTk2+fBFwsS8kJJ7mvBFAAMh1hjARo1Af0NkuOvU8qOL9XZ7X4LcsAsu/9smsn0aJPZ6y1vpOQsDcVZNJfBhRtRt4+mECRqxEajiV9konHqNS58GVSHm7TrXx6KnadjUbTeGH4JuM1Lx9i4nEbopYEjBuPpk5dRF64FqUqX+QNWA2BM/EFl2Xw8TzAmjJ5HkdB3Bddqak0JMxsySurSgQLLHTLLTjaAM/3osdZ61vmYDYe/DNyPQze/tsAitZrxVEyewnVOt87aVTIPyB4wsJvMnS3EtjTOn4yFRC4UA9mKdOvbkdSiVPPWnXW7sYr0A2wfYQDmh6KFKdqM+XLs9IJjhuWDZZ1NG8nSTbDWLIVaKP8zpfEWYh7m8quX+wtwQ1kIiKyFIeKlyWM/xokIpG DHbPkRn0 OGZIY/QQWPejqhOJSUrb3jYi0y8J319bdk3TlEwaKuY5AwDmldfQPryMQaq6N/toFHJRokMPRVbogn9l+clze3rmJUoQpfUAR9zvOCtBOgPKxzspKzeKjctZ3HP8f2OFykzV/FP0eICFO81L+INZygDttkosHigls101UZGIJ5zvREmJ7l1FvP8iQlWWKt2stQxMywWQv6A3cHrk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Nov 15, 2024 at 03:57:44PM -0800, Keren Sun wrote: > Remove the else block since there is already a break in the statement of > if (iter->oom_lock), just set iter->oom_lock true after the if block > ends. > > Signed-off-by: Keren Sun Reviewed-by: Roman Gushchin Thanks!