From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52F99D4920F for ; Mon, 18 Nov 2024 11:06:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B2D086B00BF; Mon, 18 Nov 2024 06:06:46 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id ADD3B6B00C1; Mon, 18 Nov 2024 06:06:46 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8E0286B00C0; Mon, 18 Nov 2024 06:06:46 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 60DE06B00BE for ; Mon, 18 Nov 2024 06:06:46 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 139CBA0149 for ; Mon, 18 Nov 2024 11:06:46 +0000 (UTC) X-FDA: 82798935786.19.BFC64DC Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) by imf11.hostedemail.com (Postfix) with ESMTP id 3372240002 for ; Mon, 18 Nov 2024 11:05:42 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b="V9R9/rFr"; spf=pass (imf11.hostedemail.com: domain of pmladek@suse.com designates 209.85.221.54 as permitted sender) smtp.mailfrom=pmladek@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1731927761; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Q4K7ZFgLQYJQlGAzpq8RK54g3EqKOomWWOR+yhsr1qw=; b=yJeAOAIqIpg/01CEkUeJyon0lQOIR+xGwMRFTQecjm38uCfR9fpUb/eSoOHU/zKpV3lpQ0 d+92R4fHuDaNjgU035xzvCsChYSFNkjEq8J/Q7gWmfWdcseogS3xLCPQP1TU2NC2RI6ERt PGkodIRMU3VUgvb4zwRkdifGcYr14C0= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b="V9R9/rFr"; spf=pass (imf11.hostedemail.com: domain of pmladek@suse.com designates 209.85.221.54 as permitted sender) smtp.mailfrom=pmladek@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1731927762; a=rsa-sha256; cv=none; b=bXpxoxNnVbcZbqnUhcONrEHBO4NZTkBEV1tmxsJiN+UcJyNyTFdJ9RCYtEY2aXnyFJoMFN KJwSKS4jVVIDJ3Tt7tYW9v1xtuyiFtkyZUC9lvHCHt6sf67aPJr9r8opxdc0iKNvaGR5hP bUrIUt6J54bsnHXr6rb6TVxmk4gm55s= Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-38231e9d518so1642815f8f.0 for ; Mon, 18 Nov 2024 03:06:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1731928002; x=1732532802; darn=kvack.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=Q4K7ZFgLQYJQlGAzpq8RK54g3EqKOomWWOR+yhsr1qw=; b=V9R9/rFrPsA79owbs7ezUl84RpkweNITkKhvDMtz0nrSxmt545uGsDVnJb5GPyu8dv L89Mv4jWK2WTLq2SF5Z5If5TnDuY2aRyVrCOvhH5dtJxbwAtz6YbvR7fmkvHJ89HrxZX 5Ap8mYwGI98UU5/pa66BEoq4PzBGqLHW6h3pOWutcjHg66/prRUKqsv1d93cayQvzTf8 2nLEQhT05sWlT2L7+/Y1yXUCm6K6l/tID9HSiB95rjmr/LzyFd7D6Li/ZSFpJnLheWmJ IYpbkC8Dwz6ICCBEKMJ34ZwqTHm5tXDxHVDfZMXY5o2WFDwjUZCJvto5Bt8Nkydz3NyI dGGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731928002; x=1732532802; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Q4K7ZFgLQYJQlGAzpq8RK54g3EqKOomWWOR+yhsr1qw=; b=TKjtW7SDlAKIOkshVhuTumC0+p2ZTpi6tm8QHqhAZGVweHFusnl2J32mBJe6V7sWIW xz6baT+m5WpDJTxIC1c5w6QO0L6IN/ELNgWLvTS7Q8Md+p+056IQjVwWEqGjylK7AmqG V1gwrVKi9NNTotgO/IgfYMJnylwtSpw5JmvG2gVooAxmMGXnUpjHGK4uK0//rrwbsNHQ PYbrTLAwqIJoJ/WiFGlhO5WyB6SteaXH8M5X18joxEfiyw1PuWvmqJcLovwo5C+CvaM0 xeneiuH8pNd4ESTYid2TGUCEOmv3ZlJDrF/yyhwF2hyDFgUBUK/2ic8rGGuRp+S9xuio cL0A== X-Forwarded-Encrypted: i=1; AJvYcCW0db7z+VXS7fLexdmnA5S9OiAhxTCHl8hxx2SIHj2Lm8HBqyvcmwjTs4MaT0i7ehUtZyH/V4g0EQ==@kvack.org X-Gm-Message-State: AOJu0YyE52dN56VEhHTeLZM0vhFwha319lUpqbqEbzvPG6kFPtphI1EO o/jPQ01s2md4yjfbgRIducvVKNJGwkUKdJaWdjS69qcEJzAfwvBqb7FgYFh7auk= X-Google-Smtp-Source: AGHT+IEHvVmgRYFNhCs4UC7E5RjVk5JwGYVdnUZOYcUXsiEIWSohYFEZO8cTVp2lMrq4C8xPl0BQ1Q== X-Received: by 2002:a05:6000:18af:b0:37d:4ef1:1820 with SMTP id ffacd0b85a97d-38225a91e80mr10392779f8f.40.1731928002298; Mon, 18 Nov 2024 03:06:42 -0800 (PST) Received: from pathway.suse.cz ([176.114.240.50]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38242eef982sm4319340f8f.8.2024.11.18.03.06.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Nov 2024 03:06:41 -0800 (PST) Date: Mon, 18 Nov 2024 12:06:34 +0100 From: Petr Mladek To: Christophe Leroy Cc: Easwar Hariharan , Pablo Neira Ayuso , Jozsef Kadlecsik , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Julia Lawall , Nicolas Palix , Daniel Mack , Haojian Zhuang , Robert Jarzmik , Russell King , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Ofir Bitton , Oded Gabbay , Lucas De Marchi , Thomas =?iso-8859-1?Q?Hellstr=F6m?= , Rodrigo Vivi , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Jeroen de Borst , Praveen Kaligineedi , Shailend Chand , Andrew Lunn , James Smart , Dick Kennedy , "James E.J. Bottomley" , "Martin K. Petersen" , Roger Pau =?iso-8859-1?Q?Monn=E9?= , Jens Axboe , Kalle Valo , Jeff Johnson , Catalin Marinas , Andrew Morton , Jack Wang , Marcel Holtmann , Johan Hedberg , Luiz Augusto von Dentz , Greg Kroah-Hartman , Florian Fainelli , Ray Jui , Scott Branden , Broadcom internal kernel review list , Xiubo Li , Ilya Dryomov , Josh Poimboeuf , Jiri Kosina , Miroslav Benes , Joe Lawrence , Jaroslav Kysela , Takashi Iwai , Lucas Stach , Russell King , Christian Gmeiner , Louis Peens , Michael Ellerman , Nicholas Piggin , Naveen N Rao , Madhavan Srinivasan , netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, cocci@inria.fr, linux-arm-kernel@lists.infradead.org, linux-s390@vger.kernel.org, dri-devel@lists.freedesktop.org, intel-xe@lists.freedesktop.org, linux-scsi@vger.kernel.org, xen-devel@lists.xenproject.org, linux-block@vger.kernel.org, linux-wireless@vger.kernel.org, ath11k@lists.infradead.org, linux-mm@kvack.org, linux-bluetooth@vger.kernel.org, linux-staging@lists.linux.dev, linux-rpi-kernel@lists.infradead.org, ceph-devel@vger.kernel.org, live-patching@vger.kernel.org, linux-sound@vger.kernel.org, etnaviv@lists.freedesktop.org, oss-drivers@corigine.com, linuxppc-dev@lists.ozlabs.org, Anna-Maria Behnsen Subject: Re: [PATCH v2 19/21] livepatch: Convert timeouts to secs_to_jiffies() Message-ID: References: <20241115-converge-secs-to-jiffies-v2-0-911fb7595e79@linux.microsoft.com> <20241115-converge-secs-to-jiffies-v2-19-911fb7595e79@linux.microsoft.com> <718febc4-59ee-4701-ad62-8b7a8fa7a910@csgroup.eu> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <718febc4-59ee-4701-ad62-8b7a8fa7a910@csgroup.eu> X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 3372240002 X-Stat-Signature: aw4awg6p7oseozub7mg4fnkpfnx3ftu9 X-Rspam-User: X-HE-Tag: 1731927942-102029 X-HE-Meta: U2FsdGVkX1+aDfhXTkHVfzCUWVHy8fZHaIISWG40A5sjdZts85Qs59GzOl475USSd1oQJ4vUdLVeVd9PlhYeDGv3E+FlPDzuGbXoHLq6+Ejj6H3tiAjnBb+Gm8kUTD/4oEDY7+4kVqXXv/hHRAewGU2qU+CXrug8Jn//t+h+ONqDbsoClVhr5Epdzc8FvPZ9fJzmUypk8yqYiv+XXX1Xv+g5skNnULujMVAw43xQfqUrE50seoVkeLeQhOnSxULG6ik1eoz1IwFr8rIv92oc+Yy228tOJRyXupe14Sbg4KLKmzQEFZMIJe2qPDSxCLwSUPcEAGJys1dSK6dqEixdpi6yZRsgHrOq/tE8RUuTm7FPU4e2no49eY0zq7qvCsFQG3ZNupzJBLUF6U1xIXad76/PJuqU0lLumg4zd3xAHuzUs+th6IML5lcOY8vX50UmGWbGa7Dx5TJhgdlwf/NJYts6M3JVfXHNZIt/YgDOCFylqB6IdaG+pE3vPK29353n+CzUJjnfbpmLEG4F/I+I8eubLovQpPGmF1Gju/p106CrHdlxH3QGP3zhX0hvSjYGxE1B7fOOxH0bXmfAv9ozyfvubIx551z60ewge1MmJJnlsw888+ScX6V9O0ZqroySuAasCexLEUekBwF2k3dS+OTpqLeoM9StMJPDvUXEAsArbyQDhrytcxsGu2X9TEryRLIzQiy7U7mtDJ9FKTA7OKvGmMRcBhE8jREKhAgoQdzN126PwPLgqEEPU8OMYemqijK8OKFGkhsbgFlDQ0I0To7kc+JEzogbYcLhwAHMfutRl95Nt1LSvABVibtIqGZ2/Cu0hbbBYGE1IDY0ldvacd7B7PreSU1FpbA/B+4ziqX3LevdLzl//XKJIxAujYR5xkGWkE5CgZkwUkhKcVv6ohzqNwhKqYNenE7HLUXdFCdmBEGiBPvwpO3TQa2lUUZqsd3zBMRhN2oX9lcIp/u Q7RFiV51 P8FCGUMpCBUJXbuWXWXgzq6W7eSuL7OCtfdZYuHSZPl2vXHw039HlGUtkvN8mS+I1tm15UWUkovrCOaUF9ck7o9VGuP8jQpi7ZI6oU/yAEuC3P83n+sGRD3lM7AQ3v6hZFujrIMHpj901t4fXCgk7rSQlcHAi0KqBJxZGbJv/1//nLGVZ7EWSbTqfb9j8UnjECd2FxDLAjujbnYo9VD3Ap3sHHfiPF0o+on+1lTE9Tnz2gRqrHfjHLcsnImoDXSskqT5lGqKbujaidpxNstjmA2J24BUvbgkBgOTY7e25vnBiKf/TpEn/2H8KmkwzlhZltWoDG92P3CzHPPrcew8bS9e12OO0vYvmvA7gbiTtPQAaFQh5CJL4p+nT1HR87+B1RDhxlXeHMR3Cv3MpniTfVF7KcKUgiRN0GKJ/bXqR5Y29/Wge9jsO3C7WG5WUecNVSeUdRFcn2MO6PinUxKjUtUt/19XUu1U/+Kd2 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat 2024-11-16 11:10:52, Christophe Leroy wrote: > > > Le 15/11/2024 à 22:26, Easwar Hariharan a écrit : > > [Vous ne recevez pas souvent de courriers de eahariha@linux.microsoft.com. Découvrez pourquoi ceci est important à https://aka.ms/LearnAboutSenderIdentification ] > > > > Changes made with the following Coccinelle rules: > > > > @@ constant C; @@ > > > > - msecs_to_jiffies(C * 1000) > > + secs_to_jiffies(C) > > > > @@ constant C; @@ > > > > - msecs_to_jiffies(C * MSEC_PER_SEC) > > + secs_to_jiffies(C) > > > > Signed-off-by: Easwar Hariharan > > --- > > samples/livepatch/livepatch-callbacks-busymod.c | 2 +- > > samples/livepatch/livepatch-shadow-fix1.c | 2 +- > > samples/livepatch/livepatch-shadow-mod.c | 10 +++++----- > > 3 files changed, 7 insertions(+), 7 deletions(-) > > > > diff --git a/samples/livepatch/livepatch-callbacks-busymod.c b/samples/livepatch/livepatch-callbacks-busymod.c > > index 378e2d40271a9717d09eff51d3d3612c679736fc..d0fd801a7c21b7d7939c29d83f9d993badcc9aba 100644 > > --- a/samples/livepatch/livepatch-callbacks-busymod.c > > +++ b/samples/livepatch/livepatch-callbacks-busymod.c > > @@ -45,7 +45,7 @@ static int livepatch_callbacks_mod_init(void) > > { > > pr_info("%s\n", __func__); > > schedule_delayed_work(&work, > > - msecs_to_jiffies(1000 * 0)); > > + secs_to_jiffies(0)); > > Using secs_to_jiffies() is pointless, 0 is universal, should become > schedule_delayed_work(&work, 0); Yes, schedule_delayed_work(&work, 0) looks like the right solution. Or even better, it seems that the delayed work might get replaced by a normal workqueue work. Anyway, I am working on a patchset which would remove this sample module. There is no need to put much effort into the clean up of this particular module. Do whatever is easiest for you. Best Regards, Petr