From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68C2BD6DDF1 for ; Mon, 18 Nov 2024 06:49:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 648068D0018; Mon, 18 Nov 2024 01:49:16 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5A9E68D000D; Mon, 18 Nov 2024 01:49:16 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 44AAC8D0018; Mon, 18 Nov 2024 01:49:16 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 146FF8D000D for ; Mon, 18 Nov 2024 01:49:16 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 79F5C40121 for ; Mon, 18 Nov 2024 06:49:15 +0000 (UTC) X-FDA: 82798288608.14.C67FA75 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf13.hostedemail.com (Postfix) with ESMTP id 17BED2001B for ; Mon, 18 Nov 2024 06:48:22 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=NBMWwnSa; spf=none (imf13.hostedemail.com: domain of BATV+563b79e71ff251933831+7757+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+563b79e71ff251933831+7757+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1731912353; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=kOlSN2LA06OzE6644+n7itNYM1OkhAQ52vQl+1dtIKs=; b=U3S2GDipC4D9yIhyKhE+VT6huPFZykfVmpQ/yCVJ3khsROOAH4C55Z/r9HourQh70g1tq4 a0xeFtWKnimC2Kr/UnmCifdfS+jtgjWUUGYWXol/RnjvTmwwo/GfAmJGHm4HtGhQULL4YA U7ajVLssAZF2vRfU3xdNtI8w9us7xQ4= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=NBMWwnSa; spf=none (imf13.hostedemail.com: domain of BATV+563b79e71ff251933831+7757+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+563b79e71ff251933831+7757+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1731912353; a=rsa-sha256; cv=none; b=o6LVarvmwGWHrp0KAAP8diOd3+1Y9KamBBRsrPftJsVGQclNH7+Ta3o1ZXMTDAJQing1qz QtdHKanjdAkvOwQsnVQcxWpnLdh8AfP8i+Lfp8BgfYsN8FjyG543gXxE6Llu/IgAGato4L UmvBM7XY7S7fAg1QsmXsPVvcTKUu3wY= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=kOlSN2LA06OzE6644+n7itNYM1OkhAQ52vQl+1dtIKs=; b=NBMWwnSaPc/9xDibTvknY6r0iC Hh7I8oTd1dZMPrFyEml6PB6AAOMNeNm0SWS4OaudwOPvvxcwKW29PqOGaqP0UyZJQyLlNLqRcxDP2 Pzz/1ibDFKeQrNAnU//VVjsfQ6gG6AXU7rZLEl5aJ4FZcOym5IUGTbcGqe+b50FbizTFXfUp9Cqa4 EqmkJKs7fVlO61ReuTOb7xuZ8i+ryTxh2bcY/qKXxHerJIBsWU6MUqaX0h4SUnsPtkWbZx542lRmD QPphpmKYXVAgY4orJZX4F4S6txiPCoeNm75Y1bJiiCsCB4M2stquegy5NHLRZY106VxQm5ZNiS1HL CJe7scig==; Received: from hch by bombadil.infradead.org with local (Exim 4.98 #2 (Red Hat Linux)) id 1tCvZL-00000008Ysl-04P5; Mon, 18 Nov 2024 06:49:07 +0000 Date: Sun, 17 Nov 2024 22:49:06 -0800 From: Christoph Hellwig To: Pasha Tatashin Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-doc@vger.kernel.org, linux-fsdevel@vger.kernel.org, cgroups@vger.kernel.org, linux-kselftest@vger.kernel.org, akpm@linux-foundation.org, corbet@lwn.net, derek.kiernan@amd.com, dragan.cvetic@amd.com, arnd@arndb.de, gregkh@linuxfoundation.org, viro@zeniv.linux.org.uk, brauner@kernel.org, jack@suse.cz, tj@kernel.org, hannes@cmpxchg.org, mhocko@kernel.org, roman.gushchin@linux.dev, shakeel.butt@linux.dev, muchun.song@linux.dev, Liam.Howlett@oracle.com, lorenzo.stoakes@oracle.com, vbabka@suse.cz, jannh@google.com, shuah@kernel.org, vegard.nossum@oracle.com, vattunuru@marvell.com, schalla@marvell.com, david@redhat.com, willy@infradead.org, osalvador@suse.de, usama.anjum@collabora.com, andrii@kernel.org, ryan.roberts@arm.com, peterx@redhat.com, oleg@redhat.com, tandersen@netflix.com, rientjes@google.com, gthelen@google.com Subject: Re: [RFCv1 2/6] pagewalk: Add a page table walker for init_mm page table Message-ID: References: <20241116175922.3265872-1-pasha.tatashin@soleen.com> <20241116175922.3265872-3-pasha.tatashin@soleen.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241116175922.3265872-3-pasha.tatashin@soleen.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 17BED2001B X-Stat-Signature: nytgbhfcr6uwrfc5uzktz9nim1ft99dt X-Rspam-User: X-HE-Tag: 1731912502-850464 X-HE-Meta: U2FsdGVkX1/LA7vR6AXNvR4k8U9LDZU+pTtYqS6DQHME7XwKtRIPm7XShq3m8d7mGUmcMAwGYat+diZabI01Q7GfTUvZqQ+JSkE1AYbE1gl3lwlIcyIoa32JITzO+yPuOHXJ7c/JF/PcEXOjKn8KjTWvUoTxWANJ9L+GxzcgDlcLEufqjZkxU9YBs+CShbFMXoTUVgKImlSnpRA+4gesFxfhf90iAHcrZGqAsD+VHWWF+7Me7tHkr2LEKmpslOiODEc9ZwALfvDCXMllgoei4jlWrbesqZzGCZ+acPj7Y0nmjWqgggwsiovJJ/6QvM3CqWyXOlc5MFSrzGJbZ5RV93qNBhov8oHZk/h7xjqnF5GKpyXgL0ErAyL48yu5bAWksMe1NBsPJ1Rg/2jSzg+dev+JF+zH9yQV/5rN/63AIsOV2S5kJDkyf409F7plpfMYvUiX6CoT3bkkZ2UkZWyILMQoIFYKsXIpddGTTMtLM0f9uODKqzwxwD0/WlssX+JriV/Yd/cuC3FwE37hRyDA8QiHy1t5ntRPIWy2xz1//8qc5HIHN6AIboHhVUaCLpYNRkO3/ZGXk4Fc+VrKl5gROHVuL9Qd8CSrYsYrm0sqUZZS0E/mhHKwUwCXaOh2BOiYRMIXSAaHMY+t1DcwTrCc7WbmJptNheW0FQ+Tp52jQqCvbh1hTh1U5ghhj8aFN6/6XHfPM/ymAh+7pGmLFIecIuNmdQRWTM/BR5H3bkxhoFxS0T6keoFyCDLErntyQQ/lhosxnvaLrPB//Cy0Gjey2XS0/Q5xxPQttcdmdtbXB0sLuTahd3wpG9RdEbyMkka7TFf54TWGKppb3SrJX8O0u3Cj4ciLFuD4i34WR4mHTWUN3q6zSrUF7DPk1w/u4+U9Nz3XaJHHZ9F2tmuj8KDgVoT2Yj7kJaCdub8wq9WG/MJD4bDAZMdJv1a+13Z5QKgl33l9SyMLg6dt05Ly9SR Y/jArFvt K5IDY1h6414ohK/CHT1j6ryAMF1W+GG02QE4zBoFu9m1U0q50TjB1uuz7i4ikBSr78+M5Ed1Mgp3qzLs5jOiek2doBEay2IpEEDtUau1osqggOIKrjdqokkDZq3TNjfAuqlV/64oYaTAkM8ITFdwWGeVaElpaRiPN/1S0HjKBxLPr8cD/79ab18forfUh8MJoxwKidq1B+dq8ZEkUUXFrzQ/8q33yz5I1cJA5k2sOj8amoWgPh8grUIstvG3qGZLBL2R/EY5qWoOSpA7vRlS/xrM5ou9Lz/L5cyIJdJoGHXfJP4wEE5imtHN/0yuu1UEKBVmZmrIYvVlWeoRDvcllvPrVG5sX/xvJdARertOU0lOwSREkI4X7+8WW7ISkKR8JP9MpI1qs2QQxN9TBpw+cSwZ6eztcNMQdgZk6FTb8Rlj8Omto1ORqPN4k9mI3TX46TOIGUEOri4wwERjMxN5gpY3AouCD2hznFHq/sA53sVwbOxK/La8flra7BbZ4oHq6wjkCZj93abScvMUe7IYH19qmqQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Nov 16, 2024 at 05:59:18PM +0000, Pasha Tatashin wrote: > } while (start = next, start < end); > return err; > } > +EXPORT_SYMBOL_GPL(walk_page_range); Umm, no. We really should not expose all these page table detail to modules. > +EXPORT_SYMBOL_GPL(walk_page_range_kernel); Even more so here.