From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BFB94D68BDA for ; Fri, 15 Nov 2024 22:46:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2F93B6B00A5; Fri, 15 Nov 2024 17:46:46 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2A98E6B00B8; Fri, 15 Nov 2024 17:46:46 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 14A506B00B9; Fri, 15 Nov 2024 17:46:46 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id E8B576B00B8 for ; Fri, 15 Nov 2024 17:46:45 -0500 (EST) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 991261A070D for ; Fri, 15 Nov 2024 22:46:45 +0000 (UTC) X-FDA: 82789813806.06.A1274CD Received: from out-171.mta1.migadu.com (out-171.mta1.migadu.com [95.215.58.171]) by imf06.hostedemail.com (Postfix) with ESMTP id 378D318000E for ; Fri, 15 Nov 2024 22:46:10 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=Whyit7I0; spf=pass (imf06.hostedemail.com: domain of roman.gushchin@linux.dev designates 95.215.58.171 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1731710746; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=F+XkfQkv61y6MHM2C1K/HEDEHbXtzc7+sIRDedcjJLs=; b=TXiTUI0OMgkQfeHcab1gi3SMsY6svNs4HHRwLOPjUwJznGmCxeFz5aXeB2dm+UbtlcSTb4 3jNmbZOZYylgxlDcSJvLyxdVtA+LtCmcKGjpRKLyWjORdVL0O9ZBEgeIdI9rT8GoZJRXho FFw6Atz5ChYL1wBHBvMC30akYrDt/ic= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1731710746; a=rsa-sha256; cv=none; b=pOGDEsovyFev7v8c9v9pctX6viRpg0Ax+uCsGZGLrks5iytEmxc1fWmxAwqLEtL9E12nHQ MbMmX+fR1wa5kOht6otjBdeTftt9ACX9HPpkjyR6oLvfttFNLlGgxr0vbGXOAbH+4zavpg Xgm10pyLZFmiY3KCrtiWAmt4K8ZRORQ= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=Whyit7I0; spf=pass (imf06.hostedemail.com: domain of roman.gushchin@linux.dev designates 95.215.58.171 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev; dmarc=pass (policy=none) header.from=linux.dev Date: Fri, 15 Nov 2024 22:46:35 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1731710801; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=F+XkfQkv61y6MHM2C1K/HEDEHbXtzc7+sIRDedcjJLs=; b=Whyit7I076zGP5Iwr9ST+6OduULZjhg5bVi+kdfyPiaGLRPb4VHRWI5BJd5by6z9h4taTa eu24NjZErNOggMrWrp1MDnHzDfGiBeLd7kwRPpIDowL2Bh/fbwqXjz7NuLubtNB4hTHxJ/ yWosy5VPqBgnWfQmUoaZXoekT93lwr4= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Roman Gushchin To: Shakeel Butt Cc: Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Michal Hocko , Johannes Weiner Subject: Re: [PATCH 1/2] mm: swap_cgroup: allocate swap_cgroup map using vcalloc() Message-ID: References: <20241115190229.676440-1-roman.gushchin@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT X-Stat-Signature: g7ugopsgttdbqp6bt38c655gq6xynkqi X-Rspam-User: X-Rspamd-Queue-Id: 378D318000E X-Rspamd-Server: rspam02 X-HE-Tag: 1731710770-717082 X-HE-Meta: U2FsdGVkX1/5QGBB2G2FdYVif3wrELQLpJeKqQ3gLH/O7BtEH79IxEnrUlVPvdGO1B04LSXgc9U/i++egNGF8iYY+nYN0MyLDw+lSL40FltiiymXPnmq2mwvY8TAGbObqK84aFXUbpHfcMn7ZMptEVyuDq+F4ji5rEz3Zb2rtiMeK9dJEJhofNvslUaxLkcyuZBv6LrzYO4jLBlhaTxuE0kJ5r3Zlp30tbQUOvNQ1Tb9DU8CAUfsn41PaAkaYdvNeY9Uf0WPxDb8Rv60XLi771h6KNW2wJmIeAo8SZ2vxBZSHKtnXutBL6fCYObq+kgYF+fg1R33ErHthXPrgmS6hCo5WWfnyPDxvsfLNJS1OrR+1IVKz61tgmg8aEfNzSToDtdal4tFZF19xkzZfKoZNROGXoQFr4GwS4/Lahg+x/p85KjcQBGmWixKULep+x8MGkXY59MERE633F6/sHUBBRgkTJ68sVlMCBQVMlqPvIB3mYjtnS3qIQPXWN5GwM/zldF7FRgKR0xLdAsExQr3bODIq7eyvTjYQiDsywhe+cuP2w8Gt4AvCocM2sH+o84ZVL/xvRStTJ/tq9Eouu2QpXLm5Stq6ZIZVomvRpfcKXbcUzId/Jcw8+1FM2lQuF4PblBFpfGYifYZvkScS6IXeqiGDF33xr+UslmGnvy6bJukZxDhgOLYfCOUX+TPUy+4v6XIcNejm+tNF+YFoIylxEsTk6hBnGxQrUwDsjzbeKvSx9dhKq2g/j6eT/GWVxMBTf56HimL6uBIW+XjyK6X919wPKd0g9vOi84+NEpraN8scl+cDW9hcWxXoDepPH4pTuVR1qIJMJ+O5PoSh1EFuD+kjclxDwK6Lext4aXohENyJeDOqF17sCSXDeCEAEatUg88V+MyRh+xvePPMOtR3g+MPwDHHyHqW19rLNs9kQ46Yti7kLasoJGbhoB43U4tXQdDW51tLT/xpU6AT1+ +lmEWSHD OkMC42CJB//1ePv+tgTGgFBlbkDTyKh3mtul4fzJQ41o8KJX0mN0j+WUn9UtXXeDODB3HzAyyLVtwCq5Fdluuap6Ytp+DHGNOwC2utC2BJWmm0kLu8lXsDFSZzUtWoxWv8G08zcQnAqZV9PRqL09k7CdgT+XSYTa5n8PUxbiAuOCL+5Ejp3wV9dQBPUHU+RFMt8bYbmv5WCv66Zm1+Wvr0FE+xKwBnkL70bRj X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Nov 15, 2024 at 12:17:43PM -0800, Shakeel Butt wrote: > On Fri, Nov 15, 2024 at 07:02:28PM +0000, Roman Gushchin wrote: > > Currently swap_cgroup's map is constructed as a vmalloc()'s-based > > array of pointers to individual struct pages. This brings an > > unnecessary complexity into the code. > > > > This patch turns the swap_cgroup's map into a single space > > allocated by vcalloc(). > > > > Signed-off-by: Roman Gushchin > > Acked-by: Shakeel Butt Thank you for reviewing the patchset! > > [...] > > @@ -215,19 +169,8 @@ void swap_cgroup_swapoff(int type) > > mutex_lock(&swap_cgroup_mutex); > > ctrl = &swap_cgroup_ctrl[type]; > > map = ctrl->map; > > - length = ctrl->length; > > ctrl->map = NULL; > > - ctrl->length = 0; > > mutex_unlock(&swap_cgroup_mutex); > > > > - if (map) { > > - for (i = 0; i < length; i++) { > > - struct page *page = map[i]; > > - if (page) > > - __free_page(page); > > - if (!(i % SWAP_CLUSTER_MAX)) > > - cond_resched(); > > - } > > - vfree(map); > > - } > > + kvfree(map); > > Any reason to use kvfree() instead of just vfree()? No, you're right, vfree() is a better choice here. Andrew, do you prefer a v2 or it's easier to master a fix-up? Thank you!