From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1D26D68BC6 for ; Fri, 15 Nov 2024 15:41:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 654608D0002; Fri, 15 Nov 2024 10:41:27 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 604278D0001; Fri, 15 Nov 2024 10:41:27 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4CB318D0002; Fri, 15 Nov 2024 10:41:27 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 2B3CA8D0001 for ; Fri, 15 Nov 2024 10:41:27 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id D4B4F1A18CB for ; Fri, 15 Nov 2024 15:41:26 +0000 (UTC) X-FDA: 82788741252.09.C88A54C Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf29.hostedemail.com (Postfix) with ESMTP id E8F7D120028 for ; Fri, 15 Nov 2024 15:40:21 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="rF/xwhFw"; spf=none (imf29.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1731685228; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rN0VV+QMDPFN+9xKl6ueIBNUAAjrXYREa5ou/2rKpc4=; b=XvjjRwBdCoc9Jf9OMME7bt+rPQMUZyQ5hbt1qdriVFcsNWgTFltxrxdEbjgSkqnVzx/O23 EPbISDPchvOV9KHBL8Jozh+IPIB5RFsbpx+Y20dohuAGpjos0NZYQrRbyHPInQGtsNuJjJ 9qlYna2Klw4iA+rYLCLt7NoA1yGnCzk= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1731685228; a=rsa-sha256; cv=none; b=neye8Y0clr0A9BHgBNYseQCHBDKkyQMJFJpBneKgHFj854iYIIbm3q2lHTGRtRDbyOGaJo WqlKxVdCcxpKrY+SR3U+esPc/02Q5T4ZHlwPTZQ6jvZ05NaGp2+QNdhd5rSjtY66pPRFDL sqA/qaYf94zJZ5uKqwJvlOdYcliWYw8= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="rF/xwhFw"; spf=none (imf29.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=rN0VV+QMDPFN+9xKl6ueIBNUAAjrXYREa5ou/2rKpc4=; b=rF/xwhFw/qiY91fWGAVjzk0NDp w/0oij5rI+lkWe5lUJkwrMHxBOr1q7Nvtpc2A94nbD+qKE5lImA1/IrOLUxzcP7icMtHL5cqlM1AV mfbz5M9HeyuNTESbTgOUBZzOaj3b7VvYP1QjTcOxonkvTiYphonNFoStGi1Z4tx75iEe1YbgYNxND K4B6OiO1DYPqhNrFow3ZJZB5z7o26XM71MMSR7jLsAb4ArPEoyrZM+dcgb6JMT/f8flMDbMIpcoXu REG852g0yi4bq59xYLUgEyGlXPMijxJRdO+tkqM/HRapym69Zm07sq1qM1N16a4YmnTgB4bSucqD7 97Zn4dCw==; Received: from willy by casper.infradead.org with local (Exim 4.98 #2 (Red Hat Linux)) id 1tByRi-000000003M6-2fEr; Fri, 15 Nov 2024 15:41:18 +0000 Date: Fri, 15 Nov 2024 15:41:18 +0000 From: Matthew Wilcox To: David Hildenbrand Cc: Gaosheng Cui , akpm@linux-foundation.org, wangweiyang2@huawei.com, linux-mm@kvack.org Subject: Re: [PATCH -next] mm/ksm: Add missing IS_ERR_OR_NULL check for stable_tree_search() Message-ID: References: <20241024032300.2501949-1-cuigaosheng1@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Stat-Signature: omcnpo5psbrpjwugnkfjizsp47pgqopz X-Rspam-User: X-Rspamd-Queue-Id: E8F7D120028 X-Rspamd-Server: rspam02 X-HE-Tag: 1731685221-909790 X-HE-Meta: U2FsdGVkX1/Bi1baju8ESvM0CEKZUadsggD9cIMzHHpjk/6Q88avbTdvQm0TzODQyDbjss4//CsM/slTRrKIduH3WwaQOAs4BNqphwJYN+EZh1LQ5ghBKph1qjqJJ+F147eMWZTCHAdDml4dLd75u4eXyYiTjAIGDT1E8ED/WLpxCVP2RtKgn34wNTIzyKCifZBzX51xB3nSGwIO/AxSl6uSToJibJOQquwjhmp9ayvkqT6SMQGE/iPIQfhjL+lxtxtEyAqGT503jQWde/W0+goCvIhQozQiYwGOwIU8hnvQ8HmG41XjQtdnwdlGV9o6hKSfiHmHuh/h1Jt8Mb+JZEye15hooU62Hf7nvIpc3N7lR/IE1pfyhGFmPU2cVLO5mcFRJPrD3ceHbEhlnj6/m7dUk/GzxYukFe1En+o8V0zUzQVbKWQb4xWqnupzlEpvdEfzQShOpejnv12UiPxQcUBrIlf17TIjLxzc75eJJxdDpYU9BNP62Vmh8HYYrJyM3MxG1Xc9gyAsgnIG6CrJXVZwCxAbH09TpsoVQat7WnkoRTWSWTlu4UBjwHKBvYUnMeR2jxVgnIE3605eNIBa61d64y/lvXyHYTeKcSOuw4gB/clDKb29TS49DjBSl2WxRqUc9lGVULXhGH7vcS69P1GhQ0LU38g2+bWWrn4DJ5GQM/zhrETDLAeuowPN4WRfVIAp3+NIr/WjAsO51/JS8+WWQUhsNmpI545bKOqAoWBNwFTT83Girf1X+do/p0wDEUcMqLNQtVneJchgAsLf8Gqp+La18oXURRphXAVtIATqgvmJnm5SAXOoJsLB+Jf9BDlXa5uGH6EbQNIRexcFuepXOCeLnwR2ilM3QaeUuh8lfeBpDwruWtb7ZSHStKnw8Cv8tmh62+jajy4Po9b369j4A68c0Iq9U4zKnQUWnoqXvMLHca/EJ2FK15E+VKvLIisTb7NGNwHV/NzSTd2 KZ6kZKpq +VqnNFbgAE7/OwqWa9Z2m4SL12gV00LEyns8FDQio6/eDGFbbVgwX8YltJB6tRQQG0jL2LoaB0gHDgbuwa6FleAkG9dbCekbgJjB3LNumKHkAmAGJ0OvP3tE38jOZmeRtvOpi+vGzwD839P6a0veacocN7tibWAdWoxpIt5wgW9ai5iJKsEzgFWlt3juRLJqGKd18l6fLNgg/bNU4FN5XKML6sQ3xNdiG2cf0UJoKbvu5yMxcLh4AS3WOP5TxFD+SVCK0GTV8RfcnYGBHOQ7PMY2Vjg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Nov 15, 2024 at 11:44:10AM +0100, David Hildenbrand wrote: > On 24.10.24 05:23, Gaosheng Cui wrote: > > The stable_tree_search() maybe return -EBUSY if the stable node's page > > is being migrated or nullptr, we need to check kfolio with > > IS_ERR_OR_NULL() before dereference it. Argh. I doidn't notice this when it came through. Andrew already folded it in, but it's utter garbage. We don't dereference folio. NAK.