From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E8A5D637CE for ; Fri, 15 Nov 2024 14:12:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 725C36B0095; Fri, 15 Nov 2024 09:12:18 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6D4F26B009B; Fri, 15 Nov 2024 09:12:18 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 59CCD6B009C; Fri, 15 Nov 2024 09:12:18 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 3D3FE6B0095 for ; Fri, 15 Nov 2024 09:12:18 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 0C0491417B9 for ; Fri, 15 Nov 2024 14:12:16 +0000 (UTC) X-FDA: 82788517728.24.E74D8E2 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf17.hostedemail.com (Postfix) with ESMTP id 74DFF4002D for ; Fri, 15 Nov 2024 14:11:39 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=ZghoCDRQ; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf17.hostedemail.com: domain of broonie@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=broonie@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1731679755; a=rsa-sha256; cv=none; b=YDxyXC3pVgzO25gT/dN7O76LvjLI6HdhfYPWW7vgP5i86mRfhK4iVWMuHIgGVMmBv7bK6P 38mW7GuuUrmJD8WFG5pcAJZm+ixQ1RQLpAhu0Qslr93a877CZGr/Mdj/Sg/cMyxUk2+Vvl TrO8loysZNBBNyal+8hS+tIPz0Z4SkE= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=ZghoCDRQ; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf17.hostedemail.com: domain of broonie@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=broonie@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1731679755; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=BsDzS7Mw3WB8T7SGvgORDbqxDuW7KLbxmD/7/vhasJg=; b=qNp92dLy8FDDVoWG700ALukA5ct2DmCRE0Wdj3IQAi2UivvArTw8+c4vjQxbSQXX7u/fiy wrrbCzamTEaJPTdV0qqYlUexjOIm1z1Xmuo0PpqUbBlJiGEVy+xasoH80Ea+MGBDGbPgJn Bi3MvxhtT6UUlVFQtvIn7K2nh6QrkPQ= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id A478AA42833; Fri, 15 Nov 2024 14:10:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 994C4C4CECF; Fri, 15 Nov 2024 14:12:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1731679933; bh=bstTsljYnstdf3sANTf0Aa+2NdTvKUtQsxEVw4E91Ek=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ZghoCDRQcnGXIYKpeBSNEjA17oMqYZNU9Wh23NVNn0M93Ced8F0LcgtT6l7Zo5bEj QEWbbM/4ndFtYw2tt6XAVjoQZZ6Ih7+89QamhpkZLAZ4WzGHrOYGlu+MeYrW/p5Avw pyNpK/eBTSsuy3Vm2NZlvasaMp+NR0CAYYs//ynlDH5DxTp8wJH23YsKi2Y2Wondcz PnExgZtwn6YN88NctdUeXWTy57DTsjJDKlggUZNIgRbJuoWvJVpLCZHnqsPPt7qQ4c nCG7Z7sTK08yZ7SGmxOpwbSmtf4fpH1vARsx0y6RQyCb4+MDRvT1yif/7NruFjmrfu GN7+AV+R55Wrg== Date: Fri, 15 Nov 2024 14:12:09 +0000 From: Mark Brown To: Yunsheng Lin Cc: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Andrew Morton , Alexander Duyck , Linux-MM , Alexander Duyck , Shuah Khan , linux-kselftest@vger.kernel.org, Aishwarya.TCV@arm.com Subject: Re: [PATCH net-next v23 1/7] mm: page_frag: add a test module for page_frag Message-ID: References: <20241028115343.3405838-1-linyunsheng@huawei.com> <20241028115343.3405838-2-linyunsheng@huawei.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="zqSCGjScNLC9d3w2" Content-Disposition: inline In-Reply-To: X-Cookie: Editing is a rewording activity. X-Stat-Signature: 3pgmfowy5oss1ffjtmqus4rbzm39e9qm X-Rspamd-Queue-Id: 74DFF4002D X-Rspamd-Server: rspam08 X-Rspam-User: X-HE-Tag: 1731679899-759923 X-HE-Meta: U2FsdGVkX18MPJpfwGfYWSidlRV/aCumIUEMRbUbyURlRPn9BFGvjdSyn8BTvsnjqzcqQm2ujgE/HYhuc2ansR9WlvJxOudYgqTeeSrsZ52RFtWUz8OXXYaZtKxRbk6u3E2Ip/iwb4sWfLOMqakpEM2eHddNzr6FnN8RhNDAVLZJ6Tlc/EZIxL889AHRNsKSD4wsN8t96bVOE5a3tykmftEefKJX5A3G40s79cdMxVyXs7nFhwHQxDQaceUQF9ZMnpcaSs8tHTq+5vZgwhW7K6QKn1u6tC5p+aTeY/ssEYKkamz4SHv5AlqyBGQdLiC/7Xbh8GR4IDLv1l0GpN3ZKWA79nGUUXVRVavk15SRmCtyHe5tyETxzHQFhboNrWcjyvaqX3exG+3qi2vvkTt/4X/vPJYMeELrUE9JYbag90YFgm5uyFvcXTWhPXqgSrdOkMTgL5nHR4mG4xei1BjQuKxSs5BTKbfRTEWmKbgocnoDWdUi9NZmS7NcCbEoJQvWw+U8LlKInvDQ5bI9yaTMBILb+VO0ncsZwHY2ndSvJ0x0rTemsWPbqj/lpVb1FDAnM4S8e4BhhP87U+lJK0M7DIGpaCY6KCwnvuFZBnkrJ/wyXRVl/4Vet//Xay3wq3HoVY0LpnAFvqrAMZI76kFHj+H2XOZQhIJl2Wo7HGwV95xEy+PzPY7sFPFvdx2OWLSxmfTBM36tH6SXM70Hak77B2nHTarmay59HajYall3zeX+4E8HZX9/eAhPudvrT5fS185DqrJ7mihIRvYJMpw4+VMgRVKjj0DGFq8z+ui6oaL4sZPieCC8ANRN9zZwePphbSQ4PB3m8nKKc0kXtw3mBZdLkJZWg2jIyICuB5M1a5VzO99HO6nmtZMq/AZnrwoRrWr6uW5133eJ8N6hlArEDBqIV2BKNYFKke2HY2SnAZPOuqN8kmpQXbhvgu5sADQRs8p6E+MN9xALnEgKma2 Wjt14/FA QaIAakZR7V/ptXFI3uh8xVEwwn7AFsYarSmni8ciJC/MJ4mIhyn38/LJp4LYlEdFnGBSSZdHiaT6qgNrxDwq/s+axhVGAx7F7gkl8jAquSLvmDcjO7GNfR7zCNxeE/J26AwlGg9GOr8fmNEcNIincNZKC7qaeZw2eeMDVS3r4eTiUc8EN3CnUAQ68ipEVdxEtz8tqqTVubKtrhbY9QpXXT+uufdJf7ngzTfSVhcoFRaKP/v0F9uC/zC67jfy8f6zPl2muXnpU9Qh9miYHUi7N954A67b/3396WrOyTUAburdTcmMhgKZFp1Rjh88xr3tuyG15h/So2jIMRWtOpnfCs2t2deQLoIO8zCfqT/HQxQuAASvUL0TjWQH9f4RgdsCtTNzmBxV9QqcF0WSeDY1i/Pp5X3Ta3Lc0qp5nyFL/SsxiHWZJuMsgBhtNEA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: --zqSCGjScNLC9d3w2 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Nov 15, 2024 at 05:03:34PM +0800, Yunsheng Lin wrote: > On 2024/11/15 0:02, Mark Brown wrote: > > On Mon, Oct 28, 2024 at 07:53:36PM +0800, Yunsheng Lin wrote: > > This is breaking the build in -next on at least arm64 and x86_64 since > > it's trying to build an out of tree kernel module which is included in > > the selftests directory, the kselftest build system just isn't set up to > > do that in a sensible and robust fashion. The module should probably be > I tried the below kernel modules in the testing directory, they seemed to > have the similar problem if the kernel is not compiled yet. > make -C tools/testing/nvdimm This is not included in the top level selftests Makefile. > make -C tools/testing/selftests/bpf/bpf_testmod/ The BPF tests aren't built as standard due to a number of issues, originally it was requiring very shiny toolchains though that's starting to get under control. > make -C tools/testing/selftests/livepatch/test_modules/ Ah, this one is actually using some framework support for building modules - it's putting the modules in a separate directory and using TEST_GEN_MODS_DIR. Crucially, though, it has guards which ensure that we don't try to build the modules if KDIR doesn't exist - you should follow that pattern. > > in the main kernel tree and enabled by the config file for the mm tests. > As discussed in [1], this module is not really a vaild kernel module by > returning '-EAGAIN', which is the main reason that it is setup in the > selftests instead of the main kernel tree. Sure, we have other test stuff in the main kernel. > As above, I am not sure if there is some elegant way to avoid the above error > in the selftest core, one possible way to avoid the above error is to skip > compiling like below as tools/testing/selftests/mm/test_page_frag.sh already > skip the testing for page_frag if the test module is not compiled: Since the tests currently don't build the test systems are by and by large not getting as far as trying to run anything, the entire mm suite is just getting skipped. --zqSCGjScNLC9d3w2 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmc3VrkACgkQJNaLcl1U h9D8/Af8DcxkwVhqkHIadV8p7T/GNw3ehWEjED7pMgzo4TfkjCCDPXzX2aZr0tVp MyND/9CwU/jMwIBIqxVJT0PfLamo7Ve7AXwGhugK8xxD7CYjw87ctwbYWiELUaFo GfTlyButNQTRtpCMDbXdMA2utKXMukkp/zKU9bbIeq+U+/Pb/HTrQlTqa6tnVmDU un2Mv2RgkRzSWuoRPnb34C23wrDthY4ZKtBRLeRDVLS1KJtuG0vOY4qBZaL1t/Hx 1K6bHyVUk00qY8EAnug7DjDY8Ai63QZR7FFzILQ+7X+QRP0rrBPMNYPARGu938Pn qSzkDtAEsZ6j79hWUAYPBklN5HQ9Qw== =vsmZ -----END PGP SIGNATURE----- --zqSCGjScNLC9d3w2--