From: Christoph Hellwig <hch@infradead.org>
To: Yafang Shao <laoar.shao@gmail.com>
Cc: akpm@linux-foundation.org, david@redhat.com, willy@infradead.org,
linux-mm@kvack.org
Subject: Re: [PATCH] mm, doc: Update read_ahead_kb for MADV_HUGEPAGE
Date: Wed, 13 Nov 2024 20:36:09 -0800 [thread overview]
Message-ID: <ZzV-OUHBN04yV9hR@infradead.org> (raw)
In-Reply-To: <20241113150711.1685-1-laoar.shao@gmail.com>
On Wed, Nov 13, 2024 at 11:07:11PM +0800, Yafang Shao wrote:
> + For MADV_HUGEPAGE, the readahead size may exceed this setting
> + since its granularity is based on the hugepage size.
What does this actually mean?
Also this whole read_ahead_kb has been a massive pain, can we maybe
take a step back and figure out if we still need it at all, and
if yes how we can improve it? In times where we support page cache
folio sie up to 1M, having a tiny read ahead window is pretty silly,
especially as basically all I/O is done through the "readahead"
interface anyway.
next prev parent reply other threads:[~2024-11-14 4:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-13 15:07 Yafang Shao
2024-11-14 4:36 ` Christoph Hellwig [this message]
2024-11-14 6:06 ` Yafang Shao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZzV-OUHBN04yV9hR@infradead.org \
--to=hch@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=laoar.shao@gmail.com \
--cc=linux-mm@kvack.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox