From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49CC8D637AB for ; Wed, 13 Nov 2024 19:18:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D7F806B0099; Wed, 13 Nov 2024 14:18:43 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D2F906B009A; Wed, 13 Nov 2024 14:18:43 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BF7926B009B; Wed, 13 Nov 2024 14:18:43 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id A1DD66B0099 for ; Wed, 13 Nov 2024 14:18:43 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 5DBF9AC909 for ; Wed, 13 Nov 2024 19:18:43 +0000 (UTC) X-FDA: 82782031500.13.74EA656 Received: from out-180.mta0.migadu.com (out-180.mta0.migadu.com [91.218.175.180]) by imf20.hostedemail.com (Postfix) with ESMTP id 80E901C0004 for ; Wed, 13 Nov 2024 19:17:47 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=nsZ3C5Xj; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf20.hostedemail.com: domain of roman.gushchin@linux.dev designates 91.218.175.180 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1731525434; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=i9Dr4PPzgMybXoYmK3wfTXND+6Gc0LfaAn22+IErLaA=; b=VB2NfMwBsHckuZ5ziqnC0FE6WzFqU7UxIdfHIAdYnppGvZixudJv4lIGFl/aHqqhzdqt4d UFzUBb/OzX2VN2oXMiE8/vSm3XCO8XwemRY5CBV5LWFF85DriyUNcjOvMV2TlMsGwDRZmu BWfpXq6ffUGZE6Gm+AbjCKRe1t4XXTE= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=nsZ3C5Xj; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf20.hostedemail.com: domain of roman.gushchin@linux.dev designates 91.218.175.180 as permitted sender) smtp.mailfrom=roman.gushchin@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1731525434; a=rsa-sha256; cv=none; b=lGi4RUuo25P+LHuEQ1cfOg9j/XYXpd4PpcixXOSBscBY8OMEwlfPL7/EogYpM3KynA6ljl 2lnTpjtWTbyupQq5aVXlqZDP5qx/mOntIGBCfsa7KCrqcsAHYYCGRkR9klw1pmIhgAiN/O XKvKirPEx6HL9IoPjvkOvdX8P6KWnYI= Date: Wed, 13 Nov 2024 19:18:32 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1731525519; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=i9Dr4PPzgMybXoYmK3wfTXND+6Gc0LfaAn22+IErLaA=; b=nsZ3C5Xjhtcf+/WPJJWQgf5ujRoQ/1TPonCA6O8ly4bDKEXgvQMDNQ9y6xxlXeS5H8jXHm gvTeGq2aFuK3AwRhdTaYzgOWnaDkQj39nBB4295oAAo7H0y6ItiFLKtfmEZx3cPDYU+P/1 hNhm3YqqwrvAy3o77IIBOYn3FsnVnbs= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Roman Gushchin To: Andrew Morton Cc: Kinsey Ho , Johannes Weiner , Michal Hocko , Shakeel Butt , Muchun Song , Pasha Tatashin , David Rientjes , willy@infradead.org, Vlastimil Babka , David Hildenbrand , Joel Granados , Kaiyang Zhao , Sourav Panda , linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH mm-unstable v1 0/2] Track pages allocated for struct Message-ID: References: <20241031224551.1736113-1-kinseyho@google.com> <20241031160604.bcd5740390f05a01409b64f3@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241031160604.bcd5740390f05a01409b64f3@linux-foundation.org> X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 80E901C0004 X-Stat-Signature: g4igwco4kdz9toidi6rzuqr5sgubt9qr X-HE-Tag: 1731525467-846586 X-HE-Meta: U2FsdGVkX1/4PsLLHq/kbXwV9HitILUEM1xIPPdhCRrnWKNsK134UJAiz9lhYsbxUt3nHrPWVCNA7VERcpq+ReY6OtSHJA70BxwZDSBw4LG4g8zA1XgUgVtD+bSb7V4XDu3PctNEIL80JNEcD03x4pb8KPCu/F9ELIHndfTw13eXpfg+eURx4PpvB1do0UPDKG1kZJ3SaauHDqExdrx4iOztKqIMPSJNLZKKG3iM1mKrlylDinGwRgjgeim8AK9uKYbp5xry02L2sR2xtlCH62HoodIecwEpdZG00Ua6EFh/xUalCn4UNdgVy/DbZqILjQH3QhWhZOlXiOrnnorAUYoq4+f52I5gHw+CRztiHkkTW2Hh72lMWSVKrSfnoQdleZam24ytNMJqkEf8amuORxg1A6abyIbNEczsm9mGI7SGL5ESwHZ5Yv0ltz8lT8ohU/Yv/UkkJF7wR1b3MjquuFlV7BWp8sjQxFDNA7uCg0jynbsWYSGriaefc8dFrXTa4YnUPVlEcWYeqc9PMNEdCdt0bGadyzFloo/sKO3DkobIIKWto9HfpJsqFaF38dBjSQNdTfzUBLaIlKQwei7RdPIsuPzA5nRuftPUMv9XWPQsJxjEw3TG9x01vmozXd1PGLJwf+q2fHYK6GVAvbhq4mGqMrZi2ra4JAm/x5qUZumBT4HowO4idinTpSs87L4JFrQVMn7DV/XX8dSQlE+4yj7Tjw1nxenq5K2sd1jS2MZpuitIUrauf4FE0VO8oG885kv+FJ74D6L/w0mhJvynoB+q3SJIJLaDnG1tec9RSn/DZzaQ6Igo34DfAhrZK/frpRsQIHmhyEBAnu2Xn9c9Y72dozx1Jdug6DQILN4a9aPOdVuBvys6/5bZIg4H6EiqSMqkIVOxbsdPD3TBxVlJe+G2Imsq3mNzpEag6pAfBRAnVsV3PAK/DA49v0Opd87g0lzQmkq3YJUEl1EzqNv eCatNfL9 8H8ZrDYyNq8bVhVwMLxGHYF7WSY8ueD19vMKMrRr1SnOXxUr+6OMTsOJ4iabJ5WGyugeOvlP6tAvJIUrELr/ThCUmPqEVPXLmv0/Kzbgj/Yca8hb5Os8R6NYty5mQar6m4ZtqmxIjoFgPEGpGXRyrt113GrkisLIb+9CJ/AVyb6OhON4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Oct 31, 2024 at 04:06:04PM -0700, Andrew Morton wrote: > hm. > > On Thu, 31 Oct 2024 22:45:49 +0000 Kinsey Ho wrote: > > > We noticed high overhead for pages allocated for struct swap_cgroup in > > our fleet. > > This is scanty. Please describe the problem further. > > > This patchset adds the number of pages allocated for struct > > swap_cgroup to vmstat. This can be a useful metric for identifying > > unneeded overhead on systems which configure swap. > > Possibly dumb question: can we switch swap_cgroup_prepare to kmalloc() > (or kmem-cache_alloc()) and use slab's accounting to satisfy this > requirement? Or vzalloc/kvmalloc(), which are used for allocating the rest of swap-related meta-data.