From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 171BED462A6 for ; Wed, 13 Nov 2024 14:07:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8977A6B00AE; Wed, 13 Nov 2024 09:07:07 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 846B06B00CF; Wed, 13 Nov 2024 09:07:07 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 735236B00D0; Wed, 13 Nov 2024 09:07:07 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 4CFCF6B00AE for ; Wed, 13 Nov 2024 09:07:07 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 0A3A1A0ADE for ; Wed, 13 Nov 2024 14:07:06 +0000 (UTC) X-FDA: 82781246226.13.52AB6ED Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf13.hostedemail.com (Postfix) with ESMTP id BD25A2001C for ; Wed, 13 Nov 2024 14:06:19 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=inGQxMTw; spf=none (imf13.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1731506589; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=KJXNvaen1Bz/rhEZ0wYr3yvxXXNeIsAd3hY4qgJzB/M=; b=fJEDn/NMruIqH0NTxoczYVqUdIBFhXgcpr0amuD1jC9RdUi/5SZsEzgzuZf3bD0pCuccQC xJ6PgqH1xK5lSmmaj88dWrfZ5aPZf8E8ggy3nqLcnx137m05uBbAvS0KFcXnrOuBdH8sgH wzlq5miPiXgCmnc13oMHniUYTQrWVso= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=inGQxMTw; spf=none (imf13.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1731506589; a=rsa-sha256; cv=none; b=d+k0Eb31GeQ70HmtNQbJ67kC1gk9wSkAqXPtw/KFid9WCLz6FKf9kxRiRnDQJDha4asZzF XCgNedXF4dh3Lrnm9S23Uuk3+NWvcPam5zn7fzAK35XjkOXV/OJDH4fflqL+OIkIAx9m2D riORAyJUoVaguV/qfTUmKowjfb+EdKk= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=KJXNvaen1Bz/rhEZ0wYr3yvxXXNeIsAd3hY4qgJzB/M=; b=inGQxMTwLPZKyqpgIPyzxCSSm6 bLCxt2bPzP7//fGxa1Rbqys8CPMTp/GYxKU+oA17V9AdpIfXRuq22xedRJS4TsaPdad/Q6C/d4+fy S07P45BSBklhLxAE5DYtOXrp1wfrAAmUpPCA3zOnljEqgNdpJoQuUDUo2t5myQ/dWxnT5cbB/vpwN MgdBXDNpr3W8hozvV5d1tFsSIGoGWhx1FDCcspDR9ZBz2ZQMHhlyTJ9YxkU4raQ9NKDYL0l1oO/XV fWPpM9Tsal3SHug4dR0UtihyzJouDViAWvGdzL/yqVrmO/CLmaj0VmrNDJtAKfnoFgwH2a2QqwHBX s1eWsa7A==; Received: from willy by casper.infradead.org with local (Exim 4.98 #2 (Red Hat Linux)) id 1tBE1K-0000000GRES-1KUI; Wed, 13 Nov 2024 14:06:58 +0000 Date: Wed, 13 Nov 2024 14:06:58 +0000 From: Matthew Wilcox To: Luis Chamberlain Cc: hch@lst.de, hare@suse.de, david@fromorbit.com, djwong@kernel.org, john.g.garry@oracle.com, ritesh.list@gmail.com, kbusch@kernel.org, linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-mm@kvack.org, linux-block@vger.kernel.org, gost.dev@samsung.com, p.raghav@samsung.com, da.gomez@samsung.com, kernel@pankajraghav.com, Hannes Reinecke Subject: Re: [RFC 2/8] fs/mpage: avoid negative shift for large blocksize Message-ID: References: <20241113094727.1497722-1-mcgrof@kernel.org> <20241113094727.1497722-3-mcgrof@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241113094727.1497722-3-mcgrof@kernel.org> X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: BD25A2001C X-Stat-Signature: taugcggthm7o41n1gyreozg884haxqa7 X-Rspam-User: X-HE-Tag: 1731506779-961218 X-HE-Meta: U2FsdGVkX1+BqdaSJG57rcA3m/s7HdrUoTNUgnyIlhkicnJbSSwAN+VBiiOK9dW21pWSc73vZtkr1PcGKMKsPvOkIjj3ZSJA46FyYC2yFa03if36Ub/QjJA9G/6ztMn+h66xmvZ2X1FJFyiGR1z9RRGgTp3OiNC+PJ4au9oo8cTPpcHpRI553nrO8ejpO9uSFnfQ1TAbl1Mh/P3lU8oRKK5NrHERigj2BOOnGd026ISXlKAhZUiu6UnsuwUJPzd+PDzNiC4wwfhZMhu+6IjfdOxJz7AUAkqzY5FMKJR8OKPfLBdAxbQ72Ln7Mk5U4NMTVDI9EFQuDBpMjdRL6hhuqY5dR78y8b+sOvz+4KOlWFz/gy0dj+lQll6MJd51DzWvSY3D2L7LOAkV9e0ROPeoDAYxcX7x8X9himuEUk1vhOtvQ2A2DUiR/rvEvRa9JPFDeQGW8MyG6UzFnIxIeP06TcWpGdZGnomAUNfBdjlbpNCidVAgAdIEL2Xs00g0hWOBV07t9BzFyBCLU2oIR+InVDK5STd/wXkPKL6hHlc6fYWqS67dmMLse9/RAHskE/WjR3uqa9MkIhDoady95uHSsJm4wsdRd5EoI6iuUl+8HG/q87HMMH3UYf6pbnk4Y3wtZ0ahSAv5MHl2mCUXAr2zPbP/p3hr5EnynaYM708B2iCYGaIP+k7BAlRuzz/N+vtrabSTDY8XgaTHgDz2aZ4vNULpCPxhSbiXMoxPY0qBPrJeiqkf5o8gPzABMHUuKNF/VjFEZcz4aG0nUgjyeP0FAbJNN6ToQ/Zde3ZRqQUDHpRldy8qrZI+Z8Oeedo9q0enJNfyVEnAY3ku3tIcn4tV9pc1mE35p6I3mEVcj1v4mxUFtaPzjdG6CVtnhN2Wfs8ILl7z1XddishMY/OlX0huGPiNHP95lTQvdoZwZ5x5FVy8Cejn/yhffLukJ+pHGl5GHjIM06vmEIy7V5gw0/5 QIASE6OL +voCQ7rRNAYEfXwrM85F4Hrxc0MdhL0Z11j8XbZ4CaIJc3IRhStRrTSFH+achSaI+oK5lKBYUj23EuiuCC1WDeZ1itUDnUm5FYspSifEh+gxLnqGgluKDYUWfwniBvPrm9//SR3k7skyGFO+cT+DaHqQuLF9+VFKM87c1nypkDwtwP5B8dQ6K+JDz5CTTXyaXrUila7thGQltPJRdAQacmwtjd6ShLF9u6l9/+cH+CGQrupt0HJAvlL57XHn8xVPCsmqOnuZCIjNWj+RaHXwHvMtLUYFA4FIeQiHbr9yQk/k1Lew= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Nov 13, 2024 at 01:47:21AM -0800, Luis Chamberlain wrote: > +++ b/fs/mpage.c > @@ -181,7 +181,7 @@ static struct bio *do_mpage_readpage(struct mpage_readpage_args *args) > if (folio_buffers(folio)) > goto confused; > > - block_in_file = (sector_t)folio->index << (PAGE_SHIFT - blkbits); > + block_in_file = (sector_t)(((loff_t)folio->index << PAGE_SHIFT) >> blkbits); block_in_file = folio_pos(folio) >> blkbits; ? > @@ -527,7 +527,7 @@ static int __mpage_writepage(struct folio *folio, struct writeback_control *wbc, > * The page has no buffers: map it to disk > */ > BUG_ON(!folio_test_uptodate(folio)); > - block_in_file = (sector_t)folio->index << (PAGE_SHIFT - blkbits); > + block_in_file = (sector_t)(((loff_t)folio->index << PAGE_SHIFT) >> blkbits); Likewise.