From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D672CD462A3 for ; Wed, 13 Nov 2024 13:57:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 51E378D0002; Wed, 13 Nov 2024 08:57:34 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4A4988D0006; Wed, 13 Nov 2024 08:57:34 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2EBBE8D0002; Wed, 13 Nov 2024 08:57:34 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 0B67A6B00D0 for ; Wed, 13 Nov 2024 08:57:34 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 871DD1C6405 for ; Wed, 13 Nov 2024 13:57:33 +0000 (UTC) X-FDA: 82781223924.02.366DEAA Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf29.hostedemail.com (Postfix) with ESMTP id 20B3A12001D for ; Wed, 13 Nov 2024 13:56:32 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=oEMFFIeJ; spf=none (imf29.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1731506058; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=LhLy5/26EMLDoklyW8LXQa4CH05PL24LL7bv1JpxLxU=; b=nhff5p30/CsJAiAZohkkrjQSwExD2yEveDeubLlSwR02ddtnBCm93LayAQaKGSDk6nHD+Q lrSOgBkerqdEJHQBg6pdsJHbPEPjAZ1T18B2ZkSi/FfwHx5AqyvxkIH8/NPUuILSqD6uG+ 072MWKDelaZ1yr7AqdS10MP3Ty8dI8E= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=oEMFFIeJ; spf=none (imf29.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1731506058; a=rsa-sha256; cv=none; b=GH/zuEd4Nyrtxc7W4zBMrsKWKZeJCmNBStv4xANk47WIp94B9qFcIhlGxNJPfj8yFbHDkJ 3Zh8KhuR7emErrdjFdfIDzWgq1mXVkVy3aib2f0fc91Rasl3/0Va2VzXzSeyFT5I+2Tupy wjLEbqkp7cuEDGRbfw4GEa6YXwmzLfU= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:To:From:Date:Sender:Reply-To:Cc: Content-Transfer-Encoding:Content-ID:Content-Description; bh=LhLy5/26EMLDoklyW8LXQa4CH05PL24LL7bv1JpxLxU=; b=oEMFFIeJ2IxPSv3AUaG6msqMy8 ywuSi3ewa0d7eB8HwonQP2rvY+AFDCn5TU2n9amC8DS05wAnNZ7nER6OmxOPMgWXPer6lxb297ELJ R+y3y5v7sYsaJnkx0HHdAoOjD+JHCA/GiNuwaOtJ3qj+KD1lrASlq+lWrtErAaf/EF7AJoFF1aJUw qeAqX8grqTlCPPQ27MTt9jkHcbTdms7J3zDtRYe/QjODX8jQuVgOJulIzKlWS6JT59xa78+U2soru qEmN2QQUfesiWVAMrHmqlMaybLz6xtUQGCNtsbEvTNEfwTCNdO5DGKWsr/M4jtJvquFhf4uFOn2Hk RN88gokQ==; Received: from willy by casper.infradead.org with local (Exim 4.98 #2 (Red Hat Linux)) id 1tBDro-0000000GQdN-0TVH; Wed, 13 Nov 2024 13:57:08 +0000 Date: Wed, 13 Nov 2024 13:57:07 +0000 From: Matthew Wilcox To: "Liam R. Howlett" , Vlastimil Babka , Suren Baghdasaryan , akpm@linux-foundation.org, lorenzo.stoakes@oracle.com, mhocko@suse.com, hannes@cmpxchg.org, mjguzik@gmail.com, oliver.sang@intel.com, mgorman@techsingularity.net, david@redhat.com, peterx@redhat.com, oleg@redhat.com, dave@stgolabs.net, paulmck@kernel.org, brauner@kernel.org, dhowells@redhat.com, hdanton@sina.com, hughd@google.com, minchan@google.com, jannh@google.com, shakeel.butt@linux.dev, souravpanda@google.com, pasha.tatashin@soleen.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-team@android.com Subject: Re: [PATCH v2 4/5] mm: make vma cache SLAB_TYPESAFE_BY_RCU Message-ID: References: <20241112194635.444146-1-surenb@google.com> <20241112194635.444146-5-surenb@google.com> <54b8d0b9-a1c7-4c1b-a588-2e5308a977fb@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 20B3A12001D X-Stat-Signature: nzkqys1qrjr14t7qykynehio9xu3ybz8 X-Rspam-User: X-HE-Tag: 1731506192-924609 X-HE-Meta: U2FsdGVkX18hJxJfLbF2bGyHcsvWcWmSmpxGyaZDo28jzimm2VbSVtdOrREkzNSa9ihIuWtzew0s9xFvbY3HLJKiEaSQVN7wQDD7emPg0zg9wqyc65eQ0QvHSWLcHge9LnX+vNbCMFZoyhknWp9rVOxyFQPN8ctqOm4bd9gYWQu3dVAnEMXo1h5oO1g5RGD26qet/yn1/gDMLkv+8IN7PDz+3mtrApnCOgmtMrD0ztoKS9E7+v6Uj5vbCPTWvbKOOFnzrrkSr7PUknpAy6cCdEPnm8r9wcZvHEQSEx8AvGam4FigHPnM1YdLQxH2rWzimxO6Acz5gQO/2AEj4Kjhr3qduZbwY+sH5u9xjiPPi3IsNly5oCbEkVyZpsldtRpCVi93SWHeCr+ogxGITLb/YtktSJz2vE5Tmc71Sr44CEVj4vL9ks7bHUhWK5aIsqPV3wxVMXLnmE0eK/ao5ld3YhtYYoGUJs71FlUXuGkhYvopaSzLp3wP/HnpO7GP5o13hLN8K8a+mN36q5FDZa/ozcOV5xV9knKEH3j3Yzv0W0T7flswB2hemcUkshS71ox6GJL7fWdbJHcmOk5y2T90VILewTpxyB3opZk6yMwJe/qLhKKVLwwPOog1ViOy7UxbzdEmnLvVwpxKOgET/KtAm1lo5KjJb4mG4pKfoVOFxgkxtLbtm6bqWHAw11nDwJUu6KjIfwD37lyX3ak+tLpziM/J8OmcuC573paM48tb+KcD/lqRUejZiR+wSb3lNOqKDvh9zoGuz5/ARE7RGAUecn1TdTad9eWxPlmYOixU1jxn59ibi6yC+9VOi6rSIrnO/i3tQEiPosWYZvka/IqTeUfJULZ8jT8wfUdsuIA7aJAJLw0Ydpo36JzjUnH86jGjY1DTvTx/g81HGMIgMbcipKeGb8HJnI7DcnZb7mc5eX+/fO+T7QPjtDao3PPGgdxuWjkpnC1kTV4HCnazeU3 BuwrJEcs 2gxVDeQMotEobnRoASwmpwhZ3hithEMyr7Y3s4qDIMnTBQQ5SNX5tqwqZC1bcWG/UYQU7pEPXnWfq1Ypq54ZEJLGiPsIwLBO8Tk4hsoPQ4N9EZmw50qBpnxag6fXhPdYKjE1YV56l7TMv/XOpbKmcUv2+NPOidPEUgfVV0nxyuESsR0BaBxLEwD6uX6m+izeWwCZngo5bBz+SlzO5UlX3bxXs9cJHYyEBVM2Lx2DzgNKOahdku6A8aL7ewS/Gusx0q83OpXUccmjoa/wXwl+HsF2oNg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Nov 13, 2024 at 07:38:02AM -0500, Liam R. Howlett wrote: > > Hi, I was wondering if we actually need the detached flag. Couldn't > > "detached" simply mean vma->vm_mm == NULL and we save 4 bytes? Do we ever > > need a vma that's detached but still has a mm pointer? I'd hope the places > > that set detached to false have the mm pointer around so it's not inconvenient. > > I think the gate vmas ruin this plan. But the gate VMAs aren't to be found in the VMA tree. Used to be that was because the VMA tree was the injective RB tree and so VMAs could only be in one tree at a time. We could change that now! Anyway, we could use (void *)1 instead of NULL to indicate a "detached" VMA if we need to distinguish between a detached VMA and a gate VMA.