From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76511D462A8 for ; Wed, 13 Nov 2024 14:14:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BA90A6B00D9; Wed, 13 Nov 2024 09:14:34 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B58526B00DA; Wed, 13 Nov 2024 09:14:34 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A1FCE6B00DB; Wed, 13 Nov 2024 09:14:34 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 8445F6B00D9 for ; Wed, 13 Nov 2024 09:14:34 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 36A4E1A0A7E for ; Wed, 13 Nov 2024 14:14:34 +0000 (UTC) X-FDA: 82781266806.02.DAE8242 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf18.hostedemail.com (Postfix) with ESMTP id 7335E1C001E for ; Wed, 13 Nov 2024 14:14:13 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=DZCbfABc; spf=none (imf18.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1731507037; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=dR/eQNA/p7Fur9CKjeVK9QBEm5x5S0TSUaRl4x8UFpc=; b=iYHQyt9vx9oDo44B/wHANSbiMHed40E2KstdX9duUKJt9LH0PrSmf35IZ6uZisug/7HsYv NqoW0Z23oC3+PLvZyLIj3A3ldXWszS46SONh18toZROlb9xWMQ+bQDf1f6Chw+FCkoyc6c 4a/87Iy52jHRf1fKFTWB/2QaxCR5oTM= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=DZCbfABc; spf=none (imf18.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1731507037; a=rsa-sha256; cv=none; b=qlTRzJUYNMXLtG5K4lOzUThyzP9RfzvLhEIuZhMQU1dSJGWVGmsogmFC26CmBVVoR66iWy FWzzeqAuHSKtu/G5Pixu65vXi0xpRK29weih5HA9iQhfsdXMbdjGskIoZjGvlwW8tUPtxp GveyTPgFqEtnBrZg0ClvCxHQiZ7I+2s= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=dR/eQNA/p7Fur9CKjeVK9QBEm5x5S0TSUaRl4x8UFpc=; b=DZCbfABcQtHDJbiDvoeMwVGczs Sdfgmp+E7gvWbM+wVFIDlB4ap2qzpv8TrlEq9TGYSxAVXstVh5WU7Qr3MDJjy1M37P62CA/38in+S x+E5Lc9gUgtYs3Ts/2+pANp8+AS0lOaJNMkjVJLMVqPiCZ6uuCESSYIwynahmIthmbcJq/+LzuQFX o7NkPICis8K0MtPcNpn5AGHAbOCpCkcVUQS2XnjgLbCanY30AXavYObzS+xlhdvWKntqnRntVb9Vd +zIMwQX3sktOgnJW4QtDcoUjqAL+vLExX3P18AQrNFRSvljijDGgPre6CHoZFYE0BN/PTRDGv0JMw lgkZAIcA==; Received: from willy by casper.infradead.org with local (Exim 4.98 #2 (Red Hat Linux)) id 1tBE8Y-0000000GRdw-2jHd; Wed, 13 Nov 2024 14:14:26 +0000 Date: Wed, 13 Nov 2024 14:14:26 +0000 From: Matthew Wilcox To: Luis Chamberlain Cc: hch@lst.de, hare@suse.de, david@fromorbit.com, djwong@kernel.org, john.g.garry@oracle.com, ritesh.list@gmail.com, kbusch@kernel.org, linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-mm@kvack.org, linux-block@vger.kernel.org, gost.dev@samsung.com, p.raghav@samsung.com, da.gomez@samsung.com, kernel@pankajraghav.com Subject: Re: [RFC 6/8] block/bdev: lift block size restrictions and use common definition Message-ID: References: <20241113094727.1497722-1-mcgrof@kernel.org> <20241113094727.1497722-7-mcgrof@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241113094727.1497722-7-mcgrof@kernel.org> X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 7335E1C001E X-Stat-Signature: cp4jfiq1uge94ue7ejokkuc813jft5w7 X-Rspam-User: X-HE-Tag: 1731507253-903007 X-HE-Meta: U2FsdGVkX1+/TOqz/E/KvBvDzGsICdcbWavYr0G02YM5zTpBdvK/nYLqBJCbNgLsmSR/aXlzx52I8aIcruqekR0PgqAvuI9Bs5qf81+jsgFwbpcN3DrpEA5n8Dyy/f/bU9hHT5A9p7p7MY/I0rEBPEh+BcrGvb4Mx0JKYULrWrb2EDnwmfD3DbrIqeuwJKWd3I992oWjisHccfKMopVyFeQ0Cqh6s3cUSCGFqLj/ITN68Y2iCc4B0TH9HkjosrYh6NaFXdAO4uiwbFTNjRXlly853B7ev7QjLEBmgNIQD0B4aeIML6HdCX4jPt78tqKnVQqMSCP+LoxFuZWBekpGb8ZD9koMoFZUp4eQM5ka8uZb7z4L3dsi6V0nDA0CP0IFCYjwFgvRHHZuNSaDmonOxsDc8JjA5pZEClL+2kLnK6ldB7UF7mEgO3bX2Gbe5X7wTTqvzfxRWbZ3cLonkj6kBFWrL44mEtupU+cQAQlW5puXXY1A2njoh+rq20GMZf4AZmWtCVZk2HvRNxiBgzf/YBj3TkNLBzvxk9+pxBbTCcuGOuEEB5yqDm5/w7HRuyP71cPqI/uWgifQZyH27VRoeU6V3vcvRNnry9BP6yWlDcgrL+LjMkP1ToGrTenHpZKYP4UHpddLFcnUWTqpHk5VimKBYnKN0/1PalS3kH/0R4Na7MJmNGmGV8iFr7d9KJ2FpIRwpU7Z69vASsVskMMkHJiu0mgEmwfDm7rnpgMZCPYbqOyi6XeotBIrVQPo+gTkl7s33mfN42GjEm3L5LZd/Slj2T9rfUfNGqQ78b7JrY9FWXqejhspPvyLfdr1Vebxy9XboJxNmYCFeWGB8u1tTBRJP/+nZVUnM5Dc8lMM1ME9F/IQNCq9EitjFgA+FM2dALzT6hQiWsju9shWlLaZDRErx6zZlYzVG7LEDrfOasZLBa2ShMWByGnP8Fw5wKGw11W446xlR5tJBLmClaS jpgm6yLW 0nX41Q4AVM1OtXjo3P/Pc0ot5z3e9rxTdJeZLlVeTdIlFgyXBtiwv9/rZ38Llxjk/oTx6bM6sHFvOIlFzIKGAhA8xWpaEJxBCNyzNm5wwL+8/4jKmtHBpnZRj8rj1US8iA0M3InFCoGOCctYw50SoXGAqD5ajH5wWtUsDk/ArRqKE2k7YrV0eOdOwxxXpqQRcbwc16SuUmt6nNhIcozCQhuUnEawpGXE8zGKVBSzyYncQmaWfmG5Ot7NUhITfh/T3GdKnZHLLFqn6ij7W8rmVZJogJFcvm2mWlA7FQBzcfP24vqQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Nov 13, 2024 at 01:47:25AM -0800, Luis Chamberlain wrote: > @@ -185,7 +184,7 @@ int sb_set_blocksize(struct super_block *sb, int size) > if (set_blocksize(sb->s_bdev_file, size)) > return 0; > /* If we get here, we know size is power of two > - * and it's value is between 512 and PAGE_SIZE */ > + * and it's value is larger than 512 */ If you're changing this line, please delete the incorrect apostrophe. > sb->s_blocksize = size; > sb->s_blocksize_bits = blksize_bits(size); > return sb->s_blocksize; > diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h > index 50c3b959da28..cc9fca1fceaa 100644 > --- a/include/linux/blkdev.h > +++ b/include/linux/blkdev.h > @@ -25,6 +25,7 @@ > #include > #include > #include > +#include Why do we need to add this include? > @@ -268,10 +269,13 @@ static inline dev_t disk_devt(struct gendisk *disk) > return MKDEV(disk->major, disk->first_minor); > } > > +/* We should strive for 1 << (PAGE_SHIFT + MAX_PAGECACHE_ORDER) */ > +#define BLK_MAX_BLOCK_SIZE (SZ_64K) I think we need CONFIG_TRANSPARENT_HUGEPAGE to go over PAGE_SIZE.