From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8131D42BAB for ; Tue, 12 Nov 2024 16:38:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 262BE6B00B4; Tue, 12 Nov 2024 11:38:20 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 213406B00B5; Tue, 12 Nov 2024 11:38:20 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 03C1B6B00F2; Tue, 12 Nov 2024 11:38:19 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id CF77B6B00B5 for ; Tue, 12 Nov 2024 11:38:19 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 8B441A041C for ; Tue, 12 Nov 2024 16:38:19 +0000 (UTC) X-FDA: 82777999500.22.9F3AE59 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf14.hostedemail.com (Postfix) with ESMTP id 1660F100018 for ; Tue, 12 Nov 2024 16:37:30 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=JFXMArMi; spf=pass (imf14.hostedemail.com: domain of bfoster@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=bfoster@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1731429264; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=HBEamZbjXMqh8LYkIi+wp0uylZlZEO5P3Ysc8nav4wo=; b=qlW4ZyV57mKruzmHpwRlVMsPTV3Pp89UlvrlWipQsaZTtqWEBubnsbTPH5Yj2M+sXztJ6i TLEQaO6YR8VMg8VMAhZf5q2/P7MhR8q6fZhk5fRSYwuENKaW0Y+PZFzO5olSQnLdPTQb7J gCq5WQSGcp/AcQxB6IYjMaUQKYcx+WY= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=JFXMArMi; spf=pass (imf14.hostedemail.com: domain of bfoster@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=bfoster@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1731429264; a=rsa-sha256; cv=none; b=0hLOgxIIvK5xtnItCXAM65pZovSVhuHCm6KUXt8rXLVpEEPorIWG2DzQo/4HJerCj7AGGn qPSTr3MTu1ShDgKv5r102WcrjNpNTDrH6CWhaQ86hyENnG7dHrWqinNO8O0ZuDfX6LKdd9 kJgD6gt+yc/wPNGn7rgi7ZejUYgi1jY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1731429496; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=HBEamZbjXMqh8LYkIi+wp0uylZlZEO5P3Ysc8nav4wo=; b=JFXMArMiyWmoLGsF/gjRDp3BcID2xOkVXQqauuyihkdwN+m03PSIJSe3zFcQfxmaFOhLr4 JS0nMgWeYCXzEWBkQGE3y4OCjSsIkxXCUvIF7l1/xZ1GKeZgL8Z7iGC6yU58+0q6AG4rja RcLFvNUtaBAQsf9vTPD1GPddnNyZHqE= Received: from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-299-iz8JA2gkPaqnHlgTCguJOg-1; Tue, 12 Nov 2024 11:38:13 -0500 X-MC-Unique: iz8JA2gkPaqnHlgTCguJOg-1 X-Mimecast-MFC-AGG-ID: iz8JA2gkPaqnHlgTCguJOg Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id E2A11195395A; Tue, 12 Nov 2024 16:38:10 +0000 (UTC) Received: from bfoster (unknown [10.22.80.120]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id D0FBC30000DF; Tue, 12 Nov 2024 16:38:08 +0000 (UTC) Date: Tue, 12 Nov 2024 11:39:41 -0500 From: Brian Foster To: Jens Axboe Cc: Christoph Hellwig , "Kirill A. Shutemov" , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, hannes@cmpxchg.org, clm@meta.com, linux-kernel@vger.kernel.org, willy@infradead.org Subject: Re: [PATCH 08/15] mm/filemap: add read support for RWF_UNCACHED Message-ID: References: <20241110152906.1747545-1-axboe@kernel.dk> <20241110152906.1747545-9-axboe@kernel.dk> <221590fa-b230-426a-a8ec-7f18b74044b8@kernel.dk> <04fd04b3-c19e-4192-b386-0487ab090417@kernel.dk> <31db6462-83d1-48b6-99b9-da38c399c767@kernel.dk> <3da73668-a954-47b9-b66d-bb2e719f5590@kernel.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 1660F100018 X-Stat-Signature: u53ckcdid6p5odhrmtyf469jootmr3di X-Rspam-User: X-HE-Tag: 1731429450-311329 X-HE-Meta: U2FsdGVkX1+VwZiSI4zCyYQC58WFYj4lXdAPK+oGprZo/zNCkQgW6iszuKckeFWC4/hH2QTfGQYSKFKLelvd1gsJ1s41I9/dtWY96ZxXekfpG/5MALfnUcVcGHx6QKJVfD9And5B0+zw53U6L4/lJkUy/HQ1cAi8r+NWwmDzayhrglOWJD3SZAjxBoB0XCs5+5dBK6ykdQddQzf+Ozo4PaBEM856TxWsRF6cc0hSEMdG45xsWkaM3wezQdfmBOGJf7xOEe5JvhTly+jqIXILar2J16EbyLpG9QCkPiLpVLaH/IEEngN1gC2LtHGD5p4HWzr1SetkLia/aAMtST2w1Jcu61nZVX49/DTmMkVdd829KmvrKfcPTlPXBr+HnBEQgdVwKnu6VnyI8YgTBOa/O9tj7zAYOcvDDhpSuBS7ERWOV2GC6LFsq5hWvI+FDVxcGg/FO8fjGL09RxMbuL6HZ3gViCRgBpv1duJase4Mg83JHGz88OjuvoFwjcaBmtsbHDVlQI0T6gvt/ZHeoc8hi2cerCMHtG2QObmDjkurDBJ1JwAT5T/LhoT1UnGTpbkUy4q2ZqN7Fs3/BcF76ycwIpPDvGizvZKN+XcvPcdG9qzTPGsABC/W54teWDlQf7mQMXHXdUBWym5Hp1i9Z+G2NAlnKU54BKJU0tLedUaaltOHUsl7+UxScisIwWp2kUoib6Z5q1k3VsR8LVu/hdD52hTHXEMt+pv82mvxAPdypYZqkN4pkR+AyPT/1uBZfFD+SOGKUTZGHNUGHR+Nu2Rjro93FaCfKfIqMpYg+BiGOHb1NdH7kXm9WtnYljUXRMjDXP3zBldNhDoelRnutifYopmsBt95RpOhxkqZ/JoabrHN85jPypFHQA+fVGYfvG+CsOdkXT1pAQC1ZAiRZmr2s8fc07IQ7TZO9psxqKP0BvTkk9WzcSaJ5qWp7u9GK3xM1nvCCZvdwGy8ZWUEVch cswfI4eV m6jA5YKM2G4rHiosTC/Q1PlU4II9uYNOFYN0TxERfEM6ZJ2sPoy54GcLyJMljs3EWAw7XL8ZNwmFl1VSRw1asi5X4NxICTZ9DCjLfjAKgItYNa/z6lleNWmWTWR2DtMLhY4UW4VRzb6crKfnPuDoqpG8MrI79aDKAu8cTpOVg5CJbYugy/grNmTQuCFOvzU9NdV3zSQdK5drnRjjuORPDstgMBKrHxZvKi7HOI/JqqrdoXLhE3B8jXGySSZYT7CPl4Z3Xi5Ry1FfM2cb03MyIhCh1h4YmdbRxT6lcldflEyaWa5e+vdxLR89J2anEYB/uWVYC/uurBJzcJED7jeFoO9UhVQ6qwM2t0ozY+r+3ogDMik+kvtUwuGMhh75eKLK7P48VmZWZvsFHuMLm5hgd0GenIw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Nov 12, 2024 at 08:14:28AM -0700, Jens Axboe wrote: > On 11/11/24 10:13 PM, Christoph Hellwig wrote: > > On Mon, Nov 11, 2024 at 04:42:25PM -0700, Jens Axboe wrote: > >> Here's the slightly cleaned up version, this is the one I ran testing > >> with. > > > > Looks reasonable to me, but you probably get better reviews on the > > fstests lists. > > I'll send it out once this patchset is a bit closer to integration, > there's the usual chicken and egg situation with it. For now, it's quite > handy for my testing, found a few issues with this version. So thanks > for the suggestion, sure beats writing more of your own test cases :-) > fsx support is probably a good idea as well. It's similar in idea to fsstress, but bashes the same file with mixed operations and includes data integrity validation checks as well. It's pretty useful for uncovering subtle corner case issues or bad interactions.. Brian > -- > Jens Axboe >