From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58E9FD41D55 for ; Tue, 12 Nov 2024 05:39:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B94CA6B00BA; Tue, 12 Nov 2024 00:39:25 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B43476B00D0; Tue, 12 Nov 2024 00:39:25 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 995256B00D1; Tue, 12 Nov 2024 00:39:25 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 781686B00BA for ; Tue, 12 Nov 2024 00:39:25 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 00B7B1203D0 for ; Tue, 12 Nov 2024 05:39:24 +0000 (UTC) X-FDA: 82776339030.30.2CF9CD6 Received: from mail-yb1-f178.google.com (mail-yb1-f178.google.com [209.85.219.178]) by imf24.hostedemail.com (Postfix) with ESMTP id 9B0E0180002 for ; Tue, 12 Nov 2024 05:39:17 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=D0pFkdeR; spf=pass (imf24.hostedemail.com: domain of bagasdotme@gmail.com designates 209.85.219.178 as permitted sender) smtp.mailfrom=bagasdotme@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1731389908; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=F1BfRa+7qOoBb0WExc9t56zOgnTDDdD0ITVpKzY7aPA=; b=dfXHEA/38ryrmlyuLcEOq//fqy7UCAeR0SorRSqgFRaLmIUN4cL6K//q447tGIrdyPuN+T ZeVtb2NJ/7N4Uzm5uRJT0/BsAXtU4JyGqf3JlXHyRdhYITt0DDParL/Ku16Tiw3rFvtQ+4 xu8XQsyfc7G0ZJcJn+O3aF97fzQsa9I= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1731389908; a=rsa-sha256; cv=none; b=BhKWwnyvltHWUbtgHesbctdXqXcYxc+nqErriWyv1Y6hXM8Mc03PzeUuFp4vX3MncALVZ4 1J+Sj5zDt53YV6uyYCRD6SziyAAjizPcYkYVMuGUyCB8cmdATHnlhVmLQJKwcdJbTX3xqM F7DbWKieFQ5WjhZ3YHTvN0GNnvv8BVQ= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=D0pFkdeR; spf=pass (imf24.hostedemail.com: domain of bagasdotme@gmail.com designates 209.85.219.178 as permitted sender) smtp.mailfrom=bagasdotme@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-yb1-f178.google.com with SMTP id 3f1490d57ef6-e29687f4cc6so4864030276.2 for ; Mon, 11 Nov 2024 21:39:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1731389962; x=1731994762; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=F1BfRa+7qOoBb0WExc9t56zOgnTDDdD0ITVpKzY7aPA=; b=D0pFkdeRF6DeKWm4Hsdytb60QWTAMJprWiWFv6CVbIDTxvazHiYyKvY+4Ol46dj8am rbtHjw+NSoq6JmMZLnIcq4CMJ5rAFIQucXYueqZ+5xdNucyIRpFj8A8ticHsCtQ7tPJI V5bN7VzpdKnMsyuyVL1S+DlDbK2gA4LOTKpBP0zwexubONHpsSWFjaka56f8E+1XtEbx KmNAvw6RD8hBqX9LlXwqNLJviH5fT2PvUbUiqFcGBWr5Zm5eoib9ro78tzopiq7Fkigd nSBy5Cqvfl53CQqZ65YCTU3GB9WuHxMtoFORNd5wlePUHOD2uUJn/6dIz6Sl6F7SosJ2 4GQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731389962; x=1731994762; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=F1BfRa+7qOoBb0WExc9t56zOgnTDDdD0ITVpKzY7aPA=; b=Lsa99+p8nqmCIPscffu+NpBXeNApXPkehNF9aGz9zQpxmIZ0W1FcGVTDgor9sbJS/S EYDxxqkdDqTzJBPe1uoWYZ8uUcSRmKuVYNWbals6JLn2aZpmGPH6RN0LSqU/kBhQAfWA DyoND1SyBgwRJ64OCM7lTdC+9PfZ2elGeSmp05cm9QzqXlMGcfjJS8aecRGlSHZAQFdO sq0I6ywe2jS7FbTJxo1zpMohCZHCWG7OMXvApUWCEuEqzXbUorJy6mXkwo1r+aBYJTvO cDA2F2tDxPhd7Ev8+Y4LX7TnbUAMxKarSXvj4orLqSmin3vvOFSMoMFBGdhMAIRirMLB UtGw== X-Forwarded-Encrypted: i=1; AJvYcCUBNXhEjpVIs6CnxAQoicAi2A2pnzXEZZdcBvqaezZDUBBEvE9coBSRIT15Ak6PLgZmIy1Z61ikmA==@kvack.org X-Gm-Message-State: AOJu0Yz4G7WYav1pvDlM/Jwiz9YoUia23tGFyKOI+2yHSvIHmQWB4phQ djmRVqvcmNivGq3vDMquqWf0mdKdHknzX0+ILyBuJM4tVSJ8+YOa X-Google-Smtp-Source: AGHT+IGEMQpLn4quiUmZDO6r6Zoxq3fld89dpP4MRj6NYnmDAhJC3fbLHaBmwmZ1HBZItGfhrhFEKw== X-Received: by 2002:a05:690c:9b08:b0:6e7:e2e9:6940 with SMTP id 00721157ae682-6eaddd9fd09mr144632247b3.10.1731389962011; Mon, 11 Nov 2024 21:39:22 -0800 (PST) Received: from archie.me ([103.124.138.80]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-724078a41cfsm10333655b3a.41.2024.11.11.21.39.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Nov 2024 21:39:20 -0800 (PST) Received: by archie.me (Postfix, from userid 1000) id C881D4209E61; Tue, 12 Nov 2024 12:39:18 +0700 (WIB) Date: Tue, 12 Nov 2024 12:39:18 +0700 From: Bagas Sanjaya To: Lorenzo Stoakes , Andrew Morton , Jonathan Corbet Cc: "Liam R . Howlett" , Vlastimil Babka , Jann Horn , Alice Ryhl , Boqun Feng , Matthew Wilcox , Mike Rapoport , linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, Suren Baghdasaryan , Hillf Danton , Qi Zheng , SeongJae Park Subject: Re: [PATCH v2] docs/mm: add VMA locks documentation Message-ID: References: <20241108135708.48567-1-lorenzo.stoakes@oracle.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="XkZYaAUKn9osvV3m" Content-Disposition: inline In-Reply-To: <20241108135708.48567-1-lorenzo.stoakes@oracle.com> X-Stat-Signature: zxk8th1pk9ou3r11d5f89ebzk9k6afth X-Rspam-User: X-Rspamd-Queue-Id: 9B0E0180002 X-Rspamd-Server: rspam02 X-HE-Tag: 1731389957-465533 X-HE-Meta: U2FsdGVkX19QxLutPzni/GtC4GDW9WvISEnJ3uUwNv+DAENXLIqCGr618Zb72Vm5Z3jyOEOwfKtTxnxOA5DIh6zc4oTfwAglnVAXu2DLouSTCbPWIwKe48mAWcOxlfJz4fiWr7TQmcu2pVGsnGqrwihCu1IVaOfdbkJfHXdxCeGJrAyy74u8XY9qDktX/rAnq9M/EWlDHmRMIiGo6hIHme/Ofz1hAnIzsaSRSd5nUB9dzQaFA3RysbflNJp8tcrOcUmilgDUmcFPKpXCxZ8dwSxOo90kx3/cjxc9/pQDipGDivWNDc3mVNt92Cq66mjZSBoVC/QaEFwdtoBj93H7axMcb4vZWCZmWb5wlmL6AoQX4vRmBNGQIG1S0P8MofefFjOWjXhKYQ9nHPXhyaNDelxU6wNEr9UVZLB95ndmXBFrPxtP1Y8HetVgSbmb2m3IOQalp4JB9g1oPyWLIOtNF4Qj6o+uOmmmjQfNjXCSJeujkVsZ+rl3ramy/IGih2fYAi/Pe7A/gPSwtmQK2jC9TDdn0pe4ynpjLl1+d178I3hQPxS1OmSe5IaOxy5qJcVXKIeJQcsAOEITfVhYM3Di3B3gAj2IQF/67qfdGJ8PxiiYN5frMz/ZJ3m56rpWPLB8xKVBkY67s5ddcbwz5yIncZjJdz1cg/OEqXvvErQUcIdS+fFdBo23N+XZ0KoUzGlGNC9aztc3xx/3TLJnZk4xQ0WC70clb+U1HjFp82JWUbzF0zrFKzJPg1dIxjGyNfaI4RiehuYrC4QkjESGRoeMR+PBqdayq5YHyOSOU+qsqxKhNFlU4E9mIXrdOw/eR7Bw+S2LubPaih4QUg+V1fskRiEkvMM0EWAd/KQTWhxzRFCsxakzBzqpSVXtqXyHlBixEtesNxHXkcoxOa6CdCsrdc1N6gdcayjnVOgw5mxFN4P+VRYkoi7sXiZpQ6WD3BwcW/YfbIBPXVymVuhIT2t lEL8PFbW 1lQWq3lw/gDj9ghGxAMS7zzt17VmPL2kFro2KzMhMb6cCvp2NwW7jQLslFf2+DBfc7Wr2d/PwPMkXIlSnmkAwYyrz9uQFPDJnZN+vT2pdF4XirZfBNE+a1Bh47wK+XP+5iBogN47Nh89tQTJXMvrjK6jpQkKBsrHZ00zMjxgG2Qjrxv0reJu1snvl0lIWDRtZ6uStdawsZJN5eE+jpiORhJ+gKs6FupUKxuiG15JGCJskTkYMBRZcz7jS9pkKPKk5mAecNp5AQBMjjaA+AWKNMGomRhQksrcKTwGXFVMSxs3TbFmAxDTslkfp99bwavKXwlI0AIkK1IwR6ol5yLekdUuFIBHNUQOWn6ZkVfbIKf5S2vWy3sf2WgUO6E7+kfc1Oka2r5v3NbZvhZZ3Q5gjcWvwyQPrXIpuT91KGEVKX5v6/b0oGe3UYCveasH4IX5mCnySl0wdlTf0J0fU8Ds6/JgA3+GsYwppeOYgcp/YnwRn89b+jjWTHEFAP71E57UZpUz9pZRpZdGe1mm3/YVmcOIew6TpzrzYCuyJSTtJmqC5/bv45FRfN41bbJspLBlS9ocP1rQPzjsiFzQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: --XkZYaAUKn9osvV3m Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Nov 08, 2024 at 01:57:06PM +0000, Lorenzo Stoakes wrote: > Locking around VMAs is complicated and confusing. While we have a number = of > disparate comments scattered around the place, we seem to be reaching a > level of complexity that justifies a serious effort at clearly documenting > how locks are expected to be used when it comes to interacting with > mm_struct and vm_area_struct objects. >=20 > This is especially pertinent as regards the efforts to find sensible > abstractions for these fundamental objects in kernel rust code whose > compiler strictly requires some means of expressing these rules (and > through this expression, self-document these requirements as well as > enforce them). >=20 > The document limits scope to mmap and VMA locks and those that are > immediately adjacent and relevant to them - so additionally covers page > table locking as this is so very closely tied to VMA operations (and reli= es > upon us handling these correctly). >=20 > The document tries to cover some of the nastier and more confusing edge > cases and concerns especially around lock ordering and page table teardow= n. >=20 > The document is split between generally useful information for users of mm > interfaces, and separately a section intended for mm kernel developers > providing a discussion around internal implementation details. >=20 The doc LGTM, thanks! Reviewed-by: Bagas Sanjaya --=20 An old man doll... just what I always wanted! - Clara --XkZYaAUKn9osvV3m Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQSSYQ6Cy7oyFNCHrUH2uYlJVVFOowUCZzLqAAAKCRD2uYlJVVFO o3STAQDHnJFvv5jfJOUQFsOkCAeoxK+s6dpeWgh+GGi4e2MbrwD/Z8pkRZj351cf Gpboj+UwEbMqIeY4P85LhhCHGKJ6UwQ= =U+MU -----END PGP SIGNATURE----- --XkZYaAUKn9osvV3m--