From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83CB1D78783 for ; Thu, 21 Nov 2024 16:02:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1C8546B0088; Thu, 21 Nov 2024 11:02:14 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 178C16B008A; Thu, 21 Nov 2024 11:02:14 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 067BB6B008C; Thu, 21 Nov 2024 11:02:13 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id D9BDD6B0088 for ; Thu, 21 Nov 2024 11:02:13 -0500 (EST) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 495BB161419 for ; Thu, 21 Nov 2024 16:02:12 +0000 (UTC) X-FDA: 82810566846.06.373B968 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf02.hostedemail.com (Postfix) with ESMTP id E0CC28002C for ; Thu, 21 Nov 2024 16:00:29 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=WQQNQN55; dmarc=none; spf=none (imf02.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1732204838; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Kh4aJBp663sZF0gNmhoVRvg4KFXYsQigJuqU+FwivpA=; b=EiEUdOfkLBXm1QY7/X7yh4Zvo9TWTop+gJbdKjilCYFvzXMnoc8jHOEeDJUcXnQpTaP3Lx HJJOimvcUpe2WNDVW1KuEX3E1Ub/OYbE7/URVspFWszBLY00NEK4jsXAYLI4CWt2uM/+E8 L+DcWtrvY2er+43roVZG9Dgzasnuqa4= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=WQQNQN55; dmarc=none; spf=none (imf02.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1732204838; a=rsa-sha256; cv=none; b=8pKWdwEhtghjFE+EfOgSp9y202zQ1ZMb37104DbCd/SnrgfA1m3aWDxxqir7yO4YXFYM/W gCqEZpQONRAQd5sFAcuU9XaOZ/ckidyrUm9f1rfg/JbwUObnvy0TZZeCiqjcOSvAIn8eLM /bFn7zWyZEQs8Y+lIAuFr92KkDm8f2g= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Kh4aJBp663sZF0gNmhoVRvg4KFXYsQigJuqU+FwivpA=; b=WQQNQN55cyPyaGfXznyYljEubl QY29/yTRHeaOMh00hFeAgrTER0So1DJmo8KC+2XnZ1akC5f1jJOxnlDbLxyCzqknaNjWcFVqQYFsW yg4N5TfkzxR7TQ+5/zIDOmW+RPWrND3cg8n2Dsn7lmuv1sreZAViLcCYm6y5jZvW9vYFLP9a0pk0x ugvgv9mCxXCJlQLatGMQAnwJKmBH8t+1fTxkEHez7VxnjCHXYUXI5i2yxrvqsJBjaJpA0ojHSvzid GPCWG4OV+1+DphDOHiB2emjNV3V40yC6jgfCKXbtrbKSJgki9+qe3JHsPiTX13yGgueJwb4HXBTfF YJ95BgvQ==; Received: from willy by casper.infradead.org with local (Exim 4.98 #2 (Red Hat Linux)) id 1tE9d6-00000006YCj-2oMD; Thu, 21 Nov 2024 16:02:04 +0000 Date: Thu, 21 Nov 2024 16:02:04 +0000 From: Matthew Wilcox To: Jeongjun Park Cc: akpm@linux-foundation.org, dave@stgolabs.net, Liam.Howlett@oracle.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] mm/huge_memory: Fix to make vma_adjust_trans_huge() use find_vma() correctly Message-ID: References: <20241121124113.66166-1-aha310510@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241121124113.66166-1-aha310510@gmail.com> X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: E0CC28002C X-Stat-Signature: m8cd4arkj4kizrokptjtbpkhkqarc9ek X-HE-Tag: 1732204829-787125 X-HE-Meta: U2FsdGVkX19Pdo17wL6cLAuoq/hZxIp9T/iUu5VJiS+2o/ai932ZU5hPEodkPkAhmsBXCrSgKJVx/CI2iJYIqFuz/FD2cgjHoTrqWSZ/TS7osHoKpyxY3PwcV0vIt3hCj4YRWcge5YeUa2DpGIJ9j6u28cXnmS0OrLfYS1fmlm0stAop9i8W6KhxJSI6A1Bp2m2x8/h+ObQRCWh8wUT/5xDsNKehb9EmSEc5qBGZor7TlUyRnfUe/8RtlF0XURyYR1Niy1td7dyp3APcgSorUfBOz7JMpzexTop/teBCcY6nJ7EAYMjze/N/hiQeYSSRy8tDqXdcS0KecAgBSBwJ6eQ7PQx1wa88gfq38QjoyEwfKO1lk1L6l0KjUrPpdQgZmmiZNmgu89J+0z12ybvTGaQAymWZ6RpYqJtX51QHMl7VLT3GYvMV1T1a1yMLkFr53n5Qc4REnM2Eeqkb8BXYYpeMYSMDs5Ex0uTzU7gTdH0enuFDZzTq7/ZFUUL/SbghV+6FdhYyqv8qE8phm99tiGeR23z5ZxyCi/c1mP3Puckq3/AoX7FikfnNYWXyKzfGTAG3ah9eFc5HjbRqIPjSe4SDnKgMu4mR6Ub2SSLP7zsVWU7zLJUHCTbKmgfJJnYOFdOcnsiRWL6MeDqxQtwzTLDobQtTibgySvAfYSM11zWvSOJg2wc9KSdf4wCo6DXd63u2rRRC+VBNn7O/gsyrIhqfIJUJZp1HK7x01Wbvanv7bdQdhmpn+qpJ8bNHS3JBc7ZjnxOWS1P+zqVRZ/GMXLqzPBh5U1QzMI6TPRU8ZUkhJGdlQTQjuLkLCeosNXFEp6v4DUmNR8uHB+QcxfIYibdNpODE9ua81CV5yEPxZZ9bxFVuwBJodHStrAxoP6du8Klg2Vwb0BvnPfL9MavP804p64vZaHrJUkeI5LbvYog1/W5YJ1Siz6wTTYeV5wNqWoKw840rvj8uMEvOz74 ryBDraWr AovgrC5/cdlgW+TiwACS4WLrfHC+D+9x7dgFXfmg9p98hJPvAgrjGdPCBS/2SYyAbVvom8LCCyVb3uememQPsDnRwJEZSPPqQha/4MnGr5Ragp/znBYXA8i75Cq4093292XkhO0+sc0POCzysjEMVfsHObB16WDuXuWn0SrvsBxlaHlBEmg9fa3Sn3+gvkbU69bhU0oanEosxnIcK2BtyO+r5+SdyX98dwSHERhAMW6esUPCjhTdh1dZtwbvoQsddOH++MtltpTgNkLD3KxjcMX+TJyxjIBHCWWUyGfkWgMqYGbw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Nov 21, 2024 at 09:41:13PM +0900, Jeongjun Park wrote: > vma_adjust_trans_huge() uses find_vma() to get the VMA, but find_vma() uses > the returned pointer without any verification, even though it may return NULL. > In this case, NULL pointer dereference may occur, so to prevent this, > vma_adjust_trans_huge() should be fix to verify the return value of find_vma(). I don't think we should change anything here.