From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4CE5D75BD7 for ; Thu, 21 Nov 2024 08:43:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 053936B007B; Thu, 21 Nov 2024 03:43:26 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0029F6B0082; Thu, 21 Nov 2024 03:43:25 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E0CA56B0083; Thu, 21 Nov 2024 03:43:25 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id C6D5A6B007B for ; Thu, 21 Nov 2024 03:43:25 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 770B6140BE0 for ; Thu, 21 Nov 2024 08:43:25 +0000 (UTC) X-FDA: 82809461616.24.B640093 Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) by imf21.hostedemail.com (Postfix) with ESMTP id BD5D61C000E for ; Thu, 21 Nov 2024 08:41:43 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=F6kiTDeU; spf=pass (imf21.hostedemail.com: domain of mhocko@suse.com designates 209.85.221.50 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1732178452; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=jLSsZ5JOZPvpqG/LZBTATMNgJ0P8sq7dJjWcV7/MSNs=; b=7VABR1ckk9Kp7chL/N2tPwR9dPdMVac1r/uWqerYai9nml4yvoYHAUU6DbNCQ6W3TODIdt sz9P+WxFOQlfpLvBX/A/WZL69aPe2YHZFAhGbJ/s0doUsqtrefsVaTuYyy6SkHrzjuai7W PXtn4vbjMkBFW42plqLo9/Ck3H0P9kk= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1732178452; a=rsa-sha256; cv=none; b=ykd2iPaLYlUuunB57ha5zNh6lZYy0CX7F7yUFvrCcOtN53RDhD63TimFElDCpi9FH8Ytgu 8ZMZQGjy//rubJz6CYoN9UHTPlIAkjMRHcEzpISaf8gioU3KNMBFjgajrek2W2S49SNZ8J 4TT20vrTikSLpBxTKUBk5xacZf58Z3Q= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=F6kiTDeU; spf=pass (imf21.hostedemail.com: domain of mhocko@suse.com designates 209.85.221.50 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com Received: by mail-wr1-f50.google.com with SMTP id ffacd0b85a97d-382296631f1so413373f8f.3 for ; Thu, 21 Nov 2024 00:43:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1732178602; x=1732783402; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=jLSsZ5JOZPvpqG/LZBTATMNgJ0P8sq7dJjWcV7/MSNs=; b=F6kiTDeULpOr/KsF5bkQ+qkJ4isppM7wX/pGp3XXZvTo6YLysT0YldfDzDdKfk+Hrh kkxz1MA3yE70umdFpn1Lr3uFJq6qdrLcqsT+NdZTXcDkJnAVqJic57fyv03hp1OtfvQr MwykvYE43n9mVotX0lgXPCxEJ8wJ/Io510/p5wPI464CFk2LUa0ClyECfC7/hzEUBIul Ofh4NJ36w/o+CG6oE52TDgbWzPAS3bAyc/H+g8nWyIVFqFKqqfglI2IP2Rw7XY/exYf1 zsqL3AJa7C79/71Lv67tK9878dVfGpnGEjdKDPmEQY6AkpNaCr2BwWb71epzn3DpfGrz 503Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732178602; x=1732783402; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=jLSsZ5JOZPvpqG/LZBTATMNgJ0P8sq7dJjWcV7/MSNs=; b=iZzFMBD6ZlhGEgqm6X4JbvsdVcAB9Ac+pjHD6rN4XhjXERHwqXTCBOYCLnK8i8iyPB HnLcZ6U8hJ7xR8ogA2VA+o9N9+JdBSX0yglJXXfyeWL3TGx964w7VaPV8tH9s9ZcGKBe Q0mw48pvGFhrtDfCUV8x7KwZtIJ/aaE75qbujHmd0alUvA3axBwatRvvUcquIQrLkj+a /J9/9PjySlHoy7cBcAEEYAWusSKanrhJohQkEtgl1b2Zj7+cLMymBZfn4eG36PWEHykG 51c62VKxR1vkAUuDzDWZovTO3fV4jcTNupKZtQDxQoUh8FZ+Guglei7bE9PAJQJvKEBr 6Lqw== X-Forwarded-Encrypted: i=1; AJvYcCWlwnHty5Zvo+C/xNIMvXB1ksx5mUkPY+K18RKOzaDJdHo/y290n/3nh+cWVatGyfMPLhOd8+CecA==@kvack.org X-Gm-Message-State: AOJu0Yxqi4g3T26WtSmq2riIRy+neWWqmaX1m/FZGXivlehPFWgu9ADi Q2iaAMO6XRT8lvMpZGdjRSZIdVViOPeoXcrB8QzUSJc/8NB6gqrghnx5NMAuSi0= X-Gm-Gg: ASbGncvhHrSPdNqj7OvYZKuB+tt6fiaGX8Res0SnOnzyYxHcoSVTOwzz8ZYxMelLTv9 uK3UzqIxInKZsJWxtfx5Qf6hAR42v3zCNYkUOtpOt1T5/IY0/8TSW8QGoLEUTGZdthEggEsx07I yu/9T6P1q2phO7WPz0ORtLR1yvfhxzoPM7oCUMy7cS/JDHMdxK1uINWOymmzoFUTS0sxxNZ+jNa 4If9DojQgKmzo0Vr6hQmjDFG9Rg+5IxVJuuqwp6 X-Google-Smtp-Source: AGHT+IFpzheFe8Pg8r0thIYlyEIejMxQZNthE+3ERMHDXChvRhZ7QOfLnjgXRaCi9TO530mI1wAQ6Q== X-Received: by 2002:a05:6000:154c:b0:382:359f:5333 with SMTP id ffacd0b85a97d-38254af5268mr4115907f8f.22.1732178601810; Thu, 21 Nov 2024 00:43:21 -0800 (PST) Received: from localhost ([193.86.92.181]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3825490ca19sm4207193f8f.39.2024.11.21.00.43.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Nov 2024 00:43:21 -0800 (PST) Date: Thu, 21 Nov 2024 09:43:21 +0100 From: Michal Hocko To: Kent Overstreet Cc: Shuah Khan , Dave Chinner , Andrew Morton , Christoph Hellwig , Yafang Shao , jack@suse.cz, Christian Brauner , Alexander Viro , Paul Moore , James Morris , "Serge E. Hallyn" , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-bcachefs@vger.kernel.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, "conduct@kernel.org" Subject: review process (was: underalated stuff) Message-ID: References: <22a3da3d-6bca-48c6-a36f-382feb999374@linuxfoundation.org> <71b51954-15ba-4e73-baea-584463d43a5c@linuxfoundation.org> <9efc2edf-c6d6-494d-b1bf-64883298150a@linuxfoundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: BD5D61C000E X-Stat-Signature: bbbr3wekojkm6zjuqkpb7du1sezkwtzi X-HE-Tag: 1732178503-131635 X-HE-Meta: U2FsdGVkX19YvM/Gev4l5H62T24Z1oeL1VH323lmF7QI5zG503ZjhYcQ+I8nB3bpQEUu3mCHIa881QWm/3JEj8ymsGoi9enTD662r7HxMjw5ZC4sCVkztvHTxMpfXZIqK6djh2/hYZFAiSO0DKAtn/XnUv7SdQmnc+M51vV0FCE5dwPzLPfB+NCOB+Hus4UOmR0ayP4Gk/gQKIZM9clxm7Z95GLczRr9bwqAh5sKDlw2SGoh/1B/0o8cbAlc0z5GlTwHHK1newO4S5DCesXi0Dqryvp5iELphiLI+e1QseyWmh8SLo1m1gkYOp1h8ChymDvAPVwj1whKZ9YfFSEaZSubGTljSFA2ExOgRjvV5cRRc4OSx5Z2PgLmxpHHT3hO9cuDhTq6ReDbtRIVMRoBdRO3Hk94ycWDR372zxY+nwEhyzQ2genU+MzUlCkrF3bUU1UxL1Pjqgh+ynp+sbn0V/wYwwy1VpzLiNJA3PIKT7BNiLFNu6wamVOY3w6N+5Iecs8odTcLXh92fqwch1dhKAkLuSg5OIC/kFND1gtFcrOd62k5zzXIt6t+MepaUl0rIs3dMAdz52uNbkmt/X6cvz1huj6Glb4t0fTp5wxhZgrcpYtVw+vIGkl54JOrWguYxbrEAnzjC4wX1SGdFLcDg4Hrrnqhq2nIqnTyQVj4pVxxeKwvEjXzkwJ3awYAz6ALxMzLythHRO3tLaR6COrF65Jojy1zoKadS+kG/WRs+o6atNMmmZACIE3vs4PRXjhlvTGleVVD2TIt+dy2i3GU4KFR6tKUMjOdu9RF8zaPooxdYtmH1SHzW5OkvkqD4nPCN5oBiR+gzOHH2u+VFEVTE2lb39dD6OgJMTHAxoeIeeaGBPRn4uDeRVeIM1LUtKW+HeY/C5UuSVgZZCBGbTrJnOwJLbOtqUynuXstLzErgfZhKNGghDU1OF46yZfDDTx8Y9XFCYRVUBygaCSpZ4s x0LgY+3+ BmcH5VZIDlV02+LjIV7a8Spo0JAp+pYQ59RhLrx2DV/t9+dStD7jkvEHZIOS7JSsNe5J9mpMUOKy1xjCxp0k5RDdJLaHQZW7/b9L2vineUEQQ05aaf/14IBum8xwi2CoiMiWGxTYv/Cb6CXIy1ZV/laK0lnhlAA0/e30V3PrYBHomHqdUv+4ociencu1D+krfidMV5kPclukhpMOmFxh5IOaI3OmnfONTZFkBY3Qwzu+dxR9Ofp9nGaBPnYQErfWmow7OBJQ2Ow4s5hci/vfgSQijRM5l7C+nlWrU7L1LeReSAfyu5C/zL4e7HnTszZD0HaZdPZ7Ydgu7CpRQ/W+hbcM520ZJ0nKxcxYMlpXNuzz2D7LV/nl4embv6hg7piOj+NtqGf6AY+uNmDJaMq+NI63ufMqSNNATCHfdKv18PY6wA3MBJcqIg6vf44XeRuguaJKKj/LWIqFUk7gd5xceGqwCuGtVt9nZPf3cKUnRE5aTI0g6XAgtmd/F9n4+IaTVFBWz X-Bogosity: Ham, tests=bogofilter, spamicity=0.000004, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed 20-11-24 17:39:09, Kent Overstreet wrote: > Michal's (as well as Steve's) behaviour in the memory allocation > profiling review process was, in my view, unacceptable (this included > such things as crashing our LSF presentation with ideas they'd come up > with that morning, and persistent dismissive axegrinding on the list). > The project was nearly killed because of his inability to listen to the > reasons for a design and being stubbornly stuck on his right to be heard > as the maintainer. Couple of entry points that might be helful for that. https://lore.kernel.org/all/YxBc1xuGbB36f8zC@dhcp22.suse.cz/ I have expressed my concerns and set expectations to move the work forward. I've had couple of back and forth with Suren about specifics of overhead assumptions from the stack unwinding IIRC. For the first non-RFC version my feedback was https://lore.kernel.org/all/ZFIMaflxeHS3uR%2FA@dhcp22.suse.cz/#t not really "maintenance burden only" but a request to show that alternative approaches have been explored. It was not particularly helpful that you had expected tracing people would implement the feature for you. https://lore.kernel.org/all/20230503092128.1a120845@gandalf.local.home/ Other people have also expressed that this is not completely impossible https://lore.kernel.org/all/ZFKNZZwC8EUbOLMv@slm.duckdns.org/ The rest of the email thread is mostly a combat zone that I have avoided participating as much as possible. I didn't have any reaction to v2 at all. v3 was aiming to be merged and I've stepped up as there was no single review at the time https://lore.kernel.org/all/Zctfa2DvmlTYSfe8@tiehlicka/ I admit that I was really open that I do not like the solution and I've said reasons for that. Allocator APIs have always been a large mess of macros, static inlines that makes it really far from free to maintain and alternative ways should be considered before going that route. I was also clear that support by MM people was necessary to get this merged. I have explicitly _not_ NAKed the series and backed off for you guys to gain that support. So essentially there was a clear outline for you and Sure how to achieve that. I would really like to hear from other maintainers. Is tnis really unacceptable maintainer behavior? I am OK to apologize but the above is in line of my understanding of how to ack properly. [...] > Next up, PF_MEMALLOC_NORECLAIM over Michal's nack - I was wrong there, I > only did it because it really seemed to me that Michal was axe grinding > against _anything_ I was posting, but I still shouldn't have and that > was more serious infraction in my view; that sort of thing causes a real > loss of trust, and no I will not do it again. Yes, this is simply unacceptable! Just to put full context. We are talking about eab0af905bfc ("mm: introduce PF_MEMALLOC_NORECLAIM, PF_MEMALLOC_NOWARN"). I have pushed back on that https://lore.kernel.org/all/Zbu_yyChbCO6b2Lj@tiehlicka/ Rather than searching for support elsewhere you have completely bypassed the whole MM community including Andrew and pushed that hidden in bcachefs PR. This is breaking trust model we are all relying on. I am cutting the rest of as something that is not really material to maintainership discussion. -- Michal Hocko SUSE Labs