From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A8A4D44171 for ; Wed, 20 Nov 2024 09:47:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 91E2B6B0089; Wed, 20 Nov 2024 04:47:10 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8A8AA6B008A; Wed, 20 Nov 2024 04:47:10 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 721046B008C; Wed, 20 Nov 2024 04:47:10 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 4E7376B0089 for ; Wed, 20 Nov 2024 04:47:10 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 0869F1C7141 for ; Wed, 20 Nov 2024 09:47:10 +0000 (UTC) X-FDA: 82805992668.08.A2A06EF Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf21.hostedemail.com (Postfix) with ESMTP id C870B1C0011 for ; Wed, 20 Nov 2024 09:45:30 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=fxj+9SR4; spf=pass (imf21.hostedemail.com: domain of bhe@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=bhe@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1732095783; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=RQ/EL0J6kjGmTeoQldkQB/yJmR9CyO2pv3yRZbq8j84=; b=mf/yiXMudPrkks3kZpoT9im1Hxa2cOPjkCGgjC6DxpE+p6ItjeWwLuWrNPX9diYlG/uPLj WHPD4ki0Jc/c3twKFPqFi/QUA+4VT+KqjFniq2CQODJFumaHUv3/Vml3ghMCXezn3CL20U kkijJxmh8zSLr9kA9DpNs5k90WELfbA= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=fxj+9SR4; spf=pass (imf21.hostedemail.com: domain of bhe@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=bhe@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1732095783; a=rsa-sha256; cv=none; b=1XiO1yfQqqYBIxDZPxwHbvYtE919VrCPisk5QELKG2iNgScwmkS7Ct2JC8vNAx1wXxUe/T jP6Ahv9qfooVgd3ne82MJrcQuJcyYAmZAJw+6gj0dI+NaUxnecaw6QmmLHfy0xJUPRyBiZ 0OapFeCrDlOK36Wj1YK5GxhhybKhJJc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1732096027; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=RQ/EL0J6kjGmTeoQldkQB/yJmR9CyO2pv3yRZbq8j84=; b=fxj+9SR4kWRFT4/nelYaba4R+NGH6c+6LWqHvsO3XuEH/jhwdOWZG3n9gTenyvRfMYjPZA 7FSClvE6GDERYLgV6go3PKlyKBoQpAxbSz5wV7vQT50h6n+mvPNvW6KpLbRObqwV8VE8NT ztyBftS8fRfkzdr6MR3XRqM9tEZ+tVU= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-425-Humkb_9bOb-2SPRao4GIRw-1; Wed, 20 Nov 2024 04:47:03 -0500 X-MC-Unique: Humkb_9bOb-2SPRao4GIRw-1 X-Mimecast-MFC-AGG-ID: Humkb_9bOb-2SPRao4GIRw Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 770D91955BCF; Wed, 20 Nov 2024 09:47:01 +0000 (UTC) Received: from localhost (unknown [10.72.113.10]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id CE26530000DF; Wed, 20 Nov 2024 09:46:58 +0000 (UTC) Date: Wed, 20 Nov 2024 17:46:54 +0800 From: Baoquan He To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-s390@vger.kernel.org, virtualization@lists.linux.dev, kvm@vger.kernel.org, linux-fsdevel@vger.kernel.org, kexec@lists.infradead.org, Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , "Michael S. Tsirkin" , Jason Wang , Xuan Zhuo , Eugenio =?iso-8859-1?Q?P=E9rez?= , Vivek Goyal , Dave Young , Thomas Huth , Cornelia Huck , Janosch Frank , Claudio Imbrenda , Eric Farman , Andrew Morton Subject: Re: [PATCH v1 06/11] fs/proc/vmcore: factor out freeing a list of vmcore ranges Message-ID: References: <20241025151134.1275575-1-david@redhat.com> <20241025151134.1275575-7-david@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241025151134.1275575-7-david@redhat.com> X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: C870B1C0011 X-Stat-Signature: kjkp7gkusidxheyrfcbiq7ymksbmewu1 X-Rspam-User: X-HE-Tag: 1732095930-974591 X-HE-Meta: U2FsdGVkX1+EZj3qeG1UaVU83lumT1DLSBdqYHELHYcZZSLnr625ptiFeVQkYa0r+qnBR+BFORWGOl77bzZF/tSTIZo/EUxnbIOdO/OaPAAzl3oV6R7OOG2BcwPLv+vk0ADsF5V6JUZoTlY5+bEjPmYp4xj6cQ+DAVPP4K1jpVCW8LVVczXjrEGb2eXk3I5x9EHZEKXBg4TmyLUkBQi10ZYUd7REKNBoqhEL1K9jvihg9w4TEELwAjQZSoiQ3PN0FI6fqVYsgAeYzXXbuNcitCqpyArGEoCpE+WN1icaROeslXhXqDgKohki3XEwyOZbBdUdhd3bo5DI1g6BObxAMmfCfnxCShFjjnpM49yiZQraVxS+C6eebg27JTJRkcRHaecOkwJRmS28uyTB8LSK8yHZ8hqjB3eMfdvX5UrBH/oJY8L0Gc5aX6/lCxmZpSLKNMWD7EUh0ATdMpSix2DDFHl/LVc7Hyx9oN+c7+LInIczD0AVBS9M2Ooae+44cEoHmt86MlIgNZnmlnexPcYAjgiL4iJAsf0sxKgtVlH/+dXm1nhdNmtLrhwwBfZHbZvxgOoUzCMAZdVoh3jDBwkwdk0lENwEel5VLsuFgFlC87NBNm5zVCUV3zxLdd0GWQcng6v0T7bWrVSHZAFPPNbAIO9TjHP7t3h1kY5n9MBCvqK9VcloS3Alxp/qpOUo/RMS7M4un4xnXFU6pRiwVlccQY5ONlEbAtDL2DFBrTdibyUQ7v9/MNCcRKRew/PWluVW3nWKCrvV1SctT9uG43vc0J5n+65FC7uZZYRto+QRZsn4wBMDlb+VgSKGLLgXBaijsa08Y3qVO/6mEvcJvf40RCWcF8n/dU7wsVLxWhqquUw47mK7ZzSVsp2znZ4zVZF+zrHC8QvpvSu1EWwl+6NCQrljrWKqc2vaA+4ZvlDagj+BxTTO5p4rNZftLPoFoTcagk3ovBsA7g/wx9UE9EA TU6C/RL5 VKe2Rh/ZMnne4cJxaPAJDGWT3cLgjtoYODSMIZIOCTojXlinnssKBuPuUbzUsx+LbSWQPeSfKzf13ox+aRnz8eE+tNujaamS6UrwJ5m0VdhYJsrMwt+E2RXd//VL1C/s1GUoVOUpVpft9rWlxQjrLDqytIWcC3mWkgdYmYkVajs3JH1j0/loB5eh33pO/VoCvpBkwqT/94UCs7O1FqWMTTtW0MTU4xkm5c/1EV7DMoo4EBZoPyI2dzU/+nPeNlS85soa41Vf/KFmEVnKnbX6JfmnjTHUCgZ9SK5JIuPGQEsqZfwXbB3oxbozX8v3L3X5yx6ueWjoH17aa13nvLb34cJH7YLuGM2+QT2Fx/PX2EAMGVIIXgbmVybAk5w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 10/25/24 at 05:11pm, David Hildenbrand wrote: > Let's factor it out into include/linux/crash_dump.h, from where we can > use it also outside of vmcore.c later. > > Signed-off-by: David Hildenbrand > --- > fs/proc/vmcore.c | 9 +-------- > include/linux/crash_dump.h | 11 +++++++++++ > 2 files changed, 12 insertions(+), 8 deletions(-) LGTM, Acked-by: Baoquan He > > diff --git a/fs/proc/vmcore.c b/fs/proc/vmcore.c > index 76fdc3fb8c0e..3e90416ee54e 100644 > --- a/fs/proc/vmcore.c > +++ b/fs/proc/vmcore.c > @@ -1568,14 +1568,7 @@ void vmcore_cleanup(void) > proc_vmcore = NULL; > } > > - /* clear the vmcore list. */ > - while (!list_empty(&vmcore_list)) { > - struct vmcore_mem_node *m; > - > - m = list_first_entry(&vmcore_list, struct vmcore_mem_node, list); > - list_del(&m->list); > - kfree(m); > - } > + vmcore_free_mem_nodes(&vmcore_list); > free_elfcorebuf(); > > /* clear vmcore device dump list */ > diff --git a/include/linux/crash_dump.h b/include/linux/crash_dump.h > index ae77049fc023..722dbcff7371 100644 > --- a/include/linux/crash_dump.h > +++ b/include/linux/crash_dump.h > @@ -135,6 +135,17 @@ static inline int vmcore_alloc_add_mem_node(struct list_head *list, > return 0; > } > > +/* Free a list of vmcore memory nodes. */ > +static inline void vmcore_free_mem_nodes(struct list_head *list) > +{ > + struct vmcore_mem_node *m, *tmp; > + > + list_for_each_entry_safe(m, tmp, list, list) { > + list_del(&m->list); > + kfree(m); > + } > +} > + > #else /* !CONFIG_CRASH_DUMP */ > static inline bool is_kdump_kernel(void) { return false; } > #endif /* CONFIG_CRASH_DUMP */ > -- > 2.46.1 >