From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75324D6E2CE for ; Wed, 20 Nov 2024 08:15:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BCA446B007B; Wed, 20 Nov 2024 03:15:06 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B558B6B0083; Wed, 20 Nov 2024 03:15:06 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9CD2E6B0085; Wed, 20 Nov 2024 03:15:06 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 7B1EF6B007B for ; Wed, 20 Nov 2024 03:15:06 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 1631D140B62 for ; Wed, 20 Nov 2024 08:15:06 +0000 (UTC) X-FDA: 82805761416.30.48FF745 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf24.hostedemail.com (Postfix) with ESMTP id 86E01180021 for ; Wed, 20 Nov 2024 08:14:57 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=AxTXJX7s; spf=pass (imf24.hostedemail.com: domain of bhe@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=bhe@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1732090322; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Gh6m/YaiQcWez3DW3gpI7yQKGyz075BISLGCEYs6JIY=; b=tr5BRuPgprZQcCOux+h22yggTgBiPSCUu+My38LvwMeUIc4jhjfRFwnRMi/UUL6LUBLZWM 8YFX4V+XJ8eEwGQKldKDlZNY2us/0D6y7CO+JWZHkei2dntBc1a+NxtmQxXtkuN2DOmw4h Nu1GOjo/on78HBeVVnV5H+jXYYii/8s= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=AxTXJX7s; spf=pass (imf24.hostedemail.com: domain of bhe@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=bhe@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1732090322; a=rsa-sha256; cv=none; b=UVdzbvp/v+3ineMNC+30ZpyTIGT/y5VOgwF9cN5Qk5F5CFYmMLqr7e+dh2dD/1RsWbUEN/ ERgnj/AXKZd8tUN/+8/YyYhP6CKqBdWLAQA4gC2AvOanZQ2Ko+h5m0u5BJLOdCPajKHLTp 5+ASG4Frnc8KTOgzi3O6q2VVJd1/2ao= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1732090503; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Gh6m/YaiQcWez3DW3gpI7yQKGyz075BISLGCEYs6JIY=; b=AxTXJX7sFRjPxKptNgJpKUiZdPvNvaZnBXdt78lybn9GvMFz5+/ltTl0jFL21tYRNdqtyo um60Jp1nNKrnILjUJwba6QUUOkJ0qH2QW1yvyHipO27F3D8qEn+mXKquVSO+9XItCElpeZ FLIDC4lhCSF0onQG8T2UOdmGZ25Ps2Q= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-589-pqFBDy8RM8a5-PwqnLhryw-1; Wed, 20 Nov 2024 03:14:59 -0500 X-MC-Unique: pqFBDy8RM8a5-PwqnLhryw-1 X-Mimecast-MFC-AGG-ID: pqFBDy8RM8a5-PwqnLhryw Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 1D3F9195608B; Wed, 20 Nov 2024 08:14:57 +0000 (UTC) Received: from localhost (unknown [10.72.113.10]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id C9E9B19560A3; Wed, 20 Nov 2024 08:14:54 +0000 (UTC) Date: Wed, 20 Nov 2024 16:14:50 +0800 From: Baoquan He To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-s390@vger.kernel.org, virtualization@lists.linux.dev, kvm@vger.kernel.org, linux-fsdevel@vger.kernel.org, kexec@lists.infradead.org, Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , "Michael S. Tsirkin" , Jason Wang , Xuan Zhuo , Eugenio =?iso-8859-1?Q?P=E9rez?= , Vivek Goyal , Dave Young , Thomas Huth , Cornelia Huck , Janosch Frank , Claudio Imbrenda , Eric Farman , Andrew Morton Subject: Re: [PATCH v1 02/11] fs/proc/vmcore: replace vmcoredd_mutex by vmcore_mutex Message-ID: References: <20241025151134.1275575-1-david@redhat.com> <20241025151134.1275575-3-david@redhat.com> <9160c6b4-f8a0-431d-8a21-ead510a887a1@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9160c6b4-f8a0-431d-8a21-ead510a887a1@redhat.com> X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 86E01180021 X-Stat-Signature: ri83oocbt94pppju5e9fbd89u1ai8mye X-Rspam-User: X-HE-Tag: 1732090497-849706 X-HE-Meta: U2FsdGVkX1+PwUGvl+ZEiyiwMBjCOJT+ck4WDSSOmFPPLOBByIIdCI0OhIYdz2N6UttdkVGoN9kutIU7adBakbPgn0c13XuesNPUy+i5APzkLHYmK7GuBidIKn1FV7R1+YWE8HUQu5nLxfBID89SMzyxEoaHFS9T2I3rpqZ3A8yp7PmdIUPa67qW7aeS/5WaNN9og3tB8LtR4Jy2L+xQUcw3pVqh9BPJLC+TRFWmz93q/WysL8mGNo4hs3YLz4azRyu4w1Wc3WmbZ6Zwtu2hIOMg/QDNA59Y+/iAhvGxqln57bL8gTXaf3WxxWPLkw3eZCX2ys6M9T1Z4zK4l09NeAsx/vBcEqo6GsZDH/ccIO4D59w52L/taN6Pnec8JRefcJp54ygaX99VpuO2XEO0apj5klhJGruirNKIYMKIZ+vnr3zldUQ6FoiRE/JB17v/6QvKi2yxqml7BVJoNvzXK932A5ZHsjWTGcMDxg7Z7LXy1oOkJGcOJlyYIWqlboRa99AOHifDBl/VaTIMPydsasByJyX9LoNfAMcdhCevXlLnQfeqLOC7c7kE102e8As+EayCV3B4oh3ywzxeeefj7f+eFITZ+P6bHWhhd+/YIaaCyv8ODHNJhHb6ciBQw087o7QVV5Qtt/qatk88hJZaN6fT2kpOPmwbW0xDSXYUX1Km9HOtZKqFu6O0VZMYCwd6zn3Nz8fYGG+F1JQiHk4J64E+st6pxJqQifiIMQwuAlZDmTwOTmWOBzqh3wMyvDRNYU+ltEjO6D8Q4Yao0kGTLqKS7v5FD2VyxmCdg5WXv+ZuPQOHubm2t28PRb4DVIKd1AMFKnR39uLScm7170r9KikOHqylKdbSM5KZMTE/nPe5xReY/6cA+U0YT+Xjn8/nSQwd9g4urNY7wkum54x9vg1qQoRv1ufc3CcD7yhYehhigIN66WAe0X4/amYOuieJB7BLqtb049BLeZMJLIK 2piVb5+j iaGfoB+Hbm/BH1xDPeFwp+YnWNE686JJMeYpyidKUYTiZMNurDRDegsZKAsXpBU+cvaaMm8zjVJP0rc75iRA7775cbJIMF54vJ9pUIhOrbmoV87hiFBBqodTPN2oj7DFENm8/WPqjY6NsKolccHJU65O9lpbwSlT5FrlxiWBM8Nppk+RBvlqG3FaC/dKV/T6AsEugvRBzmpRUbGEXSNNXMnO+l3S8YLbNxinwITdVqB7s8TQGUC1mJC+lOxvsqkeEmrudRvlnP5HayJrTH2L5iOzCdgA4fQOQfJHfxEqEBS3Ooo4etEpf0mZ6mreqZl4d7ALaAIHX7tC1y+36ko47onJJ47qFntPErVYqsKOo7Kh5wzllMuDRq2TjIAhtX8vqHaViOhtivo73X+ox4wy3DYSHjllboEtYAqitMXK262C3L3A= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 11/15/24 at 11:04am, David Hildenbrand wrote: > On 15.11.24 10:32, Baoquan He wrote: > > On 10/25/24 at 05:11pm, David Hildenbrand wrote: > > > Let's use our new mutex instead. > > > > Is there reason vmcoredd_mutex need be replaced and integrated with the > > vmcore_mutex? Is it the reason the concurrent opening of vmcore could > > happen with the old vmcoredd_mutex? > > Yes, see the next patch in this series. But I consider this valuable on its > own: there is no need to have two mutexes. > > I can make that clearer in the patch description. That would be great and more helpful. Because I didn't find the reason about the lock integration and avoid concurrent opening of vmcore in cover-letter and logs of the first few patches, I thought there have been potential problems and the first few patches are used to fix them.