From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77788D6E2B2 for ; Wed, 20 Nov 2024 05:01:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0F6256B007B; Wed, 20 Nov 2024 00:01:43 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0A6626B0083; Wed, 20 Nov 2024 00:01:43 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ED7756B0085; Wed, 20 Nov 2024 00:01:42 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id D277A6B007B for ; Wed, 20 Nov 2024 00:01:42 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 8220E1409E3 for ; Wed, 20 Nov 2024 05:01:42 +0000 (UTC) X-FDA: 82805274090.23.EE569BA Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf10.hostedemail.com (Postfix) with ESMTP id 5C1FEC0006 for ; Wed, 20 Nov 2024 05:01:18 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=Gg273l5z; spf=none (imf10.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1732078809; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=uOV8nZu7BBFpdSK2SDuWNMcSh3DZHFqV7lmIQbSxDvk=; b=k/u0lxD2+gSckIQWF0KWIkeXMspODaiHArPXyD+XsmxcyI9DfB9HXTUjU/R89E0K5alINs 66sSbdnDPesPf3yzFYk1iQ+E5SC3HJXTcAWt5x3zFSKoOUVUKxyhAJKnKb0cZZQtBEiJS1 gqzfaoni6R7nLq+yn0YIpPqCEI93Gmw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1732078809; a=rsa-sha256; cv=none; b=qSHLVYRjFmg0hYpKWhFt7pwooELgdtg7xInjjgWBc5X9T7CLKgJNnzIZ+YnT/HgC+vGZC4 630v1pOsIyF5Qb3MTbG31sQCwMa3+d5HawRg3TDBiBMPSd6ICG6WaRXItOnuiqMYYB8jm4 igk1hf3iRWz2NZEHg6MNyVG0lDxhVnI= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=Gg273l5z; spf=none (imf10.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=uOV8nZu7BBFpdSK2SDuWNMcSh3DZHFqV7lmIQbSxDvk=; b=Gg273l5zeNHu8yBSAfqSVGLvY5 ZzFKKctS3gzim6Xlcej4C3U/ggLgd0BSZQi7wgBhWGnKw8IRY8yEh/emFas6c4+vc6gTEj0fDcfjW Q+dUpe2BnNG6NCrc9fj/NapIlYGrnqa4fh5KrlJdnr4TxDWbGK+CMuCyItsGFR59R02mJ2b24eObg w5MybKFrGqtYzn39nL1emiHUofwY+sw5/4bhP2qGeFLxddNQJ9AvYsLmo7pZaKGsK3lkQoe+IEtxj U9iCazBzR2TvyNiFlpU2RTg6V6V8ZBRJyg8JRhwK67UNYZQjGD9AuLLjmrvM5kIM68Nl2ruY6sh7A GvQFAL/g==; Received: from willy by casper.infradead.org with local (Exim 4.98 #2 (Red Hat Linux)) id 1tDcqJ-00000004rzE-44nO; Wed, 20 Nov 2024 05:01:32 +0000 Date: Wed, 20 Nov 2024 05:01:31 +0000 From: Matthew Wilcox To: "wangjianjian (C)" Cc: Mateusz Guzik , brauner@kernel.org, viro@zeniv.linux.org.uk, jack@suse.cz, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, hughd@google.com, linux-ext4@vger.kernel.org, tytso@mit.edu, linux-mm@kvack.org Subject: Re: [PATCH v2 1/3] vfs: support caching symlink lengths in inodes Message-ID: References: <20241119094555.660666-1-mjguzik@gmail.com> <20241119094555.660666-2-mjguzik@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam10 X-Stat-Signature: jx3ubjdgob6s3a35mf9yxittw68er9oh X-Rspamd-Queue-Id: 5C1FEC0006 X-Rspam-User: X-HE-Tag: 1732078878-146766 X-HE-Meta: U2FsdGVkX1/HSIZgJ7x5090sxCCA3MRUidA7EVVNiNXjp08BF2BxdIIBGLhbRIkJOId/+zZech7R4lqGoIDDExYQ60eQvH0whAUefgAve0jIP36bsoa68FCceaYWbW+bO6mKPaL0sR6rjHrNq6SJN46xs6M5v2uirDkG1RmTKCmSs1QrEd/Hf3YdhWDLwhwtItE5kJtRHGCJ+KhnfGXlgYGIl0KAe6DM+6CE3RVFmHQgqSJoOfbxwL0tRH4D79/0bKlMUscU/abeFm6J23N/R9y6SDvatxLdgfQn3RO7eDlHvaNMXlCj7ux8Y9cq9+pG1SZbFompGS4ooXV12EfBA1aKhqhwoNKJOAqRpmqWy5Q3aPR1ZPgSBC2tl3B9P/V6+P/moTM5Tp+UKySIgjgggjNm/dTkIXsBR5nmzD7aJBvqp5InLAj/YpU53v/2Kr0LjI1zqboluXPBBK7W+V7rcxIXmzsj7JfJsEcZqaeGqufj7TulQOmlrrvxPlmduORhuLEDbLMwlHjBefIqgO+q6DNIWZ57TrwwXBa4EmWKL3YmvRau5m0oynGwo6IYZjKD+oRO6Zm1yiIfksrfe+UWscGUqjcFzRIKYbGOPNsIsa/h5rZNxC24cvlI+P5iuyh33kDt776uVXCow2olydtmGAtt3Gokg/IZICatk9jIngfO2zMLAUHUDKh4znpFk90D0r7U7L3qqJA1ZIWomxiRWRxgcLSvRvDO5m9uyxKKqwFj23KB5Jlg0oQX+eGPGE8eSTl4Hnr8z7XYHBHbJMbO9Hj6ebAD3DvXhlgZoCdy2ArHSDHCn8ubstCDPN0L2SQr8f/hoaNrpLmsPD8lIIgHwFl82mLMo/AlpOx1F58qe+moGODq+VYBZ4xWWhCnHevcX8bh+DJqgYX5g1h9OWJsZsV2W8QuRCHvnaR6D7frqn1xyTRmwaIVHBQ3V4BcS69JwXrvZzyflicVc7VtcND LLus7FTr YfVMHcz+FCHDIbV9iMcrXLz/vHOXSmlOTKuj004o308HZCxvgdlI6hkFNTp25YaypFniln25TaN4nGNfT+E3YLr83Gbi7tAS6aug/ej+xpy+1VKX4gXWZOEJPpqZkKtqoGmg4071S1KDt8E7fsbp1yZTJ9KAj8xsvxNT4xOe+IdusjqNNgpu8haaAFwkyu5/YUrWwTz0WUCmt1+ijxayaEFBizD0Dgt8xb6gWHL7oOH/X+Z0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Nov 20, 2024 at 12:15:18PM +0800, wangjianjian (C) wrote: > > +{ > > + inode->i_link = link; > > + inode->i_linklen = linklen; > Just curious, is this linklen equal to inode size? if it is, why don't use > it? Maybe you should read v1 of the patch series where Jan explained where that's not true.