From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07BBFD4336D for ; Thu, 7 Nov 2024 15:10:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 93BB26B0085; Thu, 7 Nov 2024 10:10:17 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8EB496B0088; Thu, 7 Nov 2024 10:10:17 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 78C4F6B0089; Thu, 7 Nov 2024 10:10:17 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 57EEB6B0085 for ; Thu, 7 Nov 2024 10:10:17 -0500 (EST) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 0EBFDABEA0 for ; Thu, 7 Nov 2024 15:10:17 +0000 (UTC) X-FDA: 82759634118.16.6C02FC8 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf19.hostedemail.com (Postfix) with ESMTP id 606121A0012 for ; Thu, 7 Nov 2024 15:09:30 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=GuCmWcel; dmarc=none; spf=none (imf19.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730992045; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Vom1WJYdLvjku2r/Xl0EhIhQ5E31YZkW3BtO+U5Dsek=; b=DnhKlgfMa9374I4tBm9+GSIXzk68o1USZkiS+YDWUfosP6z9t7PWQ881AhlxgH4mm8MtVr EhFsHkLiga0rQs+PL01s3JqX4z5kxKCjNdmFRfw7MgfRrhNe3UndMiLcTw2FUamTZSjZCb usp0ZBnNfC324SZ6FIP/lI6M6W/csyc= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=GuCmWcel; dmarc=none; spf=none (imf19.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730992045; a=rsa-sha256; cv=none; b=Sbp0JoobQkQyq7aVH4AlRDmD152zUc1PKADFSQg7eau4ikMMVqAxKMTHcjW20uLbFFlYKx MwxpKZTjaYC6GiSFNdUAZ2yJlzotnVBlHZ1d+R69xUZkVne6VhXaHSDm/yhcjG2uTrLscB sXgUrptWNmhUhNqWJInNyYrCxuQ48aw= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Vom1WJYdLvjku2r/Xl0EhIhQ5E31YZkW3BtO+U5Dsek=; b=GuCmWcelHu3QNDVTgzwIceTERX /vZoa+fZx0pT+5jVIJzTCv4ZeGycAXKZ3WwH8ZIMz+UT6M09CyrfQf1dpKHT0h9TQDt7wIIwZFQMR jqTi79AogfM+fEMudUmIdznL/18LTQnR5GyxB3te8KLOPk2/tBUc41LuSKeak40E/SdOtz73JCu6G XqwMJZZPYY+Ahs8ZDynRIykD5DX82jInNorF8DV35Rroz+gdSejfsjnLsw+r9X9jP0LPRRRbCHyyU BTuDrcnLXh+iFBOFnLbAulo4+xDfmkRer56WnCT4YEvMuRMroRNIuix2qLa2bU/s9nzQ0smuqQsK9 dgIZeC2Q==; Received: from willy by casper.infradead.org with local (Exim 4.98 #2 (Red Hat Linux)) id 1t949B-00000006rdv-0Z6w; Thu, 07 Nov 2024 15:10:09 +0000 Date: Thu, 7 Nov 2024 15:10:08 +0000 From: Matthew Wilcox To: Shivank Garg Cc: x86@kernel.org, viro@zeniv.linux.org.uk, brauner@kernel.org, jack@suse.cz, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-api@vger.kernel.org, linux-arch@vger.kernel.org, kvm@vger.kernel.org, chao.gao@intel.com, pgonda@google.com, thomas.lendacky@amd.com, seanjc@google.com, luto@kernel.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, arnd@arndb.de, pbonzini@redhat.com, kees@kernel.org, bharata@amd.com, nikunj@amd.com, michael.day@amd.com, Neeraj.Upadhyay@amd.com, linux-coco@lists.linux.dev Subject: Re: [RFC PATCH 0/4] Add fbind() and NUMA mempolicy support for KVM guest_memfd Message-ID: References: <20241105164549.154700-1-shivankg@amd.com> <6004eaa4-934c-48f4-b502-cf7e436462fc@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6004eaa4-934c-48f4-b502-cf7e436462fc@amd.com> X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 606121A0012 X-Stat-Signature: eqa14m713hcnayn3cknhwaibkcte1uby X-Rspam-User: X-HE-Tag: 1730992170-438920 X-HE-Meta: U2FsdGVkX199XEX9XYfbp/Uk4CeLNkrpsk4GMEwVCG/zK5xvxOpyGS1ZySxYZBzitrFb4PWaOdLXqqumvxbuXat+ZVx952FoaYRQCp0QPodM2VBu8a3IovJnfZbVBD3WspHfxdHjkBPIkOmbS7G/89CmBWQYTutScVQVZsvsD339GFDx27A+evvyF1vQPnrkQl1PeKEzTXbFHHtIh+jeOyPATY3avO+Ls7SoPdCg8ZGJ4m4zeKOds7aly0KXlp4lsWQAy0pC/kAV+l1vzZfM1YDlWqRqBB/XsGnpUBG3O5bsUVXkRAHg0Q80TGE8EKp/MGaLPy7Cs4Z3+hnzcvX5+Kzf6pna+KVhC/dxTRNpvK/0Fvft9S0dAmtVyaa+z01j3ToNbIMPGmmZVrAa1Wrkf2JhVewLfDtjvolecRqExpYuoKweACFsPQuKRllP2RCGFxi8zf/yH3oT3zg40PKJXMhDtuuT7YX4XknKw8utt3wNHJu4dRVXTxSF/Lc37Mff/rXvDAMz7gLJEYbLi9mXnYLos0x3vc9jl2bYdPGGKegLigOWvsGqIVoBD2pXj4aKyn3kGIm3uHLtwUxvUL2q5fB/LAr5UqRAgb7YYlGqzXg1DYxW6GWmquzFxwFP4zOzxUpzaf+AFD19oFwPwH8CwT45Yh/rtV9qF03C0y34784guYSRA7cBsCOVk4NtH8XlD5sfyOBG7JtUB4QvQzWhWinKeKwgf8ab7JYjySpSqdIzTweK99BVdsY3SBOxB8D0leheYqtZXLkZki1lETKHyxaAKvx8S0hpLEFSZtGbw4ji1loupo4HozXjOkYy5Z0bzjzKKucqwJoBiIjWED5VyQiRdZc+9+tptQ6SR/ZtMIg5WiqEPnbN9oZatcni5yth1B+UtW6910lPwDCs/20bS3ZkRhxMtqnmojdONzLtDI2x7ilb3z7rO+BnhUHwls+kL78vASIWWSqABU8nEzX d8Jn1r0H 2EeYrlYTA4E6IHhzaOSxlXNRWb6Ug5O1FaXQLA40yNHovlD/7MUGSLoEz/KcALKNqXQbYNBkNYmuF5ZyHE53Oc66mf6sKkDjAz15OzHajEkAws29GAibWTj642sPhhqRnumMt+CI3b1+58EgNfWYBBMIT4GLYo+SAoZiEGiQt3OzV0RqmXO6JzV6a98UVgVoITVN2Wb2jPGNiE0caBX9QzXFv3PWCWUQjrdNNjU0fsbHu2yk+An4dLrkJ7IES72JdrGDC/jskA0Y/bVaNu7V0nTqSIA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Nov 07, 2024 at 02:24:20PM +0530, Shivank Garg wrote: > The folio allocation path from guest_memfd typically looks like this... > > kvm_gmem_get_folio > filemap_grab_folio > __filemap_get_folio > filemap_alloc_folio > __folio_alloc_node_noprof > -> goes to the buddy allocator > > Hence, I am trying to have a version of filemap_alloc_folio() that takes an mpol. It only takes that path if cpuset_do_page_mem_spread() is true. Is the real problem that you're trying to solve that cpusets are being used incorrectly? Backing up, it seems like you want to make a change to the page cache, you've had a long discussion with people who aren't the page cache maintainer, and you all understand the pros and cons of everything, and here you are dumping a solution on me without talking to me, even though I was at Plumbers, you didn't find me to tell me I needed to go to your talk. So you haven't explained a damned thing to me, and I'm annoyed at you. Do better. Starting with your cover letter.