From: Matthew Wilcox <willy@infradead.org>
To: Yafang Shao <laoar.shao@gmail.com>
Cc: akpm@linux-foundation.org, linux-mm@kvack.org
Subject: Re: [PATCH] mm/readahead: Fix large folio support in async readahead
Date: Thu, 7 Nov 2024 15:00:09 +0000 [thread overview]
Message-ID: <ZyzV-RV0fpWABdWD@casper.infradead.org> (raw)
In-Reply-To: <CALOAHbAYx-L2dH_97XhD1HTMwevBNvJrxNxa82qfKzwtKoOQBQ@mail.gmail.com>
On Thu, Nov 07, 2024 at 01:55:52PM +0800, Yafang Shao wrote:
> > Let's suppose that someone sets read_ahead_kb to 192kB. If the previous
> > readahead did 128kB, we now try to align that to 128kB, so we'll readahead
> > 256kB which is larger than max. We were only intending to breach the
> > 'max' for the MADV_HUGE case, not for all cases.
>
> In the non-MADV_HUGE case, the order can only be 0, correct?
No. The readahead code will use larger orders, depending on the size of
reads and how successful readahead is performing.
prev parent reply other threads:[~2024-11-07 15:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-06 9:21 Yafang Shao
2024-11-06 21:03 ` Andrew Morton
2024-11-07 3:39 ` Yafang Shao
2024-11-07 4:06 ` Andrew Morton
2024-11-07 6:01 ` Yafang Shao
2024-11-07 4:52 ` Matthew Wilcox
2024-11-07 5:55 ` Yafang Shao
2024-11-07 15:00 ` Matthew Wilcox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZyzV-RV0fpWABdWD@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=laoar.shao@gmail.com \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox